[jira] Closed: (OFBIZ-1953) Cleanup ship groups doesn't work

["Jacques Le Roux (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/OFBIZ-1953?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacques Le Roux closed OFBIZ-1953.
----------------------------------

       Resolution: Fixed
    Fix Version/s: Release Branch 4.0
                   SVN trunk
         Assignee: Jacques Le Roux  (was: Bilgin Ibryam)

Thanks Dimitri,

I agree with you, this fix the bug. The enhanced for loop avoid the issue coming from getShipInfo when shipInfo is actualised (one csi removed) in the loop like in your example. THis is possible because, with the enhanced for loop, we are sure to always access to the right csi.

Your patch is in trunk revision: 737443 , and R4 r737444


> Cleanup ship groups doesn't work
> --------------------------------
>
>                 Key: OFBIZ-1953
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1953
>             Project: OFBiz
>          Issue Type: Bug
>          Components: order
>    Affects Versions: SVN trunk
>            Reporter: Dimitri Unruh
>            Assignee: Jacques Le Roux
>             Fix For: SVN trunk, Release Branch 4.0
>
>         Attachments: ShoppingCart.patch
>
>
> Hi everyone,
> I guess the method cleanUpShipGroups in the ShoppingCart.java is buggy.
> If you have many CartShipInfo objects in your cart and some of them are empty (shipItemInfo.size() == 0) the method don't remove all of them.
>  

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.