[GitHub] [openwhisk] markusthoemmes commented on a change in pull request #4709: Extend the SPI entitlement interface

[GitBox <gi...@apache.org>]

markusthoemmes commented on a change in pull request #4709: Extend the SPI entitlement interface
URL: https://github.com/apache/openwhisk/pull/4709#discussion_r342498719
 
 

 ##########
 File path: core/controller/src/main/scala/org/apache/openwhisk/core/entitlement/Entitlement.scala
 ##########
 @@ -295,6 +310,12 @@ protected[core] abstract class EntitlementProvider(
             if (failedResources.isEmpty) Future.successful(())
             else Future.failed(unauthorizedOn(failedResources.map(_._1)))
           })
+          .recoverWith {
+            case e =>
+              logging
+                .info(this, s"failed to check resources: ${e.getMessage}")
 
 Review comment:
   This log will be written by the `entitlementCheck andThen` block below. It defines a case for the Failure mode and thus the log would be redundant.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services