[jira] [Created] (MESOS-2643) Python scheduler driver disables implicit acknowledgments by default.

["Benjamin Mahler (JIRA)" <ji...@apache.org>]

Benjamin Mahler created MESOS-2643:
--------------------------------------

             Summary: Python scheduler driver disables implicit acknowledgments by default.
                 Key: MESOS-2643
                 URL: https://issues.apache.org/jira/browse/MESOS-2643
             Project: Mesos
          Issue Type: Bug
          Components: python api
            Reporter: Benjamin Mahler


Unfortunately, when introducing the ability to disable implicit acknowledgements, we accidentally disabled them by default for Python schedulers.

{code}
int MesosSchedulerDriverImpl_init(MesosSchedulerDriverImpl* self,
                                  PyObject* args,
                                  PyObject* kwds)
{
  // Note: We use an integer for 'implicitAcknoweldgements' because
  // it is the recommended way to pass booleans through CPython.
  PyObject* schedulerObj = NULL;
  PyObject* frameworkObj = NULL;
  const char* master;
  int implicitAcknowledgements; // XXX Should be set to 1 by default!
  PyObject* credentialObj = NULL;

  if (!PyArg_ParseTuple(
      args,
      "OOs|iO",
      &schedulerObj,
      &frameworkObj,
      &master,
      &implicitAcknowledgements,
      &credentialObj)) {
    return -1;
  }
{code}

The default should be to preserve backwards compatibility, by enabling implicit acknowledgments.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)