You are viewing a plain text version of this content. The canonical link for it is here.
Posted to user@fineract.apache.org by Simon Matthews <si...@dreamstartlabs.com> on 2017/10/15 22:43:20 UTC

Building async

In the current version of the initial-setup.sh script, async is built
before api, but async appears to require libraries that are created in the
api build.

Hence initial-setup.sh fails if the user has an empty local repository.

Simon

Re: Building async

Posted by Myrle Krantz <my...@apache.org>.
Simon,

I've merged the changes.

Thank yo,
Myrle

On Tue, Oct 17, 2017 at 6:35 AM, Simon Matthews
<si...@dreamstartlabs.com> wrote:
> I created a second pull request, since the original one did not shot the
> transcript properly on the terminal (there was a problem with my use of
> 'tail'). The failure summary still has a problem with newlines, but it is
> generally more informative.
>
> Simon
>
> On Mon, Oct 16, 2017 at 8:46 PM, Simon Matthews <si...@dreamstartlabs.com>
> wrote:
>>
>> II think that I have created a PR. Please let me know if you can see it.
>>
>> I forgot to change the order of the builds to fix the issue with api and
>> identity not being in the local repository. This change request addresses
>> the logging of failures.
>>
>> Simon
>>
>> On Sun, Oct 15, 2017 at 11:41 PM, Markus Geiss <ma...@kuelap.io>
>> wrote:
>>>
>>> Thanks for finding that.
>>>
>>> Can you please implement your suggested enhancements and send a PR?
>>>
>>> Cheers
>>>
>>> Markus
>>>
>>> .::Yagni likes a DRY KISS::.
>>>
>>> On Mon, Oct 16, 2017 at 1:07 AM Simon Matthews <si...@dreamstartlabs.com>
>>> wrote:
>>>>
>>>> One more comment: it would be nice if the script exited at the first
>>>> error, instead of continuing, and potentially hiding an early build failure.
>>>>
>>>> Or, it could save the text from the build failure and present it to the
>>>> user after finishing.
>>>>
>>>> Simon
>>>>
>>>> On Sun, Oct 15, 2017 at 3:45 PM, Simon Matthews
>>>> <si...@dreamstartlabs.com> wrote:
>>>>>
>>>>> Getting a bit further, it looks like there are other dependency issues:
>>>>>
>>>>> ...
>>>>> Download
>>>>> https://jcenter.bintray.com/org/eclipse/jetty/jetty-server/9.3.11.v20160721/jetty-server-9.3.11.v20160721.jar
>>>>> [composite-build] Configuring build:
>>>>> /home/simon/FineractCN/permitted-feign-client/component-test
>>>>> :api FAILED
>>>>>
>>>>> FAILURE: Build failed with an exception.
>>>>>
>>>>> * What went wrong:
>>>>> Could not resolve all dependencies for configuration
>>>>> ':api:detachedConfiguration5'.
>>>>> > Could not find io.mifos.identity:api:0.1.0-BUILD-SNAPSHOT.
>>>>>   Searched in the following locations:
>>>>> ...
>>>>>
>>>>> Simon
>>>>>
>>>>>
>>>>> On Sun, Oct 15, 2017 at 3:43 PM, Simon Matthews
>>>>> <si...@dreamstartlabs.com> wrote:
>>>>>>
>>>>>> In the current version of the initial-setup.sh script, async is built
>>>>>> before api, but async appears to require libraries that are created in the
>>>>>> api build.
>>>>>>
>>>>>> Hence initial-setup.sh fails if the user has an empty local
>>>>>> repository.
>>>>>>
>>>>>> Simon
>>>>>
>>>>>
>>>>
>>
>

Re: Building async

Posted by Simon Matthews <si...@dreamstartlabs.com>.
I created a second pull request, since the original one did not shot the
transcript properly on the terminal (there was a problem with my use of
'tail'). The failure summary still has a problem with newlines, but it is
generally more informative.

Simon

On Mon, Oct 16, 2017 at 8:46 PM, Simon Matthews <si...@dreamstartlabs.com>
wrote:

> II think that I have created a PR. Please let me know if you can see it.
>
> I forgot to change the order of the builds to fix the issue with api and
> identity not being in the local repository. This change request addresses
> the logging of failures.
>
> Simon
>
> On Sun, Oct 15, 2017 at 11:41 PM, Markus Geiss <ma...@kuelap.io>
> wrote:
>
>> Thanks for finding that.
>>
>> Can you please implement your suggested enhancements and send a PR?
>>
>> Cheers
>>
>> Markus
>>
>> .::Yagni likes a DRY KISS::.
>>
>> On Mon, Oct 16, 2017 at 1:07 AM Simon Matthews <si...@dreamstartlabs.com>
>> wrote:
>>
>>> One more comment: it would be nice if the script exited at the first
>>> error, instead of continuing, and potentially hiding an early build
>>> failure.
>>>
>>> Or, it could save the text from the build failure and present it to the
>>> user after finishing.
>>>
>>> Simon
>>>
>>> On Sun, Oct 15, 2017 at 3:45 PM, Simon Matthews <
>>> simon@dreamstartlabs.com> wrote:
>>>
>>>> Getting a bit further, it looks like there are other dependency issues:
>>>>
>>>> ...
>>>> Download https://jcenter.bintray.com/org/eclipse/jetty/jetty-server/
>>>> 9.3.11.v20160721/jetty-server-9.3.11.v20160721.jar
>>>> [composite-build] Configuring build: /home/simon/FineractCN/permitt
>>>> ed-feign-client/component-test
>>>> :api FAILED
>>>>
>>>> FAILURE: Build failed with an exception.
>>>>
>>>> * What went wrong:
>>>> Could not resolve all dependencies for configuration
>>>> ':api:detachedConfiguration5'.
>>>> > Could not find io.mifos.identity:api:0.1.0-BUILD-SNAPSHOT.
>>>>   Searched in the following locations:
>>>> ...
>>>>
>>>> Simon
>>>>
>>>>
>>>> On Sun, Oct 15, 2017 at 3:43 PM, Simon Matthews <
>>>> simon@dreamstartlabs.com> wrote:
>>>>
>>>>> In the current version of the initial-setup.sh script, async is built
>>>>> before api, but async appears to require libraries that are created in the
>>>>> api build.
>>>>>
>>>>> Hence initial-setup.sh fails if the user has an empty local
>>>>> repository.
>>>>>
>>>>> Simon
>>>>>
>>>>
>>>>
>>>
>

Re: Building async

Posted by Simon Matthews <si...@dreamstartlabs.com>.
II think that I have created a PR. Please let me know if you can see it.

I forgot to change the order of the builds to fix the issue with api and
identity not being in the local repository. This change request addresses
the logging of failures.

Simon

On Sun, Oct 15, 2017 at 11:41 PM, Markus Geiss <ma...@kuelap.io>
wrote:

> Thanks for finding that.
>
> Can you please implement your suggested enhancements and send a PR?
>
> Cheers
>
> Markus
>
> .::Yagni likes a DRY KISS::.
>
> On Mon, Oct 16, 2017 at 1:07 AM Simon Matthews <si...@dreamstartlabs.com>
> wrote:
>
>> One more comment: it would be nice if the script exited at the first
>> error, instead of continuing, and potentially hiding an early build
>> failure.
>>
>> Or, it could save the text from the build failure and present it to the
>> user after finishing.
>>
>> Simon
>>
>> On Sun, Oct 15, 2017 at 3:45 PM, Simon Matthews <simon@dreamstartlabs.com
>> > wrote:
>>
>>> Getting a bit further, it looks like there are other dependency issues:
>>>
>>> ...
>>> Download https://jcenter.bintray.com/org/eclipse/jetty/jetty-
>>> server/9.3.11.v20160721/jetty-server-9.3.11.v20160721.jar
>>> [composite-build] Configuring build: /home/simon/FineractCN/
>>> permitted-feign-client/component-test
>>> :api FAILED
>>>
>>> FAILURE: Build failed with an exception.
>>>
>>> * What went wrong:
>>> Could not resolve all dependencies for configuration
>>> ':api:detachedConfiguration5'.
>>> > Could not find io.mifos.identity:api:0.1.0-BUILD-SNAPSHOT.
>>>   Searched in the following locations:
>>> ...
>>>
>>> Simon
>>>
>>>
>>> On Sun, Oct 15, 2017 at 3:43 PM, Simon Matthews <
>>> simon@dreamstartlabs.com> wrote:
>>>
>>>> In the current version of the initial-setup.sh script, async is built
>>>> before api, but async appears to require libraries that are created in the
>>>> api build.
>>>>
>>>> Hence initial-setup.sh fails if the user has an empty local repository.
>>>>
>>>> Simon
>>>>
>>>
>>>
>>

Re: Building async

Posted by Markus Geiss <ma...@kuelap.io>.
Thanks for finding that.

Can you please implement your suggested enhancements and send a PR?

Cheers

Markus

.::Yagni likes a DRY KISS::.

On Mon, Oct 16, 2017 at 1:07 AM Simon Matthews <si...@dreamstartlabs.com>
wrote:

> One more comment: it would be nice if the script exited at the first
> error, instead of continuing, and potentially hiding an early build
> failure.
>
> Or, it could save the text from the build failure and present it to the
> user after finishing.
>
> Simon
>
> On Sun, Oct 15, 2017 at 3:45 PM, Simon Matthews <si...@dreamstartlabs.com>
> wrote:
>
>> Getting a bit further, it looks like there are other dependency issues:
>>
>> ...
>> Download
>> https://jcenter.bintray.com/org/eclipse/jetty/jetty-server/9.3.11.v20160721/jetty-server-9.3.11.v20160721.jar
>> [composite-build] Configuring build:
>> /home/simon/FineractCN/permitted-feign-client/component-test
>> :api FAILED
>>
>> FAILURE: Build failed with an exception.
>>
>> * What went wrong:
>> Could not resolve all dependencies for configuration
>> ':api:detachedConfiguration5'.
>> > Could not find io.mifos.identity:api:0.1.0-BUILD-SNAPSHOT.
>>   Searched in the following locations:
>> ...
>>
>> Simon
>>
>>
>> On Sun, Oct 15, 2017 at 3:43 PM, Simon Matthews <simon@dreamstartlabs.com
>> > wrote:
>>
>>> In the current version of the initial-setup.sh script, async is built
>>> before api, but async appears to require libraries that are created in the
>>> api build.
>>>
>>> Hence initial-setup.sh fails if the user has an empty local repository.
>>>
>>> Simon
>>>
>>
>>
>

Re: Building async

Posted by Simon Matthews <si...@dreamstartlabs.com>.
One more comment: it would be nice if the script exited at the first error,
instead of continuing, and potentially hiding an early build failure.

Or, it could save the text from the build failure and present it to the
user after finishing.

Simon

On Sun, Oct 15, 2017 at 3:45 PM, Simon Matthews <si...@dreamstartlabs.com>
wrote:

> Getting a bit further, it looks like there are other dependency issues:
>
> ...
> Download https://jcenter.bintray.com/org/eclipse/jetty/jetty-
> server/9.3.11.v20160721/jetty-server-9.3.11.v20160721.jar
> [composite-build] Configuring build: /home/simon/FineractCN/
> permitted-feign-client/component-test
> :api FAILED
>
> FAILURE: Build failed with an exception.
>
> * What went wrong:
> Could not resolve all dependencies for configuration
> ':api:detachedConfiguration5'.
> > Could not find io.mifos.identity:api:0.1.0-BUILD-SNAPSHOT.
>   Searched in the following locations:
> ...
>
> Simon
>
>
> On Sun, Oct 15, 2017 at 3:43 PM, Simon Matthews <si...@dreamstartlabs.com>
> wrote:
>
>> In the current version of the initial-setup.sh script, async is built
>> before api, but async appears to require libraries that are created in the
>> api build.
>>
>> Hence initial-setup.sh fails if the user has an empty local repository.
>>
>> Simon
>>
>
>

Re: Building async

Posted by Simon Matthews <si...@dreamstartlabs.com>.
Getting a bit further, it looks like there are other dependency issues:

...
Download
https://jcenter.bintray.com/org/eclipse/jetty/jetty-server/9.3.11.v20160721/jetty-server-9.3.11.v20160721.jar
[composite-build] Configuring build:
/home/simon/FineractCN/permitted-feign-client/component-test
:api FAILED

FAILURE: Build failed with an exception.

* What went wrong:
Could not resolve all dependencies for configuration
':api:detachedConfiguration5'.
> Could not find io.mifos.identity:api:0.1.0-BUILD-SNAPSHOT.
  Searched in the following locations:
...

Simon


On Sun, Oct 15, 2017 at 3:43 PM, Simon Matthews <si...@dreamstartlabs.com>
wrote:

> In the current version of the initial-setup.sh script, async is built
> before api, but async appears to require libraries that are created in the
> api build.
>
> Hence initial-setup.sh fails if the user has an empty local repository.
>
> Simon
>