You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@httpd.apache.org by Rüdiger Plüm <ru...@vodafone.com> on 2011/12/28 16:39:59 UTC
Fwd: svn commit: r1225199 - in /httpd/httpd/trunk: docs/log-message-tags/next-number
server/core.c
-------- Original-Nachricht --------
Betreff: svn commit: r1225199 - in /httpd/httpd/trunk: docs/log-message-tags/next-number server/core.c
Datum: Wed, 28 Dec 2011 14:54:50 GMT
Von: sf@apache.org
Author: sf
Date: Wed Dec 28 14:54:49 2011
New Revision: 1225199
URL: http://svn.apache.org/viewvc?rev=1225199&view=rev
Log:
Check during configtest that the directories for error logs exist
Testing under Windows is welcome
PR: 29941
Modified:
httpd/httpd/trunk/docs/log-message-tags/next-number
httpd/httpd/trunk/server/core.c
Modified: httpd/httpd/trunk/server/core.c
URL: http://svn.apache.org/viewvc/httpd/httpd/trunk/server/core.c?rev=1225199&r1=1225198&r2=1225199&view=diff
==============================================================================
--- httpd/httpd/trunk/server/core.c (original)
+++ httpd/httpd/trunk/server/core.c Wed Dec 28 14:54:49 2011
@@ -4342,6 +4342,44 @@ AP_DECLARE(int) ap_sys_privileges_handle
return sys_privileges;
}
+static int check_errorlog_dir(apr_pool_t *p, server_rec *s)
+{
+ if (s->error_fname[0] == '|'&& strcmp(s->error_fname, "syslog") == 0)
Doesn't this need to be || instead of&&?
Regards
Rüdiger
Re: Fwd: svn commit: r1225199 - in /httpd/httpd/trunk: docs/log-message-tags/next-number server/core.c
Posted by Stefan Fritsch <sf...@sfritsch.de>.
On Wednesday 28 December 2011, Rüdiger Plüm wrote:
> Author: sf
> Date: Wed Dec 28 14:54:49 2011
> New Revision: 1225199
>
> URL: http://svn.apache.org/viewvc?rev=1225199&view=rev
> Log:
> Check during configtest that the directories for error logs exist
>
> Testing under Windows is welcome
>
> PR: 29941
>
> Modified:
> httpd/httpd/trunk/docs/log-message-tags/next-number
> httpd/httpd/trunk/server/core.c
>
>
> Modified: httpd/httpd/trunk/server/core.c
> URL:
> http://svn.apache.org/viewvc/httpd/httpd/trunk/server/core.c?rev=1
> 225199&r1=1225198&r2=1225199&view=diff
> ==================================================================
> ============ --- httpd/httpd/trunk/server/core.c (original)
> +++ httpd/httpd/trunk/server/core.c Wed Dec 28 14:54:49 2011
> @@ -4342,6 +4342,44 @@ AP_DECLARE(int) ap_sys_privileges_handle
> return sys_privileges;
> }
>
> +static int check_errorlog_dir(apr_pool_t *p, server_rec *s)
> +{
> + if (s->error_fname[0] == '|'&& strcmp(s->error_fname,
> "syslog") == 0)
>
>
> Doesn't this need to be || instead of&&?
>
yes, thanks. And error_fname can be NULL in vhosts. Fixed in r1225223.