[GitHub] [storm] agresch commented on a change in pull request #3169: STORM-3540 fix Pacemaker connection issues

[GitBox <gi...@apache.org>]

agresch commented on a change in pull request #3169: STORM-3540 fix Pacemaker connection issues
URL: https://github.com/apache/storm/pull/3169#discussion_r349349691
 
 

 ##########
 File path: storm-client/src/jvm/org/apache/storm/pacemaker/codec/ThriftNettyClientCodec.java
 ##########
 @@ -72,7 +72,7 @@ protected void initChannel(Channel ch) throws Exception {
                 throw new RuntimeException(e);
             }
         } else {
-            client.channelReady(ch);
+            // no work for AuthMethod.NONE
 
 Review comment:
   My personal preference is to leave it so we know AuthMethod.NONE was not skipped by accident.  

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services