You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@oodt.apache.org by "Ross Laidlaw (JIRA)" <ji...@apache.org> on 2012/04/27 22:28:49 UTC
[jira] [Created] (OODT-452) Move the default File Manager policy
files to 'core' subdirectory
Ross Laidlaw created OODT-452:
---------------------------------
Summary: Move the default File Manager policy files to 'core' subdirectory
Key: OODT-452
URL: https://issues.apache.org/jira/browse/OODT-452
Project: OODT
Issue Type: Sub-task
Components: file manager
Reporter: Ross Laidlaw
Fix For: 0.5
Move the current contents of http://svn.apache.org/repos/asf/oodt/trunk/filemgr/src/main/resources/examples, i.e. the default File Manager policy files 'elements.xml', 'product-types.xml' and 'product-type-element-map.xml' to a subdirectory named 'core', i.e.: http://svn.apache.org/repos/asf/oodt/trunk/filemgr/src/main/resources/examples/core.
(ensure assembly.xml, unit tests, etc still work after moving!)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (OODT-452) Move the default File Manager policy
files to 'core' subdirectory
Posted by "Ross Laidlaw (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OODT-452?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ross Laidlaw updated OODT-452:
------------------------------
Fix Version/s: (was: 0.5)
0.4
Assignee: Ross Laidlaw
> Move the default File Manager policy files to 'core' subdirectory
> -----------------------------------------------------------------
>
> Key: OODT-452
> URL: https://issues.apache.org/jira/browse/OODT-452
> Project: OODT
> Issue Type: Sub-task
> Components: file manager
> Reporter: Ross Laidlaw
> Assignee: Ross Laidlaw
> Labels: gsoc2012
> Fix For: 0.4
>
> Attachments: OODT-452.rlaidlaw.2012-05-19.patch.txt
>
>
> Move the current contents of http://svn.apache.org/repos/asf/oodt/trunk/filemgr/src/main/resources/examples, i.e. the default File Manager policy files 'elements.xml', 'product-types.xml' and 'product-type-element-map.xml' to a subdirectory named 'core', i.e.: http://svn.apache.org/repos/asf/oodt/trunk/filemgr/src/main/resources/examples/core.
> (ensure assembly.xml, unit tests, etc still work after moving!)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OODT-452) Move the default File Manager policy
files to 'core' subdirectory
Posted by "Ross Laidlaw (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OODT-452?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13279606#comment-13279606 ]
Ross Laidlaw commented on OODT-452:
-----------------------------------
Hi Chris!
Apologies! After reading your comment, I realised that I had not tested the build after moving the files. And indeed some unit tests for the filemgr component are failing with the build:
* org.apache.oodt.cas.filemgr.catalog.TestLuceneCatalog
* org.apache.oodt.cas.filemgr.ingest.TestLocalCache
* org.apache.oodt.cas.filemgr.ingest.TestStdIngester
* org.apache.oodt.cas.filemgr.ingest.TestRmiCache
* org.apache.oodt.cas.filemgr.tools.TestMetadataBasedProductMover
* org.apache.oodt.cas.filemgr.ingest.TestCachedIngester
So there's a bit more work to be done other than just moving the files over. I found that each test is failing because of the following code (same in each test class):
{code}
System.setProperty("org.apache.oodt.cas.filemgr.validation.dirs",
"file://" + new File("./src/main/resources/examples").getAbsolutePath());
{code}
And if I change the above code to the following, the tests all pass and the build succeeds:
{code}
System.setProperty("org.apache.oodt.cas.filemgr.validation.dirs",
"file://" + new File("./src/main/resources/examples/core").getAbsolutePath());
{code}
Would you be happy for me to commit the moves and also patch the tests? I'll upload the patch soon after posting this comment.
> Move the default File Manager policy files to 'core' subdirectory
> -----------------------------------------------------------------
>
> Key: OODT-452
> URL: https://issues.apache.org/jira/browse/OODT-452
> Project: OODT
> Issue Type: Sub-task
> Components: file manager
> Reporter: Ross Laidlaw
> Labels: gsoc2012
> Fix For: 0.5
>
>
> Move the current contents of http://svn.apache.org/repos/asf/oodt/trunk/filemgr/src/main/resources/examples, i.e. the default File Manager policy files 'elements.xml', 'product-types.xml' and 'product-type-element-map.xml' to a subdirectory named 'core', i.e.: http://svn.apache.org/repos/asf/oodt/trunk/filemgr/src/main/resources/examples/core.
> (ensure assembly.xml, unit tests, etc still work after moving!)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OODT-452) Move the default File Manager policy
files to 'core' subdirectory
Posted by "Ross Laidlaw (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OODT-452?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13279596#comment-13279596 ]
Ross Laidlaw commented on OODT-452:
-----------------------------------
When building OODT, the following code in assembly.xml (in _filemgr/src/main/assembly_) copies the contents of the _filemgr/src/main/resources/examples_ directory to the _filemgr/policy_ directory in the build target:
{code}
<fileSet>
<directory>${basedir}/src/main/resources/examples</directory>
<outputDirectory>policy</outputDirectory>
<includes/>
</fileSet>
{code}
It also copies subdirectories and their contents too. This means that the newly created _core_ and _geo_ subdirectories will be copied over along with any files they contain. I've checked the [documentation for the maven assembly plugin|http://maven.apache.org/plugins/maven-assembly-plugin/assembly.html] and this is by design rather than by accident:
_"When <include> subelements are present, they define a set of project coordinates to include. If none is present, then <includes> represents all valid values..."_
I've tested this by building the latest OODT trunk and confirming that the _core_ and _geo_ directories and contents were copied over to the target policy directory, as expected.
This means that in the future we could add more example configurations as subdirectories and these would automatically be picked up.
Therefore, to complete this task, all that's required is for a committer to perform svn moves for the three core files and commit the changes. As far as I can see, no further actions would be required (i.e. no modifications to any other files), because I have made these changes locally and none of the tests for the build were affected.
As a newly appointed OODT committer I'd be happy to move and commit the files if the OODT team are happy for me to go ahead.
Following the changes, to access the core files the filemgr.properties file can be updated reference the _policy/core_ subdirectory rather than the _policy_ directory, for example as follows:
{code}
org.apache.oodt.cas.filemgr.repositorymgr.dirs=file:///usr/local/oodt/cas-filemgr/policy/core
org.apache.oodt.cas.filemgr.validation.dirs=file:///usr/local/oodt/cas-filemgr/policy/core
{code}
> Move the default File Manager policy files to 'core' subdirectory
> -----------------------------------------------------------------
>
> Key: OODT-452
> URL: https://issues.apache.org/jira/browse/OODT-452
> Project: OODT
> Issue Type: Sub-task
> Components: file manager
> Reporter: Ross Laidlaw
> Labels: gsoc2012
> Fix For: 0.5
>
>
> Move the current contents of http://svn.apache.org/repos/asf/oodt/trunk/filemgr/src/main/resources/examples, i.e. the default File Manager policy files 'elements.xml', 'product-types.xml' and 'product-type-element-map.xml' to a subdirectory named 'core', i.e.: http://svn.apache.org/repos/asf/oodt/trunk/filemgr/src/main/resources/examples/core.
> (ensure assembly.xml, unit tests, etc still work after moving!)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Comment Edited] (OODT-452) Move the default File Manager
policy files to 'core' subdirectory
Posted by "Ross Laidlaw (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OODT-452?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13279596#comment-13279596 ]
Ross Laidlaw edited comment on OODT-452 at 5/19/12 7:26 PM:
------------------------------------------------------------
When building OODT, the following code in assembly.xml (in _filemgr/src/main/assembly_) copies the contents of the _filemgr/src/main/resources/examples_ directory to the _filemgr/policy_ directory in the build target:
{code}
<fileSet>
<directory>${basedir}/src/main/resources/examples</directory>
<outputDirectory>policy</outputDirectory>
<includes/>
</fileSet>
{code}
It also copies subdirectories and their contents too. This means that the newly created _core_ and _geo_ subdirectories will be copied over along with any files they contain. I've checked the [documentation for the maven assembly plugin|http://maven.apache.org/plugins/maven-assembly-plugin/assembly.html] and this is by design rather than by accident:
_"When <include> subelements are present, they define a set of project coordinates to include. If none is present, then <includes> represents all valid values..."_
I've tested this by building the latest OODT trunk and confirming that the _core_ and _geo_ directories and contents were copied over to the target policy directory, as expected.
This means that in the future we could add more example configurations as subdirectories and these would automatically be picked up.
Therefore, to complete this task, a committer would need to perform svn moves for the three core files and commit the changes. As a newly appointed OODT committer I'd be happy to move and commit the files if the OODT team are happy for me to go ahead.
Following the changes, to access the core files the filemgr.properties file can be updated reference the _policy/core_ subdirectory rather than the _policy_ directory, for example as follows:
{code}
org.apache.oodt.cas.filemgr.repositorymgr.dirs=file:///usr/local/oodt/cas-filemgr/policy/core
org.apache.oodt.cas.filemgr.validation.dirs=file:///usr/local/oodt/cas-filemgr/policy/core
{code}
was (Author: rlaidlaw):
When building OODT, the following code in assembly.xml (in _filemgr/src/main/assembly_) copies the contents of the _filemgr/src/main/resources/examples_ directory to the _filemgr/policy_ directory in the build target:
{code}
<fileSet>
<directory>${basedir}/src/main/resources/examples</directory>
<outputDirectory>policy</outputDirectory>
<includes/>
</fileSet>
{code}
It also copies subdirectories and their contents too. This means that the newly created _core_ and _geo_ subdirectories will be copied over along with any files they contain. I've checked the [documentation for the maven assembly plugin|http://maven.apache.org/plugins/maven-assembly-plugin/assembly.html] and this is by design rather than by accident:
_"When <include> subelements are present, they define a set of project coordinates to include. If none is present, then <includes> represents all valid values..."_
I've tested this by building the latest OODT trunk and confirming that the _core_ and _geo_ directories and contents were copied over to the target policy directory, as expected.
This means that in the future we could add more example configurations as subdirectories and these would automatically be picked up.
Therefore, to complete this task, all that's required is for a committer to perform svn moves for the three core files and commit the changes. As far as I can see, no further actions would be required (i.e. no modifications to any other files), because when I made these changes locally none of the tests for the build were affected.
As a newly appointed OODT committer I'd be happy to move and commit the files if the OODT team are happy for me to go ahead.
Following the changes, to access the core files the filemgr.properties file can be updated reference the _policy/core_ subdirectory rather than the _policy_ directory, for example as follows:
{code}
org.apache.oodt.cas.filemgr.repositorymgr.dirs=file:///usr/local/oodt/cas-filemgr/policy/core
org.apache.oodt.cas.filemgr.validation.dirs=file:///usr/local/oodt/cas-filemgr/policy/core
{code}
> Move the default File Manager policy files to 'core' subdirectory
> -----------------------------------------------------------------
>
> Key: OODT-452
> URL: https://issues.apache.org/jira/browse/OODT-452
> Project: OODT
> Issue Type: Sub-task
> Components: file manager
> Reporter: Ross Laidlaw
> Labels: gsoc2012
> Fix For: 0.5
>
>
> Move the current contents of http://svn.apache.org/repos/asf/oodt/trunk/filemgr/src/main/resources/examples, i.e. the default File Manager policy files 'elements.xml', 'product-types.xml' and 'product-type-element-map.xml' to a subdirectory named 'core', i.e.: http://svn.apache.org/repos/asf/oodt/trunk/filemgr/src/main/resources/examples/core.
> (ensure assembly.xml, unit tests, etc still work after moving!)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OODT-452) Move the default File Manager policy
files to 'core' subdirectory
Posted by "Chris A. Mattmann (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OODT-452?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13279599#comment-13279599 ]
Chris A. Mattmann commented on OODT-452:
----------------------------------------
Hey Ross, thanks for investigating this. Can you confirm that the unit tests still pass in this scenario? If so, my +1 to commit it.
> Move the default File Manager policy files to 'core' subdirectory
> -----------------------------------------------------------------
>
> Key: OODT-452
> URL: https://issues.apache.org/jira/browse/OODT-452
> Project: OODT
> Issue Type: Sub-task
> Components: file manager
> Reporter: Ross Laidlaw
> Labels: gsoc2012
> Fix For: 0.5
>
>
> Move the current contents of http://svn.apache.org/repos/asf/oodt/trunk/filemgr/src/main/resources/examples, i.e. the default File Manager policy files 'elements.xml', 'product-types.xml' and 'product-type-element-map.xml' to a subdirectory named 'core', i.e.: http://svn.apache.org/repos/asf/oodt/trunk/filemgr/src/main/resources/examples/core.
> (ensure assembly.xml, unit tests, etc still work after moving!)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OODT-452) Move the default File Manager policy
files to 'core' subdirectory
Posted by "Ross Laidlaw (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OODT-452?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13283342#comment-13283342 ]
Ross Laidlaw commented on OODT-452:
-----------------------------------
I have committed the patch in r1342585. Next, I will update the user guides on the wiki to make sure that they refer to the filemgr/policy/core subdirectory.
> Move the default File Manager policy files to 'core' subdirectory
> -----------------------------------------------------------------
>
> Key: OODT-452
> URL: https://issues.apache.org/jira/browse/OODT-452
> Project: OODT
> Issue Type: Sub-task
> Components: file manager
> Reporter: Ross Laidlaw
> Labels: gsoc2012
> Fix For: 0.5
>
> Attachments: OODT-452.rlaidlaw.2012-05-19.patch.txt
>
>
> Move the current contents of http://svn.apache.org/repos/asf/oodt/trunk/filemgr/src/main/resources/examples, i.e. the default File Manager policy files 'elements.xml', 'product-types.xml' and 'product-type-element-map.xml' to a subdirectory named 'core', i.e.: http://svn.apache.org/repos/asf/oodt/trunk/filemgr/src/main/resources/examples/core.
> (ensure assembly.xml, unit tests, etc still work after moving!)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Comment Edited] (OODT-452) Move the default File Manager
policy files to 'core' subdirectory
Posted by "Ross Laidlaw (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OODT-452?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13279606#comment-13279606 ]
Ross Laidlaw edited comment on OODT-452 at 5/19/12 9:09 PM:
------------------------------------------------------------
Hi Chris!
Apologies! After reading your comment, I realised that I had made a mistake when testing the build after moving the files. And indeed some unit tests for the filemgr component are failing with the build:
* org.apache.oodt.cas.filemgr.catalog.TestLuceneCatalog
* org.apache.oodt.cas.filemgr.ingest.TestLocalCache
* org.apache.oodt.cas.filemgr.ingest.TestStdIngester
* org.apache.oodt.cas.filemgr.ingest.TestRmiCache
* org.apache.oodt.cas.filemgr.tools.TestMetadataBasedProductMover
* org.apache.oodt.cas.filemgr.ingest.TestCachedIngester
So there's a bit more work to be done other than just moving the files over. I found that each test is failing because of the following code (same in each test class):
{code}
System.setProperty("org.apache.oodt.cas.filemgr.validation.dirs",
"file://" + new File("./src/main/resources/examples").getAbsolutePath());
{code}
And if I change the above code to the following, the tests all pass and the build succeeds:
{code}
System.setProperty("org.apache.oodt.cas.filemgr.validation.dirs",
"file://" + new File("./src/main/resources/examples/core").getAbsolutePath());
{code}
Would you be happy for me to commit the moves and also patch the tests? I'll upload the patch soon after posting this comment.
was (Author: rlaidlaw):
Hi Chris!
Apologies! After reading your comment, I realised that I had not tested the build after moving the files. And indeed some unit tests for the filemgr component are failing with the build:
* org.apache.oodt.cas.filemgr.catalog.TestLuceneCatalog
* org.apache.oodt.cas.filemgr.ingest.TestLocalCache
* org.apache.oodt.cas.filemgr.ingest.TestStdIngester
* org.apache.oodt.cas.filemgr.ingest.TestRmiCache
* org.apache.oodt.cas.filemgr.tools.TestMetadataBasedProductMover
* org.apache.oodt.cas.filemgr.ingest.TestCachedIngester
So there's a bit more work to be done other than just moving the files over. I found that each test is failing because of the following code (same in each test class):
{code}
System.setProperty("org.apache.oodt.cas.filemgr.validation.dirs",
"file://" + new File("./src/main/resources/examples").getAbsolutePath());
{code}
And if I change the above code to the following, the tests all pass and the build succeeds:
{code}
System.setProperty("org.apache.oodt.cas.filemgr.validation.dirs",
"file://" + new File("./src/main/resources/examples/core").getAbsolutePath());
{code}
Would you be happy for me to commit the moves and also patch the tests? I'll upload the patch soon after posting this comment.
> Move the default File Manager policy files to 'core' subdirectory
> -----------------------------------------------------------------
>
> Key: OODT-452
> URL: https://issues.apache.org/jira/browse/OODT-452
> Project: OODT
> Issue Type: Sub-task
> Components: file manager
> Reporter: Ross Laidlaw
> Labels: gsoc2012
> Fix For: 0.5
>
> Attachments: OODT-452.rlaidlaw.2012-05-19.patch.txt
>
>
> Move the current contents of http://svn.apache.org/repos/asf/oodt/trunk/filemgr/src/main/resources/examples, i.e. the default File Manager policy files 'elements.xml', 'product-types.xml' and 'product-type-element-map.xml' to a subdirectory named 'core', i.e.: http://svn.apache.org/repos/asf/oodt/trunk/filemgr/src/main/resources/examples/core.
> (ensure assembly.xml, unit tests, etc still work after moving!)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (OODT-452) Move the default File Manager policy
files to 'core' subdirectory
Posted by "Ross Laidlaw (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OODT-452?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ross Laidlaw updated OODT-452:
------------------------------
Attachment: OODT-452.rlaidlaw.2012-05-19.patch.txt
Here's the patch to update the six filemgr tests to use the 'src/main/resources/examples/core' subdirectory.
> Move the default File Manager policy files to 'core' subdirectory
> -----------------------------------------------------------------
>
> Key: OODT-452
> URL: https://issues.apache.org/jira/browse/OODT-452
> Project: OODT
> Issue Type: Sub-task
> Components: file manager
> Reporter: Ross Laidlaw
> Labels: gsoc2012
> Fix For: 0.5
>
> Attachments: OODT-452.rlaidlaw.2012-05-19.patch.txt
>
>
> Move the current contents of http://svn.apache.org/repos/asf/oodt/trunk/filemgr/src/main/resources/examples, i.e. the default File Manager policy files 'elements.xml', 'product-types.xml' and 'product-type-element-map.xml' to a subdirectory named 'core', i.e.: http://svn.apache.org/repos/asf/oodt/trunk/filemgr/src/main/resources/examples/core.
> (ensure assembly.xml, unit tests, etc still work after moving!)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (OODT-452) Move the default File Manager policy
files to 'core' subdirectory
Posted by "Ross Laidlaw (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OODT-452?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ross Laidlaw resolved OODT-452.
-------------------------------
Resolution: Fixed
I have made some minor updates to the following user guides to account for the new location of the core policy files in File Manager:
[OODT Filemgr User Guide|https://cwiki.apache.org/confluence/display/OODT/OODT+Filemgr+User+Guide]
[Everything you want to know about File Manager Policy|https://cwiki.apache.org/confluence/display/OODT/Everything+you+want+to+know+about+File+Manager+Policy]
[OODT File Manager to SIS Connection Demo|https://cwiki.apache.org/confluence/display/SIS/OODT+File+Manager+to+SIS+Connection+Demo]
Together with the patch and file moves, this resolves 452.
> Move the default File Manager policy files to 'core' subdirectory
> -----------------------------------------------------------------
>
> Key: OODT-452
> URL: https://issues.apache.org/jira/browse/OODT-452
> Project: OODT
> Issue Type: Sub-task
> Components: file manager
> Reporter: Ross Laidlaw
> Labels: gsoc2012
> Fix For: 0.5
>
> Attachments: OODT-452.rlaidlaw.2012-05-19.patch.txt
>
>
> Move the current contents of http://svn.apache.org/repos/asf/oodt/trunk/filemgr/src/main/resources/examples, i.e. the default File Manager policy files 'elements.xml', 'product-types.xml' and 'product-type-element-map.xml' to a subdirectory named 'core', i.e.: http://svn.apache.org/repos/asf/oodt/trunk/filemgr/src/main/resources/examples/core.
> (ensure assembly.xml, unit tests, etc still work after moving!)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OODT-452) Move the default File Manager policy
files to 'core' subdirectory
Posted by "Chris A. Mattmann (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OODT-452?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13280213#comment-13280213 ]
Chris A. Mattmann commented on OODT-452:
----------------------------------------
+1 from me, go for it Ross!
> Move the default File Manager policy files to 'core' subdirectory
> -----------------------------------------------------------------
>
> Key: OODT-452
> URL: https://issues.apache.org/jira/browse/OODT-452
> Project: OODT
> Issue Type: Sub-task
> Components: file manager
> Reporter: Ross Laidlaw
> Labels: gsoc2012
> Fix For: 0.5
>
> Attachments: OODT-452.rlaidlaw.2012-05-19.patch.txt
>
>
> Move the current contents of http://svn.apache.org/repos/asf/oodt/trunk/filemgr/src/main/resources/examples, i.e. the default File Manager policy files 'elements.xml', 'product-types.xml' and 'product-type-element-map.xml' to a subdirectory named 'core', i.e.: http://svn.apache.org/repos/asf/oodt/trunk/filemgr/src/main/resources/examples/core.
> (ensure assembly.xml, unit tests, etc still work after moving!)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Comment Edited] (OODT-452) Move the default File Manager
policy files to 'core' subdirectory
Posted by "Ross Laidlaw (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OODT-452?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13279596#comment-13279596 ]
Ross Laidlaw edited comment on OODT-452 at 5/19/12 6:36 PM:
------------------------------------------------------------
When building OODT, the following code in assembly.xml (in _filemgr/src/main/assembly_) copies the contents of the _filemgr/src/main/resources/examples_ directory to the _filemgr/policy_ directory in the build target:
{code}
<fileSet>
<directory>${basedir}/src/main/resources/examples</directory>
<outputDirectory>policy</outputDirectory>
<includes/>
</fileSet>
{code}
It also copies subdirectories and their contents too. This means that the newly created _core_ and _geo_ subdirectories will be copied over along with any files they contain. I've checked the [documentation for the maven assembly plugin|http://maven.apache.org/plugins/maven-assembly-plugin/assembly.html] and this is by design rather than by accident:
_"When <include> subelements are present, they define a set of project coordinates to include. If none is present, then <includes> represents all valid values..."_
I've tested this by building the latest OODT trunk and confirming that the _core_ and _geo_ directories and contents were copied over to the target policy directory, as expected.
This means that in the future we could add more example configurations as subdirectories and these would automatically be picked up.
Therefore, to complete this task, all that's required is for a committer to perform svn moves for the three core files and commit the changes. As far as I can see, no further actions would be required (i.e. no modifications to any other files), because when I made these changes locally none of the tests for the build were affected.
As a newly appointed OODT committer I'd be happy to move and commit the files if the OODT team are happy for me to go ahead.
Following the changes, to access the core files the filemgr.properties file can be updated reference the _policy/core_ subdirectory rather than the _policy_ directory, for example as follows:
{code}
org.apache.oodt.cas.filemgr.repositorymgr.dirs=file:///usr/local/oodt/cas-filemgr/policy/core
org.apache.oodt.cas.filemgr.validation.dirs=file:///usr/local/oodt/cas-filemgr/policy/core
{code}
was (Author: rlaidlaw):
When building OODT, the following code in assembly.xml (in _filemgr/src/main/assembly_) copies the contents of the _filemgr/src/main/resources/examples_ directory to the _filemgr/policy_ directory in the build target:
{code}
<fileSet>
<directory>${basedir}/src/main/resources/examples</directory>
<outputDirectory>policy</outputDirectory>
<includes/>
</fileSet>
{code}
It also copies subdirectories and their contents too. This means that the newly created _core_ and _geo_ subdirectories will be copied over along with any files they contain. I've checked the [documentation for the maven assembly plugin|http://maven.apache.org/plugins/maven-assembly-plugin/assembly.html] and this is by design rather than by accident:
_"When <include> subelements are present, they define a set of project coordinates to include. If none is present, then <includes> represents all valid values..."_
I've tested this by building the latest OODT trunk and confirming that the _core_ and _geo_ directories and contents were copied over to the target policy directory, as expected.
This means that in the future we could add more example configurations as subdirectories and these would automatically be picked up.
Therefore, to complete this task, all that's required is for a committer to perform svn moves for the three core files and commit the changes. As far as I can see, no further actions would be required (i.e. no modifications to any other files), because I have made these changes locally and none of the tests for the build were affected.
As a newly appointed OODT committer I'd be happy to move and commit the files if the OODT team are happy for me to go ahead.
Following the changes, to access the core files the filemgr.properties file can be updated reference the _policy/core_ subdirectory rather than the _policy_ directory, for example as follows:
{code}
org.apache.oodt.cas.filemgr.repositorymgr.dirs=file:///usr/local/oodt/cas-filemgr/policy/core
org.apache.oodt.cas.filemgr.validation.dirs=file:///usr/local/oodt/cas-filemgr/policy/core
{code}
> Move the default File Manager policy files to 'core' subdirectory
> -----------------------------------------------------------------
>
> Key: OODT-452
> URL: https://issues.apache.org/jira/browse/OODT-452
> Project: OODT
> Issue Type: Sub-task
> Components: file manager
> Reporter: Ross Laidlaw
> Labels: gsoc2012
> Fix For: 0.5
>
>
> Move the current contents of http://svn.apache.org/repos/asf/oodt/trunk/filemgr/src/main/resources/examples, i.e. the default File Manager policy files 'elements.xml', 'product-types.xml' and 'product-type-element-map.xml' to a subdirectory named 'core', i.e.: http://svn.apache.org/repos/asf/oodt/trunk/filemgr/src/main/resources/examples/core.
> (ensure assembly.xml, unit tests, etc still work after moving!)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira