You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "wgtmac (via GitHub)" <gi...@apache.org> on 2026/01/16 03:52:52 UTC
[PR] GH-48877: [C++][Parquet] Fix writer not to throw for bloom filter on disabled bool column [arrow]
wgtmac opened a new pull request, #48878:
URL: https://github.com/apache/arrow/pull/48878
### Rationale for this change
Now that https://github.com/apache/arrow/pull/37400 is merged. After a quick integration, I found that the Parquet writer throws if bloom filter is enabled and there is at least one boolean column (even when it is not enabled).
### What changes are included in this PR?
Move the bloom filter type check after bloom filter enablement check.
### Are these changes tested?
Yes, added test to verify this does not throw.
### Are there any user-facing changes?
No.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-48877: [C++][Parquet] Fix writer not to throw for bloom filter on disabled bool column [arrow]
Posted by "wgtmac (via GitHub)" <gi...@apache.org>.
wgtmac merged PR #48878:
URL: https://github.com/apache/arrow/pull/48878
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-48877: [C++][Parquet] Fix writer not to throw for bloom filter on disabled bool column [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #48878:
URL: https://github.com/apache/arrow/pull/48878#issuecomment-3758003949
:warning: GitHub issue #48877 **has been automatically assigned in GitHub** to PR creator.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-48877: [C++][Parquet] Fix writer not to throw for bloom filter on disabled bool column [arrow]
Posted by "conbench-apache-arrow[bot] (via GitHub)" <gi...@apache.org>.
conbench-apache-arrow[bot] commented on PR #48878:
URL: https://github.com/apache/arrow/pull/48878#issuecomment-3769993380
After merging your PR, Conbench analyzed the 3 benchmarking runs that have been run so far on merge-commit 8b648bef4b625cd6aacce8e0829d545cc3fee8ac.
There were no benchmark performance regressions. 🎉
The [full Conbench report](https://github.com/apache/arrow/runs/60825168027) has more details. It also includes information about 1 possible false positive for unstable benchmarks that are known to sometimes produce them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org