You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by "shmakovalexey (via GitHub)" <gi...@apache.org> on 2023/03/02 21:22:19 UTC
[GitHub] [camel] shmakovalexey opened a new pull request, #9461: [Camel 19106] repair check style for 3.x
shmakovalexey opened a new pull request, #9461:
URL: https://github.com/apache/camel/pull/9461
check style was broken, I repair it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] essobedo commented on pull request #9461: [Camel 19106] repair check style for 3.x
Posted by "essobedo (via GitHub)" <gi...@apache.org>.
essobedo commented on PR #9461:
URL: https://github.com/apache/camel/pull/9461#issuecomment-1453289868
I've checked on the branches `3.20.x`, there is no checkstyle issue and this branch uses the exact same version of checkstyle as the branch `3.x`. Then, I checked on `3.x` with 0f9e74de42bdf8022aabaec9593ec935979847a4 as head which means before merging these changes, I don't get any checkstyle issue either.
The only checkstyle issue has been fixed 2 days ago by this https://github.com/apache/camel/commit/18383df5bbeca179b432257ed35d7aeef1bea848 which is more or less a cherry-pick of https://github.com/apache/camel/commit/44b02d6af3b93a05b4adbe9a6e377651738a0055 for main and https://github.com/apache/camel/commit/41cf79533d6c6778f4f3c2ed8d6afe29816ec97d for 3.20.x.
I mentioned it in the other PR https://github.com/apache/camel/pull/9454#issuecomment-1450382321
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] essobedo commented on pull request #9461: [Camel 19106] repair check style for 3.x
Posted by "essobedo (via GitHub)" <gi...@apache.org>.
essobedo commented on PR #9461:
URL: https://github.com/apache/camel/pull/9461#issuecomment-1453177255
Please don't merge it, I need to check something first
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] github-actions[bot] commented on pull request #9461: [Camel 19106] repair check style for 3.x
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #9461:
URL: https://github.com/apache/camel/pull/9461#issuecomment-1452699431
:no_entry_sign: There are (likely) no components to be tested in this PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] shmakovalexey commented on pull request #9461: [Camel 19106] repair check style for 3.x
Posted by "shmakovalexey (via GitHub)" <gi...@apache.org>.
shmakovalexey commented on PR #9461:
URL: https://github.com/apache/camel/pull/9461#issuecomment-1454096370
Sorry, I found all the broken rules in the supress file
```
<suppressionsLocation>camel-checkstyle-suppressions.xml</suppressionsLocation>
```
Probably the problem is that for some reason it is not processed on my PC. I will look into this more carefully.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] shmakovalexey commented on pull request #9461: [Camel 19106] repair check style for 3.x
Posted by "shmakovalexey (via GitHub)" <gi...@apache.org>.
shmakovalexey commented on PR #9461:
URL: https://github.com/apache/camel/pull/9461#issuecomment-1454164020
I found the cause of the style check problem on Windows and created a issue (CAMEL-19114), this PR is really useless and wrong. Sorry again for the previous emotional comment
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] essobedo commented on pull request #9461: [Camel 19106] repair check style for 3.x
Posted by "essobedo (via GitHub)" <gi...@apache.org>.
essobedo commented on PR #9461:
URL: https://github.com/apache/camel/pull/9461#issuecomment-1453182248
We were only supposed to cherry-pick some missing commits, here with those changes we have a different "fix" that sounds more like an XY problem
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] oscerd commented on pull request #9461: [Camel 19106] repair check style for 3.x
Posted by "oscerd (via GitHub)" <gi...@apache.org>.
oscerd commented on PR #9461:
URL: https://github.com/apache/camel/pull/9461#issuecomment-1453308024
All of this rigidity doesn't make any sense to me. If you stop/veto harmless contributions like this one you won't improve the community and people will run away. This was completely harmless and being pedantic on this it's just a waste of time and energy.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] oscerd commented on pull request #9461: [Camel 19106] repair check style for 3.x
Posted by "oscerd (via GitHub)" <gi...@apache.org>.
oscerd commented on PR #9461:
URL: https://github.com/apache/camel/pull/9461#issuecomment-1453183111
This doesn't make any sense: on main the checkstyle is not failing because the codebase is different and probably the checkstyle plugin has a different version. 3.x shouldn't be freeze as is, it's still in development
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] essobedo commented on pull request #9461: [Camel 19106] repair check style for 3.x
Posted by "essobedo (via GitHub)" <gi...@apache.org>.
essobedo commented on PR #9461:
URL: https://github.com/apache/camel/pull/9461#issuecomment-1453180541
If there is a problem somewhere it needs to be solved everywhere the same way
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] oscerd merged pull request #9461: [Camel 19106] repair check style for 3.x
Posted by "oscerd (via GitHub)" <gi...@apache.org>.
oscerd merged PR #9461:
URL: https://github.com/apache/camel/pull/9461
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] essobedo commented on pull request #9461: [Camel 19106] repair check style for 3.x
Posted by "essobedo (via GitHub)" <gi...@apache.org>.
essobedo commented on PR #9461:
URL: https://github.com/apache/camel/pull/9461#issuecomment-1453179511
This PR sounds incorrect, why would we need those changes on this particular branch
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] oscerd commented on pull request #9461: [Camel 19106] repair check style for 3.x
Posted by "oscerd (via GitHub)" <gi...@apache.org>.
oscerd commented on PR #9461:
URL: https://github.com/apache/camel/pull/9461#issuecomment-1453180312
Because checkstyle is failing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] oscerd commented on pull request #9461: [Camel 19106] repair check style for 3.x
Posted by "oscerd (via GitHub)" <gi...@apache.org>.
oscerd commented on PR #9461:
URL: https://github.com/apache/camel/pull/9461#issuecomment-1453308678
All done btw, reverted and happy Friday!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] shmakovalexey commented on pull request #9461: [Camel 19106] repair check style for 3.x
Posted by "shmakovalexey (via GitHub)" <gi...@apache.org>.
shmakovalexey commented on PR #9461:
URL: https://github.com/apache/camel/pull/9461#issuecomment-1454079602
@essobedo @oscerd I spent 2 days of personal time and just won't leave it)
see https://issues.apache.org/jira/browse/CAMEL-19106
Line length in file "_components\camel-spring-ws\src\test\resources\org\apache\camel\component\spring\ws\addresing\ProducerParamsBasicTest-context.xml:60_" is 278 characters
There are a lot of XML files in the test resources with lines longer than **250** characters
The file "_buildingtools/srcmain/resources/camel-checkstyle.xml:95_" contains the following rule
```xml
<module name="LineLength">
<property name="max" value="250"/>
</module>
```
maven-checkstyle-plugin settings contain:
```xml
<includes>**/*.java,**/*.groovy,**/*.scala,**/*.properties,**/*.xml,**/*.xsd</includes>
```
**How can this rule for check XML not work???** Maybe something is cached on your PC and doesn't work?
Please, cd _components\camel-spring-ws_ and make clean and run checkstyle
I have Windows 10 and Java 11 on my PC. If everything works on your machine, the problem is deeper than it seemed - in the plugin itself or even in Java 11, and depends on the platform. This will mean that the XML files on your machine are simply not processed by the maven-checkstyle-plugin and it does not check them.
Maybe it has something to do with the OS? Is something wrong with Windows? More precisely, on Windows everything works as it should, XML files are checked, but on Linux it doesn't. Because on Windows, the check broke not only test XML files, also in the generated XML file, where forgoted to add a header with a Apache-License.
This can be dangerous - you expect XML files to be checked and it doesn't happen. If I'm right - then my solution will of course fix the style errors in the XML, but it will open up a strange issue with style validation on Linux, whose solution no one knows.
Well, or maybe everything works for everyone, and I'm just a schizophrenic from the Internet who invents errors that do not exist, and spends too much personal time on its solution. But I am absolutely sure that I am mentally healthy, and that I spent 2 days of my personal time not fighting illusions in my head, but trying to solve the problem of building the project.
There is another option to confirm the theory about the problem associated with Windows / Linux - find a PC or Virtual PC with Windows and conduct an experiment on Windows.
I'm 99% sure I'm right - the problematic files and settings are the same in _main, camel-3.20, and camel-3.x_. I checked. And since everything works for everyone, it means that no one tried to build on Windows. And checking in XML files just doesn't work on other OS
PS - Sorry for my horrible English, I use Google Translate
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] shmakovalexey commented on pull request #9461: [Camel 19106] repair check style for 3.x
Posted by "shmakovalexey (via GitHub)" <gi...@apache.org>.
shmakovalexey commented on PR #9461:
URL: https://github.com/apache/camel/pull/9461#issuecomment-1453154079
Error on checkstyle
[ERROR] Failed to execute goal on project camel-allcomponents: Could not resolve dependencies for project org.apache.camel:camel-allcomponents:pom:3.21.0-SNAPSHOT: Could not find artifact org.apache.camel:camel-zeebe:jar:3.21.0-SNAPSHOT in apache.snapshots (https://repository.apache.org/snapshots/)
I solved this problem on the local machine by installing the project in the local repository (mvn install). I don't know how to solve it in CI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] oscerd commented on pull request #9461: [Camel 19106] repair check style for 3.x
Posted by "oscerd (via GitHub)" <gi...@apache.org>.
oscerd commented on PR #9461:
URL: https://github.com/apache/camel/pull/9461#issuecomment-1453184454
I don't have particular point on this: to me this fix is not incorrect. If you pretend to only cherry pick from main, you will never be able to do it. It won't work in the long term.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] oscerd commented on pull request #9461: [Camel 19106] repair check style for 3.x
Posted by "oscerd (via GitHub)" <gi...@apache.org>.
oscerd commented on PR #9461:
URL: https://github.com/apache/camel/pull/9461#issuecomment-1453184755
Revert it, if you wish to.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] oscerd commented on pull request #9461: [Camel 19106] repair check style for 3.x
Posted by "oscerd (via GitHub)" <gi...@apache.org>.
oscerd commented on PR #9461:
URL: https://github.com/apache/camel/pull/9461#issuecomment-1453178314
Too late.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] oscerd commented on pull request #9461: [Camel 19106] repair check style for 3.x
Posted by "oscerd (via GitHub)" <gi...@apache.org>.
oscerd commented on PR #9461:
URL: https://github.com/apache/camel/pull/9461#issuecomment-1453186520
Reverted. Sorry @shmakovalexey , I hope you don't mind and keep contributing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org