You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/05/10 15:54:34 UTC
[GitHub] [spark] xinrong-databricks commented on a diff in pull request #36464: [SPARK-38947][PYTHON] Supports groupby positional indexing
xinrong-databricks commented on code in PR #36464:
URL: https://github.com/apache/spark/pull/36464#discussion_r869421364
##########
python/pyspark/pandas/tests/test_groupby.py:
##########
@@ -2538,40 +2538,19 @@ def test_head(self):
)
psdf = ps.from_pandas(pdf)
- self.assert_eq(
- pdf.groupby("a").head(2).sort_index(), psdf.groupby("a").head(2).sort_index()
- )
- self.assert_eq(
- pdf.groupby("a").head(-2).sort_index(), psdf.groupby("a").head(-2).sort_index()
- )
- self.assert_eq(
- pdf.groupby("a").head(100000).sort_index(), psdf.groupby("a").head(100000).sort_index()
- )
-
- self.assert_eq(
- pdf.groupby("a")["b"].head(2).sort_index(), psdf.groupby("a")["b"].head(2).sort_index()
- )
- self.assert_eq(
- pdf.groupby("a")["b"].head(-2).sort_index(),
- psdf.groupby("a")["b"].head(-2).sort_index(),
- )
- self.assert_eq(
- pdf.groupby("a")["b"].head(100000).sort_index(),
- psdf.groupby("a")["b"].head(100000).sort_index(),
- )
-
- self.assert_eq(
- pdf.groupby("a")[["b"]].head(2).sort_index(),
- psdf.groupby("a")[["b"]].head(2).sort_index(),
- )
- self.assert_eq(
- pdf.groupby("a")[["b"]].head(-2).sort_index(),
- psdf.groupby("a")[["b"]].head(-2).sort_index(),
- )
- self.assert_eq(
- pdf.groupby("a")[["b"]].head(100000).sort_index(),
- psdf.groupby("a")[["b"]].head(100000).sort_index(),
- )
+ for limit in (2, 100000, -2, -100000, -1):
Review Comment:
Nice!!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org