You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@polaris.apache.org by yu...@apache.org on 2026/08/11 18:23:10 UTC
(polaris) branch main updated: Remove used listTables(Namespace) overload from IcebergCatalogHandler (#5226)
This is an automated email from the ASF dual-hosted git repository.
flyrain pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/polaris.git
The following commit(s) were added to refs/heads/main by this push:
new f2fe2d4223 Remove used listTables(Namespace) overload from IcebergCatalogHandler (#5226)
f2fe2d4223 is described below
commit f2fe2d4223d27569dff2b0bb6c9dffe72815db17
Author: Paras Mishra <13...@users.noreply.github.com>
AuthorDate: Tue Aug 11 23:53:05 2026 +0530
Remove used listTables(Namespace) overload from IcebergCatalogHandler (#5226)
---
.../polaris/service/catalog/iceberg/CatalogHandlerUtils.java | 5 -----
.../polaris/service/catalog/iceberg/IcebergCatalogHandler.java | 7 -------
.../catalog/iceberg/AbstractIcebergCatalogHandlerAuthzTest.java | 6 +++---
3 files changed, 3 insertions(+), 15 deletions(-)
diff --git a/runtime/service/src/main/java/org/apache/polaris/service/catalog/iceberg/CatalogHandlerUtils.java b/runtime/service/src/main/java/org/apache/polaris/service/catalog/iceberg/CatalogHandlerUtils.java
index 24337d34e9..35b70aaed5 100644
--- a/runtime/service/src/main/java/org/apache/polaris/service/catalog/iceberg/CatalogHandlerUtils.java
+++ b/runtime/service/src/main/java/org/apache/polaris/service/catalog/iceberg/CatalogHandlerUtils.java
@@ -261,11 +261,6 @@ public class CatalogHandlerUtils {
.build();
}
- public ListTablesResponse listTables(Catalog catalog, Namespace namespace) {
- List<TableIdentifier> idents = catalog.listTables(namespace);
- return ListTablesResponse.builder().addAll(idents).build();
- }
-
public ListTablesResponse listTables(
Catalog catalog, Namespace namespace, String pageToken, Integer pageSize) {
List<TableIdentifier> results = catalog.listTables(namespace);
diff --git a/runtime/service/src/main/java/org/apache/polaris/service/catalog/iceberg/IcebergCatalogHandler.java b/runtime/service/src/main/java/org/apache/polaris/service/catalog/iceberg/IcebergCatalogHandler.java
index 2da5831d1e..7f7bd0d964 100644
--- a/runtime/service/src/main/java/org/apache/polaris/service/catalog/iceberg/IcebergCatalogHandler.java
+++ b/runtime/service/src/main/java/org/apache/polaris/service/catalog/iceberg/IcebergCatalogHandler.java
@@ -382,13 +382,6 @@ public abstract class IcebergCatalogHandler extends CatalogHandler implements Au
}
}
- public ListTablesResponse listTables(Namespace namespace) {
- PolarisAuthorizableOperation op = PolarisAuthorizableOperation.LIST_TABLES;
- authorizeBasicNamespaceOperationOrThrow(op, namespace);
-
- return catalogHandlerUtils().listTables(baseCatalog, namespace);
- }
-
/**
* Create a table.
*
diff --git a/runtime/service/src/test/java/org/apache/polaris/service/catalog/iceberg/AbstractIcebergCatalogHandlerAuthzTest.java b/runtime/service/src/test/java/org/apache/polaris/service/catalog/iceberg/AbstractIcebergCatalogHandlerAuthzTest.java
index 48cf7bd016..ed1825a8a9 100644
--- a/runtime/service/src/test/java/org/apache/polaris/service/catalog/iceberg/AbstractIcebergCatalogHandlerAuthzTest.java
+++ b/runtime/service/src/test/java/org/apache/polaris/service/catalog/iceberg/AbstractIcebergCatalogHandlerAuthzTest.java
@@ -219,7 +219,7 @@ public abstract class AbstractIcebergCatalogHandlerAuthzTest extends PolarisAuth
.shouldFailWithAnyPrivilege()
.createTests(),
authzTestsBuilder("listTables (before rotation)")
- .action(() -> handler.get().listTables(NS1))
+ .action(() -> handler.get().listTables(NS1, null, null))
.principalName(principalName)
.shouldFailWithAnyPrivilege()
.createTests())
@@ -283,7 +283,7 @@ public abstract class AbstractIcebergCatalogHandlerAuthzTest extends PolarisAuth
.shouldPassWith(PolarisPrivilege.CATALOG_MANAGE_METADATA)
.createTests(),
authzTestsBuilder("listTables (after rotation)")
- .action(() -> refreshedWrapper.get().listTables(NS1))
+ .action(() -> refreshedWrapper.get().listTables(NS1, null, null))
.principalName(principalName)
.shouldPassWith(PolarisPrivilege.TABLE_LIST)
.shouldPassWith(PolarisPrivilege.TABLE_CREATE)
@@ -463,7 +463,7 @@ public abstract class AbstractIcebergCatalogHandlerAuthzTest extends PolarisAuth
@TestFactory
Stream<DynamicNode> testListTablesPrivileges() {
return authzTestsBuilder("listTables")
- .action(() -> newHandler().listTables(NS1A))
+ .action(() -> newHandler().listTables(NS1A, null, null))
.shouldPassWith(PolarisPrivilege.TABLE_LIST)
.shouldPassWith(PolarisPrivilege.TABLE_READ_PROPERTIES)
.shouldPassWith(PolarisPrivilege.TABLE_WRITE_PROPERTIES)