You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@solr.apache.org by "ASF subversion and git services (Jira)" <ji...@apache.org> on 2022/09/14 13:36:00 UTC

[jira] [Commented] (SOLR-16314) Annotations like @Before etc should be public visiblity

    [ https://issues.apache.org/jira/browse/SOLR-16314?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17604683#comment-17604683 ] 

ASF subversion and git services commented on SOLR-16314:
--------------------------------------------------------

Commit 32b7e0efa8f5f20828903880c978dcdba972db51 in solr's branch refs/heads/main from Eric Pugh
[ https://gitbox.apache.org/repos/asf?p=solr.git;h=32b7e0efa8f ]

SOLR-16314: fix warnings about method visibility (#954)

Co-authored-by: Christine Poerschke <cp...@apache.org>

> Annotations like @Before etc should be public visiblity
> -------------------------------------------------------
>
>                 Key: SOLR-16314
>                 URL: https://issues.apache.org/jira/browse/SOLR-16314
>             Project: Solr
>          Issue Type: Sub-task
>          Components: Tests
>    Affects Versions: main (10.0)
>            Reporter: Eric Pugh
>            Priority: Trivial
>          Time Spent: 40m
>  Remaining Estimate: 0h
>
> Annotations for unit tests should be public, though in testing, the private methods DO get called.   We have a mix of public and private usage however, so lets eliminate the warning and just use public.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org