You are viewing a plain text version of this content. The canonical link for it is here.
Posted to oak-dev@jackrabbit.apache.org by "bhabegger (via GitHub)" <gi...@apache.org> on 2026/04/08 14:38:13 UTC
[PR] OAK-12057: Add feature toggle for LIMIT-aware index selection [jackrabbit-oak]
bhabegger opened a new pull request, #2831:
URL: https://github.com/apache/jackrabbit-oak/pull/2831
## Summary
Adds a feature toggle (`FT_IGNORE_LIMIT_IN_INDEX_SELECTION`) to enable gradual rollout of OAK-12057 (wrong index selection when using LIMIT).
- **Default (ON)**: Uses the optimized behavior from PR #2724 - ignores LIMIT/OFFSET when calculating index costs
- **Toggle OFF**: Reverts to legacy behavior - caps entry counts by offset+limit
## Changes
- Added toggle constant and infrastructure in `QueryEngineSettings`
- Registered feature in `Oak.java`
- Wrapped index entry count capping logic in `QueryImpl.java` with toggle check
Allows safe gradual deployment without requiring immediate rollout to all environments.
[AI]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: oak-dev-unsubscribe@jackrabbit.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] OAK-12057: Add feature toggle for LIMIT-aware index selection [jackrabbit-oak]
Posted by "thomasmueller (via GitHub)" <gi...@apache.org>.
thomasmueller merged PR #2831:
URL: https://github.com/apache/jackrabbit-oak/pull/2831
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: oak-dev-unsubscribe@jackrabbit.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] OAK-12057: Add feature toggle for LIMIT-aware index selection [jackrabbit-oak]
Posted by "thomasmueller (via GitHub)" <gi...@apache.org>.
thomasmueller commented on PR #2831:
URL: https://github.com/apache/jackrabbit-oak/pull/2831#issuecomment-4222502713
Merged into the branch
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: oak-dev-unsubscribe@jackrabbit.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] OAK-12057: Add feature toggle for LIMIT-aware index selection [jackrabbit-oak]
Posted by "thomasmueller (via GitHub)" <gi...@apache.org>.
thomasmueller commented on PR #2831:
URL: https://github.com/apache/jackrabbit-oak/pull/2831#issuecomment-4221843169
So, that means
* If the feature toggle is unavailable or returning "true", then we use the new behavior.
* if the feature toggle is available and returning "false", then we switch back to the old (legacy) behavior.
Right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: oak-dev-unsubscribe@jackrabbit.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] OAK-12057: Add feature toggle for LIMIT-aware index selection [jackrabbit-oak]
Posted by "bhabegger (via GitHub)" <gi...@apache.org>.
bhabegger commented on PR #2831:
URL: https://github.com/apache/jackrabbit-oak/pull/2831#issuecomment-4222379865
@thomasmueller Yes, exactly ;) But default we want to ignore the LIMIT (which was the legacy behavior).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: oak-dev-unsubscribe@jackrabbit.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org