You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Grant Henke (Code Review)" <ge...@cloudera.org> on 2020/08/24 21:21:19 UTC
[kudu-CR] [build] Adjust JAVA HOME candidates
Grant Henke has uploaded this change for review. ( http://gerrit.cloudera.org:8080/16354
Change subject: [build] Adjust JAVA_HOME candidates
......................................................................
[build] Adjust JAVA_HOME candidates
This patch removes the Java 7 candidates given Java 7 is no
longer supported and adds Java 11 candidates along with
a few more generic candidates.
Change-Id: Ie51cde4153be23e8f33fcc061531c2c022791b16
---
M build-support/java-home-candidates.txt
1 file changed, 19 insertions(+), 14 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/54/16354/1
--
To view, visit http://gerrit.cloudera.org:8080/16354
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie51cde4153be23e8f33fcc061531c2c022791b16
Gerrit-Change-Number: 16354
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
[kudu-CR] [build] Adjust JAVA HOME candidates
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/16354 )
Change subject: [build] Adjust JAVA_HOME candidates
......................................................................
Patch Set 4: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/16354
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie51cde4153be23e8f33fcc061531c2c022791b16
Gerrit-Change-Number: 16354
Gerrit-PatchSet: 4
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 26 Aug 2020 21:51:14 +0000
Gerrit-HasComments: No
[kudu-CR] [build] Adjust JAVA HOME candidates
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Hello Alexey Serbin, Attila Bukor, Kudu Jenkins, Andrew Wong, Bankim Bhavsar,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/16354
to look at the new patch set (#3).
Change subject: [build] Adjust JAVA_HOME candidates
......................................................................
[build] Adjust JAVA_HOME candidates
This patch removes the Java 7 candidates given Java 7 is no
longer supported and adds Java 11 candidates along with
a few more generic candidates.
The updated version of bigtop-detect-javahome, which is the
original inspiration for this file, was used to help update this file.
https://github.com/apache/bigtop/blob/master/bigtop-packages/src/common/bigtop-utils/bigtop-detect-javahome
Change-Id: Ie51cde4153be23e8f33fcc061531c2c022791b16
---
M build-support/java-home-candidates.txt
1 file changed, 20 insertions(+), 14 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/54/16354/3
--
To view, visit http://gerrit.cloudera.org:8080/16354
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ie51cde4153be23e8f33fcc061531c2c022791b16
Gerrit-Change-Number: 16354
Gerrit-PatchSet: 3
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [build] Adjust JAVA HOME candidates
Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/16354 )
Change subject: [build] Adjust JAVA_HOME candidates
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/16354
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie51cde4153be23e8f33fcc061531c2c022791b16
Gerrit-Change-Number: 16354
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 25 Aug 2020 22:23:51 +0000
Gerrit-HasComments: No
[kudu-CR] [build] Adjust JAVA HOME candidates
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/16354 )
Change subject: [build] Adjust JAVA_HOME candidates
......................................................................
[build] Adjust JAVA_HOME candidates
This patch removes the Java 7 candidates given Java 7 is no
longer supported and adds Java 11 candidates along with
a few more generic candidates.
The updated version of bigtop-detect-javahome, which is the
original inspiration for this file, was used to help update this file.
https://github.com/apache/bigtop/blob/master/bigtop-packages/src/common/bigtop-utils/bigtop-detect-javahome
Change-Id: Ie51cde4153be23e8f33fcc061531c2c022791b16
Reviewed-on: http://gerrit.cloudera.org:8080/16354
Reviewed-by: Grant Henke <gr...@apache.org>
Tested-by: Grant Henke <gr...@apache.org>
---
M build-support/java-home-candidates.txt
1 file changed, 20 insertions(+), 14 deletions(-)
Approvals:
Grant Henke: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/16354
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie51cde4153be23e8f33fcc061531c2c022791b16
Gerrit-Change-Number: 16354
Gerrit-PatchSet: 4
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [build] Adjust JAVA HOME candidates
Posted by "Bankim Bhavsar (Code Review)" <ge...@cloudera.org>.
Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/16354 )
Change subject: [build] Adjust JAVA_HOME candidates
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/16354
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie51cde4153be23e8f33fcc061531c2c022791b16
Gerrit-Change-Number: 16354
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 25 Aug 2020 21:46:43 +0000
Gerrit-HasComments: No
[kudu-CR] [build] Adjust JAVA HOME candidates
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16354 )
Change subject: [build] Adjust JAVA_HOME candidates
......................................................................
Patch Set 2: Code-Review+2
(1 comment)
http://gerrit.cloudera.org:8080/#/c/16354/2//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/16354/2//COMMIT_MSG@13
PS2, Line 13: The updated version of bigtop-detect-javahome, which is the original inspiration for this file, was used to help update this file.
nit: wrap lines
--
To view, visit http://gerrit.cloudera.org:8080/16354
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie51cde4153be23e8f33fcc061531c2c022791b16
Gerrit-Change-Number: 16354
Gerrit-PatchSet: 2
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 26 Aug 2020 21:01:52 +0000
Gerrit-HasComments: Yes
[kudu-CR] [build] Adjust JAVA HOME candidates
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/16354 )
Change subject: [build] Adjust JAVA_HOME candidates
......................................................................
Patch Set 3: Verified+1 Code-Review+2
Carrying the +2 through the commit message change.
--
To view, visit http://gerrit.cloudera.org:8080/16354
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie51cde4153be23e8f33fcc061531c2c022791b16
Gerrit-Change-Number: 16354
Gerrit-PatchSet: 3
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 26 Aug 2020 21:19:17 +0000
Gerrit-HasComments: No
[kudu-CR] [build] Adjust JAVA HOME candidates
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16354 )
Change subject: [build] Adjust JAVA_HOME candidates
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/16354/1/build-support/java-home-candidates.txt
File build-support/java-home-candidates.txt:
http://gerrit.cloudera.org:8080/#/c/16354/1/build-support/java-home-candidates.txt@18
PS1, Line 18: in priority order.
> It looks like it was newer to older, specific to generic. I didn't intent t
Sounds reasonable. Can you update this comment so future devs/reviewers can follow that?
--
To view, visit http://gerrit.cloudera.org:8080/16354
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie51cde4153be23e8f33fcc061531c2c022791b16
Gerrit-Change-Number: 16354
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 26 Aug 2020 19:00:35 +0000
Gerrit-HasComments: Yes
[kudu-CR] [build] Adjust JAVA HOME candidates
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Hello Alexey Serbin, Attila Bukor, Kudu Jenkins, Andrew Wong, Bankim Bhavsar,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/16354
to look at the new patch set (#2).
Change subject: [build] Adjust JAVA_HOME candidates
......................................................................
[build] Adjust JAVA_HOME candidates
This patch removes the Java 7 candidates given Java 7 is no
longer supported and adds Java 11 candidates along with
a few more generic candidates.
The updated version of bigtop-detect-javahome, which is the original inspiration for this file, was used to help update this file.
https://github.com/apache/bigtop/blob/master/bigtop-packages/src/common/bigtop-utils/bigtop-detect-javahome
Change-Id: Ie51cde4153be23e8f33fcc061531c2c022791b16
---
M build-support/java-home-candidates.txt
1 file changed, 20 insertions(+), 14 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/54/16354/2
--
To view, visit http://gerrit.cloudera.org:8080/16354
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ie51cde4153be23e8f33fcc061531c2c022791b16
Gerrit-Change-Number: 16354
Gerrit-PatchSet: 2
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [build] Adjust JAVA HOME candidates
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/16354 )
Change subject: [build] Adjust JAVA_HOME candidates
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/16354/1/build-support/java-home-candidates.txt
File build-support/java-home-candidates.txt:
http://gerrit.cloudera.org:8080/#/c/16354/1/build-support/java-home-candidates.txt@51
PS1, Line 51: /Library/Java/Home
nit: maybe JAVA installation on my laptop is missing something, but in my case there isn't /Library/Java/Home. Instead, there is /Library/Java/JavaVirtualMachines/jdk1.8.0_102.jdk/Contents/Home
--
To view, visit http://gerrit.cloudera.org:8080/16354
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie51cde4153be23e8f33fcc061531c2c022791b16
Gerrit-Change-Number: 16354
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 26 Aug 2020 00:19:01 +0000
Gerrit-HasComments: Yes
[kudu-CR] [build] Adjust JAVA HOME candidates
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16354 )
Change subject: [build] Adjust JAVA_HOME candidates
......................................................................
Patch Set 1: Code-Review+1
(1 comment)
http://gerrit.cloudera.org:8080/#/c/16354/1/build-support/java-home-candidates.txt
File build-support/java-home-candidates.txt:
http://gerrit.cloudera.org:8080/#/c/16354/1/build-support/java-home-candidates.txt@18
PS1, Line 18: in priority order.
What are the guiding principles here?
--
To view, visit http://gerrit.cloudera.org:8080/16354
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie51cde4153be23e8f33fcc061531c2c022791b16
Gerrit-Change-Number: 16354
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 26 Aug 2020 00:08:21 +0000
Gerrit-HasComments: Yes
[kudu-CR] [build] Adjust JAVA HOME candidates
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/16354 )
Change subject: [build] Adjust JAVA_HOME candidates
......................................................................
Patch Set 1:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/16354/1/build-support/java-home-candidates.txt
File build-support/java-home-candidates.txt:
http://gerrit.cloudera.org:8080/#/c/16354/1/build-support/java-home-candidates.txt@18
PS1, Line 18: in priority order.
> What are the guiding principles here?
It looks like it was newer to older, specific to generic. I didn't intent to change that in this patch.
http://gerrit.cloudera.org:8080/#/c/16354/1/build-support/java-home-candidates.txt@51
PS1, Line 51: /Library/Java/Home
> nit: maybe JAVA installation on my laptop is missing something, but in my c
This came from the updated version of bigtop-detect-javahome which is the original inspiration for this file. I don't see a reason not to include it.
https://github.com/apache/bigtop/blob/master/bigtop-packages/src/common/bigtop-utils/bigtop-detect-javahome
--
To view, visit http://gerrit.cloudera.org:8080/16354
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie51cde4153be23e8f33fcc061531c2c022791b16
Gerrit-Change-Number: 16354
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 26 Aug 2020 13:55:09 +0000
Gerrit-HasComments: Yes
[kudu-CR] [build] Adjust JAVA HOME candidates
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/16354 )
Change subject: [build] Adjust JAVA_HOME candidates
......................................................................
Patch Set 1:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/16354/1/build-support/java-home-candidates.txt
File build-support/java-home-candidates.txt:
http://gerrit.cloudera.org:8080/#/c/16354/1/build-support/java-home-candidates.txt@18
PS1, Line 18: in priority order.
> Sounds reasonable. Can you update this comment so future devs/reviewers can
Done
http://gerrit.cloudera.org:8080/#/c/16354/1/build-support/java-home-candidates.txt@51
PS1, Line 51: /Library/Java/Home
> Thank you for the clarification. Just for posterity, could you include thi
Done
--
To view, visit http://gerrit.cloudera.org:8080/16354
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie51cde4153be23e8f33fcc061531c2c022791b16
Gerrit-Change-Number: 16354
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 26 Aug 2020 20:59:12 +0000
Gerrit-HasComments: Yes
[kudu-CR] [build] Adjust JAVA HOME candidates
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/16354 )
Change subject: [build] Adjust JAVA_HOME candidates
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/16354/1/build-support/java-home-candidates.txt
File build-support/java-home-candidates.txt:
http://gerrit.cloudera.org:8080/#/c/16354/1/build-support/java-home-candidates.txt@51
PS1, Line 51: /Library/Java/Home
> This came from the updated version of bigtop-detect-javahome which is the o
Thank you for the clarification. Just for posterity, could you include this information in the commit message as well? I think it will help in to maintain this file in the future.
--
To view, visit http://gerrit.cloudera.org:8080/16354
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie51cde4153be23e8f33fcc061531c2c022791b16
Gerrit-Change-Number: 16354
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 26 Aug 2020 19:00:23 +0000
Gerrit-HasComments: Yes
[kudu-CR] [build] Adjust JAVA HOME candidates
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/16354 )
Change subject: [build] Adjust JAVA_HOME candidates
......................................................................
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/16354/2//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/16354/2//COMMIT_MSG@13
PS2, Line 13: The updated version of bigtop-detect-javahome, which is the original inspiration for this file, was used to help update this file.
> nit: wrap lines
Done
--
To view, visit http://gerrit.cloudera.org:8080/16354
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie51cde4153be23e8f33fcc061531c2c022791b16
Gerrit-Change-Number: 16354
Gerrit-PatchSet: 2
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 26 Aug 2020 21:10:23 +0000
Gerrit-HasComments: Yes