[GitHub] [solr] HoustonPutman commented on pull request #776: Attempt to fix various testing thread leaks

[GitBox <gi...@apache.org>]

HoustonPutman commented on pull request #776:
URL: https://github.com/apache/solr/pull/776#issuecomment-1083445507


   The failing tests are threads leaking in `TestCancellableCollector` and `OrderedExecutorTest`.
   
   I can't reproduce the failures locally, but it seems like a harmless addition to try and kill the threads after the tests finish. The threads aren't solr threads, merely test threads, so it shouldn't be a big deal to kill them immediately on close.
   
   But I'll wait on this until Mike has done his work on his branch.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org