[jira] [Commented] (THRIFT-3921) C++ code should print enums as strings

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/THRIFT-3921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15843856#comment-15843856 ] 

ASF GitHub Bot commented on THRIFT-3921:
----------------------------------------

Github user jeking3 commented on the issue:

    https://github.com/apache/thrift/pull/1083
  
    Hello - when I upgraded a project to thrift-0.10.0 I found I needed to provide the operator << for enumerations.  I am a bit concerned we're not providing an operator >> as well; I think it would be a good idea to make sure the implementation can be overridden.  That said, if you could rebase on master and force push it will kick a new CI build; I would like to see things passing (save maybe build job 17 which has had some trouble lately).


> C++ code should print enums as strings
> --------------------------------------
>
>                 Key: THRIFT-3921
>                 URL: https://issues.apache.org/jira/browse/THRIFT-3921
>             Project: Thrift
>          Issue Type: Improvement
>          Components: C++ - Compiler
>            Reporter: Vivek Jain
>
> THRIFT-2067 added {{operator<<}} to the C++ generated code, which is great, but enums are printed as numbers rather than their string representation. It would be great if the generated code printed them as a string instead. There might be some backwards-compatibility concerns (if users have already defined their own versions, then thrift's version would cause compile errors), not sure how important you guys think those are.
> Other thoughts/concerns? I am willing to work on a patch if no one else is able to work on it.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)