You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2021/03/29 07:38:26 UTC

[GitHub] [iotdb] jixuan1989 commented on pull request #2904: [IOTDB-1257] Make a little bit improvement of config and fix some bugs for setting logic

jixuan1989 commented on pull request #2904:
URL: https://github.com/apache/iotdb/pull/2904#issuecomment-809147802


   The only concern from me is the default_buffer size is set as 16MB while it was 64KB.
   Whether it has side-effect depends on:
   1. How Thrift runs? will it generate a defined (not cached) buffer (64KB or 16MB) for each request?
   2. Will IoTDB generate some small RPC requests/responses frequently?
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org