[GitHub] [hadoop] steveloughran commented on a diff in pull request #5821: HADOOP-18795. S3A DelegationToken plugin to expand return type of binding

["steveloughran (via GitHub)" <gi...@apache.org>]

steveloughran commented on code in PR #5821:
URL: https://github.com/apache/hadoop/pull/5821#discussion_r1269272966


##########
hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/auth/delegation/S3ADelegationTokens.java:
##########
@@ -123,7 +123,12 @@ public class S3ADelegationTokens extends AbstractDTService {
   /**
    * List of cred providers; unset until {@link #bindToDelegationToken(Token)}.
    */
-  private Optional<AWSCredentialProviderList> credentialProviders
+  //private Optional<AWSCredentialProviderList> credentialProviders = Optional.empty();

Review Comment:
   aah, too late.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org