You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@bookkeeper.apache.org by "Ivan Kelly (JIRA)" <ji...@apache.org> on 2012/06/25 20:05:44 UTC
[jira] [Created] (BOOKKEEPER-317) Exceptions for replication
Ivan Kelly created BOOKKEEPER-317:
-------------------------------------
Summary: Exceptions for replication
Key: BOOKKEEPER-317
URL: https://issues.apache.org/jira/browse/BOOKKEEPER-317
Project: Bookkeeper
Issue Type: Sub-task
Reporter: Ivan Kelly
Assignee: Ivan Kelly
Fix For: 4.2.0
A couple of the BOOKKEEPER-237 jiras need to add new exceptions. This jira creates the umbrella exception which they can all go under.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (BOOKKEEPER-317) Exceptions for replication
Posted by "Rakesh R (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BOOKKEEPER-317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13401244#comment-13401244 ]
Rakesh R commented on BOOKKEEPER-317:
-------------------------------------
@Ivan
Its great and will avoid cross overs.
Just one comment - It would be good to have @SuppressWarnings("serial") in class level, just to avoid the following
{code}
The serializable class ReplicationException does not declare a static final serialVersionUID field of type
long
{code}
> Exceptions for replication
> --------------------------
>
> Key: BOOKKEEPER-317
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-317
> Project: Bookkeeper
> Issue Type: Sub-task
> Reporter: Ivan Kelly
> Assignee: Ivan Kelly
> Fix For: 4.2.0
>
> Attachments: BOOKKEEPER-317.diff
>
>
> A couple of the BOOKKEEPER-237 jiras need to add new exceptions. This jira creates the umbrella exception which they can all go under.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (BOOKKEEPER-317) Exceptions for replication
Posted by "Uma Maheswara Rao G (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BOOKKEEPER-317?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Uma Maheswara Rao G updated BOOKKEEPER-317:
-------------------------------------------
Component/s: bookkeeper-auto-recovery
> Exceptions for replication
> --------------------------
>
> Key: BOOKKEEPER-317
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-317
> Project: Bookkeeper
> Issue Type: Sub-task
> Components: bookkeeper-auto-recovery
> Reporter: Ivan Kelly
> Assignee: Ivan Kelly
> Fix For: 4.2.0
>
> Attachments: BOOKKEEPER-317.diff, BOOKKEEPER-317.diff
>
>
> A couple of the BOOKKEEPER-237 jiras need to add new exceptions. This jira creates the umbrella exception which they can all go under.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (BOOKKEEPER-317) Exceptions for replication
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BOOKKEEPER-317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13423028#comment-13423028 ]
Hudson commented on BOOKKEEPER-317:
-----------------------------------
Integrated in bookkeeper-trunk #620 (See [https://builds.apache.org/job/bookkeeper-trunk/620/])
BOOKKEEPER-317: Exceptions for replication (ivank via sijie) (Revision 1365870)
Result = UNSTABLE
sijie :
Files :
* /zookeeper/bookkeeper/trunk/CHANGES.txt
* /zookeeper/bookkeeper/trunk/bookkeeper-server/src/main/java/org/apache/bookkeeper/replication
* /zookeeper/bookkeeper/trunk/bookkeeper-server/src/main/java/org/apache/bookkeeper/replication/ReplicationException.java
> Exceptions for replication
> --------------------------
>
> Key: BOOKKEEPER-317
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-317
> Project: Bookkeeper
> Issue Type: Sub-task
> Reporter: Ivan Kelly
> Assignee: Ivan Kelly
> Fix For: 4.2.0
>
> Attachments: BOOKKEEPER-317.diff, BOOKKEEPER-317.diff
>
>
> A couple of the BOOKKEEPER-237 jiras need to add new exceptions. This jira creates the umbrella exception which they can all go under.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (BOOKKEEPER-317) Exceptions for replication
Posted by "Uma Maheswara Rao G (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BOOKKEEPER-317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13401255#comment-13401255 ]
Uma Maheswara Rao G commented on BOOKKEEPER-317:
------------------------------------------------
@Rakesh,
{quote}
It would be good to have @SuppressWarnings("serial") in class level
{quote}
In general , having the SuppressWarnings at class level will not be a good idea, because it may suppress real comments later.
But this is an exception class, it may be ok?
> Exceptions for replication
> --------------------------
>
> Key: BOOKKEEPER-317
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-317
> Project: Bookkeeper
> Issue Type: Sub-task
> Reporter: Ivan Kelly
> Assignee: Ivan Kelly
> Fix For: 4.2.0
>
> Attachments: BOOKKEEPER-317.diff
>
>
> A couple of the BOOKKEEPER-237 jiras need to add new exceptions. This jira creates the umbrella exception which they can all go under.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (BOOKKEEPER-317) Exceptions for replication
Posted by "Flavio Junqueira (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BOOKKEEPER-317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13422597#comment-13422597 ]
Flavio Junqueira commented on BOOKKEEPER-317:
---------------------------------------------
+1, lgtm.
> Exceptions for replication
> --------------------------
>
> Key: BOOKKEEPER-317
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-317
> Project: Bookkeeper
> Issue Type: Sub-task
> Reporter: Ivan Kelly
> Assignee: Ivan Kelly
> Fix For: 4.2.0
>
> Attachments: BOOKKEEPER-317.diff, BOOKKEEPER-317.diff
>
>
> A couple of the BOOKKEEPER-237 jiras need to add new exceptions. This jira creates the umbrella exception which they can all go under.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (BOOKKEEPER-317) Exceptions for replication
Posted by "Rakesh R (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BOOKKEEPER-317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13404415#comment-13404415 ]
Rakesh R commented on BOOKKEEPER-317:
-------------------------------------
@Ivan @Uma
Yeah, adding serialVersionUID is nice.
I was thinking BK project coding pattern is suppressing these warnings(referred BookieException, BKException classes)
> Exceptions for replication
> --------------------------
>
> Key: BOOKKEEPER-317
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-317
> Project: Bookkeeper
> Issue Type: Sub-task
> Reporter: Ivan Kelly
> Assignee: Ivan Kelly
> Fix For: 4.2.0
>
> Attachments: BOOKKEEPER-317.diff
>
>
> A couple of the BOOKKEEPER-237 jiras need to add new exceptions. This jira creates the umbrella exception which they can all go under.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (BOOKKEEPER-317) Exceptions for replication
Posted by "Ivan Kelly (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BOOKKEEPER-317?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ivan Kelly updated BOOKKEEPER-317:
----------------------------------
Attachment: BOOKKEEPER-317.diff
Fixed the typo in compatibility, renamed exception and added serialVersionUIDs which are randomly generated.
I didn't add the structural stuff for error codes and #create(). These things are for async apis. These exceptions are only for the replication service, which will run as a daemon, with no interactive apis. api's for checking a ledger or running replication will be async, but they will be on org.apache.bookkeeper.client.BookKeeperAdmin (they have to be in the client package to access internals). As such, they will use BKException.
> Exceptions for replication
> --------------------------
>
> Key: BOOKKEEPER-317
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-317
> Project: Bookkeeper
> Issue Type: Sub-task
> Reporter: Ivan Kelly
> Assignee: Ivan Kelly
> Fix For: 4.2.0
>
> Attachments: BOOKKEEPER-317.diff, BOOKKEEPER-317.diff
>
>
> A couple of the BOOKKEEPER-237 jiras need to add new exceptions. This jira creates the umbrella exception which they can all go under.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (BOOKKEEPER-317) Exceptions for replication
Posted by "Ivan Kelly (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BOOKKEEPER-317?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ivan Kelly updated BOOKKEEPER-317:
----------------------------------
Attachment: BOOKKEEPER-317.diff
> Exceptions for replication
> --------------------------
>
> Key: BOOKKEEPER-317
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-317
> Project: Bookkeeper
> Issue Type: Sub-task
> Reporter: Ivan Kelly
> Assignee: Ivan Kelly
> Fix For: 4.2.0
>
> Attachments: BOOKKEEPER-317.diff
>
>
> A couple of the BOOKKEEPER-237 jiras need to add new exceptions. This jira creates the umbrella exception which they can all go under.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (BOOKKEEPER-317) Exceptions for replication
Posted by "Uma Maheswara Rao G (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BOOKKEEPER-317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13404360#comment-13404360 ]
Uma Maheswara Rao G commented on BOOKKEEPER-317:
------------------------------------------------
{quote}
Why suppress? I can just add a serialVersionUID.
{quote}
This is also good. We can simply add serialVersionUID.
> Exceptions for replication
> --------------------------
>
> Key: BOOKKEEPER-317
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-317
> Project: Bookkeeper
> Issue Type: Sub-task
> Reporter: Ivan Kelly
> Assignee: Ivan Kelly
> Fix For: 4.2.0
>
> Attachments: BOOKKEEPER-317.diff
>
>
> A couple of the BOOKKEEPER-237 jiras need to add new exceptions. This jira creates the umbrella exception which they can all go under.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (BOOKKEEPER-317) Exceptions for replication
Posted by "Flavio Junqueira (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BOOKKEEPER-317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13401235#comment-13401235 ]
Flavio Junqueira commented on BOOKKEEPER-317:
---------------------------------------------
A few comments on the patch, Ivan:
# It might be a good idea to follow a structure similar to BKException with a create method and a Code interface. One reason for having that list of codes is to enable rc values for callbacks. Do we have such callbacks for replication?
# There is a typo in the javadoc statement for CompatException: Compatability -> Compatibility
# I'd rather spell it out and name the exception CompatibilityException.
> Exceptions for replication
> --------------------------
>
> Key: BOOKKEEPER-317
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-317
> Project: Bookkeeper
> Issue Type: Sub-task
> Reporter: Ivan Kelly
> Assignee: Ivan Kelly
> Fix For: 4.2.0
>
> Attachments: BOOKKEEPER-317.diff
>
>
> A couple of the BOOKKEEPER-237 jiras need to add new exceptions. This jira creates the umbrella exception which they can all go under.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (BOOKKEEPER-317) Exceptions for replication
Posted by "Uma Maheswara Rao G (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BOOKKEEPER-317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13401209#comment-13401209 ]
Uma Maheswara Rao G commented on BOOKKEEPER-317:
------------------------------------------------
+1 for the patch.
> Exceptions for replication
> --------------------------
>
> Key: BOOKKEEPER-317
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-317
> Project: Bookkeeper
> Issue Type: Sub-task
> Reporter: Ivan Kelly
> Assignee: Ivan Kelly
> Fix For: 4.2.0
>
> Attachments: BOOKKEEPER-317.diff
>
>
> A couple of the BOOKKEEPER-237 jiras need to add new exceptions. This jira creates the umbrella exception which they can all go under.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (BOOKKEEPER-317) Exceptions for replication
Posted by "Ivan Kelly (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BOOKKEEPER-317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13403993#comment-13403993 ]
Ivan Kelly commented on BOOKKEEPER-317:
---------------------------------------
Why suppress? I can just add a serialVersionUID.
> Exceptions for replication
> --------------------------
>
> Key: BOOKKEEPER-317
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-317
> Project: Bookkeeper
> Issue Type: Sub-task
> Reporter: Ivan Kelly
> Assignee: Ivan Kelly
> Fix For: 4.2.0
>
> Attachments: BOOKKEEPER-317.diff
>
>
> A couple of the BOOKKEEPER-237 jiras need to add new exceptions. This jira creates the umbrella exception which they can all go under.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira