[GitHub] [activemq-artemis] ViliusS commented on pull request #4206: ARTEMIS-3983 Change docker base image version from JDK to JRE

[GitBox <gi...@apache.org>]

ViliusS commented on PR #4206:
URL: https://github.com/apache/activemq-artemis/pull/4206#issuecomment-1248933731

   The difference is 250MB vs 450MB.
   
   I would agree that running Artemis in development JDK tools could be needed, but I don't agree that including these tools in production (even if needed sometimes) is good idea. Generally production images should be a slim as possible to reduce attack surface, size for fast development, etc. etc.
   
   Maybe it is better to have two Dockerfiles then, one for development and one for production, clearly marked? If you think that would be better, I can adjust PR. Also it's probably wise to forgo Debian image as it is built against deprecated openjdk image which is not updated anymore https://github.com/docker-library/openjdk/issues/505


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org