You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/08/19 11:43:31 UTC
[GitHub] [airflow] potiuk opened a new pull request #10402: Replaced aliases for common tools with functions.
potiuk opened a new pull request #10402:
URL: https://github.com/apache/airflow/pull/10402
This allows for all the kinds of verbosity we want, including
writing outputs to output files, and it also works out-of-the-box
in git-commit non-interactive shell scripts. Also as a side effect
we have mocked tools in bats tests, which will allow us to write
more comprehensive unit tests for the bash scripts of ours
(this is a long overdue task).
Part of #10368
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #10402: Replaced aliases for common tools with functions.
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #10402:
URL: https://github.com/apache/airflow/pull/10402#issuecomment-676259069
Don't expect any more failures :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #10402: Replaced aliases for common tools with functions.
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #10402:
URL: https://github.com/apache/airflow/pull/10402#issuecomment-676211992
Inspired by @feluelle I found a much better way - instead of aliases I am using functions with the same name. That required extraction of command binary paths at the time of function definition, but it works much better (for example it works in non-interactive git pre-commits and also it opens up capabilities of automated testing of our bash functions (which I planned for quite some time). That will come next.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk merged pull request #10402: Replaced aliases for common tools with functions.
Posted by GitBox <gi...@apache.org>.
potiuk merged pull request #10402:
URL: https://github.com/apache/airflow/pull/10402
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org