You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/02/25 06:24:16 UTC
[GitHub] [incubator-nuttx] yamt opened a new pull request #374: Make it
clear the timestamp of pass1 directory is not important
yamt opened a new pull request #374: Make it clear the timestamp of pass1 directory is not important
URL: https://github.com/apache/incubator-nuttx/pull/374
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] jerpelea commented on a change in pull request
#374: Make it clear the timestamp of pass1 directory is not important
Posted by GitBox <gi...@apache.org>.
jerpelea commented on a change in pull request #374: Make it clear the timestamp of pass1 directory is not important
URL: https://github.com/apache/incubator-nuttx/pull/374#discussion_r384496235
##########
File path: tools/Makefile.win
##########
@@ -178,6 +178,8 @@ BIN = $(NUTTXNAME)$(EXEEXT)
all: $(BIN)
.PHONY: dirlinks context clean_context check_context configenv config oldconfig menuconfig nconfig export subdir_clean clean subdir_distclean distclean apps_clean apps_distclean
+.PHONY: pass1 pass1deps pass1dep
+.PHONY: pass2 pass2deps pass2dep
Review comment:
Sorry for jumping in but isn't that hardly readable
I propose that we split in on several lines
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #374: Make it
clear the timestamp of pass1 directory is not important
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 merged pull request #374: Make it clear the timestamp of pass1 directory is not important
URL: https://github.com/apache/incubator-nuttx/pull/374
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull
request #374: Make it clear the timestamp of pass1 directory is not important
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on a change in pull request #374: Make it clear the timestamp of pass1 directory is not important
URL: https://github.com/apache/incubator-nuttx/pull/374#discussion_r384239850
##########
File path: tools/Makefile.win
##########
@@ -178,6 +178,8 @@ BIN = $(NUTTXNAME)$(EXEEXT)
all: $(BIN)
.PHONY: dirlinks context clean_context check_context configenv config oldconfig menuconfig nconfig export subdir_clean clean subdir_distclean distclean apps_clean apps_distclean
+.PHONY: pass1 pass1deps pass1dep
+.PHONY: pass2 pass2deps pass2dep
Review comment:
let's merge into one line since line 180 is already very long.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] patacongo commented on issue #374: Make it clear
the timestamp of pass1 directory is not important
Posted by GitBox <gi...@apache.org>.
patacongo commented on issue #374: Make it clear the timestamp of pass1 directory is not important
URL: https://github.com/apache/incubator-nuttx/pull/374#issuecomment-591428693
@xiaoxiang781216 Please merge if and when you are satisfied with the change.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull
request #374: Make it clear the timestamp of pass1 directory is not important
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on a change in pull request #374: Make it clear the timestamp of pass1 directory is not important
URL: https://github.com/apache/incubator-nuttx/pull/374#discussion_r384239850
##########
File path: tools/Makefile.win
##########
@@ -178,6 +178,8 @@ BIN = $(NUTTXNAME)$(EXEEXT)
all: $(BIN)
.PHONY: dirlinks context clean_context check_context configenv config oldconfig menuconfig nconfig export subdir_clean clean subdir_distclean distclean apps_clean apps_distclean
+.PHONY: pass1 pass1deps pass1dep
+.PHONY: pass2 pass2deps pass2dep
Review comment:
let's merge into one line since line 180 is alrady very long.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services