You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@couchdb.apache.org by "Glenn Rempe (JIRA)" <ji...@apache.org> on 2009/11/05 21:18:32 UTC
[jira] Created: (COUCHDB-563) Typo in couch_view_updater.erl
Typo in couch_view_updater.erl
------------------------------
Key: COUCHDB-563
URL: https://issues.apache.org/jira/browse/COUCHDB-563
Project: CouchDB
Issue Type: Bug
Components: Database Core
Affects Versions: 0.11
Reporter: Glenn Rempe
Priority: Minor
There is a typo on three lines in couch_view_updater.erl where the Var name 'IntitalBuild' should be 'InitialBuild'
diff --git a/src/couchdb/couch_view_updater.erl
b/src/couchdb/couch_view_updater.erl
index 6f04d93..475f59a 100644
--- a/src/couchdb/couch_view_updater.erl
+++ b/src/couchdb/couch_view_updater.erl
@@ -137,7 +137,7 @@ do_maps(Group, MapQueue, WriteQueue, ViewEmptyKVs) ->
do_maps(Group1, MapQueue, WriteQueue, ViewEmptyKVs)
end.
-do_writes(Parent, Owner, Group, WriteQueue, IntitalBuild) ->
+do_writes(Parent, Owner, Group, WriteQueue, InitialBuild) ->
case couch_work_queue:dequeue(WriteQueue) of
closed ->
Parent ! {new_group, Group};
@@ -155,12 +155,12 @@ do_writes(Parent, Owner, Group, WriteQueue,
IntitalBuild) ->
AccViewKVs2, DocIdViewIdKeys ++ AccDocIdViewIdKeys}
end, nil, Queue),
Group2 = write_changes(Group, ViewKeyValues, DocIdViewIdKeys, NewSeq,
- IntitalBuild),
+ InitialBuild),
case Owner of
nil -> ok;
_ -> ok = gen_server:cast(Owner, {partial_update, Parent, Group2})
end,
- do_writes(Parent, Owner, Group2, WriteQueue, IntitalBuild)
+ do_writes(Parent, Owner, Group2, WriteQueue, InitialBuild)
end.
view_insert_query_results([], [], ViewKVs, DocIdViewIdKeysAcc) ->
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
Re: [jira] Closed: (COUCHDB-563) Typo in couch_view_updater.erl
Posted by Paul Joseph Davis <pa...@gmail.com>.
Oops, sorry for forgetting to close that out.
On Nov 21, 2009, at 12:22 PM, "Adam Kocoloski (JIRA)"
<ji...@apache.org> wrote:
>
> [ https://issues.apache.org/jira/browse/COUCHDB-563?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
> ]
>
> Adam Kocoloski closed COUCHDB-563.
> ----------------------------------
>
> Resolution: Fixed
> Assignee: Paul Joseph Davis
>
> fixed by davisp in r880951
>
>> Typo in couch_view_updater.erl
>> ------------------------------
>>
>> Key: COUCHDB-563
>> URL: https://issues.apache.org/jira/browse/COUCHDB-563
>> Project: CouchDB
>> Issue Type: Bug
>> Components: Database Core
>> Affects Versions: 0.11
>> Reporter: Glenn Rempe
>> Assignee: Paul Joseph Davis
>> Priority: Minor
>>
>> There is a typo on three lines in couch_view_updater.erl where the
>> Var name 'IntitalBuild' should be 'InitialBuild'
>> diff --git a/src/couchdb/couch_view_updater.erl
>> b/src/couchdb/couch_view_updater.erl
>> index 6f04d93..475f59a 100644
>> --- a/src/couchdb/couch_view_updater.erl
>> +++ b/src/couchdb/couch_view_updater.erl
>> @@ -137,7 +137,7 @@ do_maps(Group, MapQueue, WriteQueue,
>> ViewEmptyKVs) ->
>> do_maps(Group1, MapQueue, WriteQueue, ViewEmptyKVs)
>> end.
>> -do_writes(Parent, Owner, Group, WriteQueue, IntitalBuild) ->
>> +do_writes(Parent, Owner, Group, WriteQueue, InitialBuild) ->
>> case couch_work_queue:dequeue(WriteQueue) of
>> closed ->
>> Parent ! {new_group, Group};
>> @@ -155,12 +155,12 @@ do_writes(Parent, Owner, Group, WriteQueue,
>> IntitalBuild) ->
>> AccViewKVs2, DocIdViewIdKeys ++
>> AccDocIdViewIdKeys}
>> end, nil, Queue),
>> Group2 = write_changes(Group, ViewKeyValues,
>> DocIdViewIdKeys, NewSeq,
>> - IntitalBuild),
>> + InitialBuild),
>> case Owner of
>> nil -> ok;
>> _ -> ok = gen_server:cast(Owner, {partial_update, Parent,
>> Group2})
>> end,
>> - do_writes(Parent, Owner, Group2, WriteQueue, IntitalBuild)
>> + do_writes(Parent, Owner, Group2, WriteQueue, InitialBuild)
>> end.
>> view_insert_query_results([], [], ViewKVs, DocIdViewIdKeysAcc) ->
>
> --
> This message is automatically generated by JIRA.
> -
> You can reply to this email to add a comment to the issue online.
>
[jira] Closed: (COUCHDB-563) Typo in couch_view_updater.erl
Posted by "Adam Kocoloski (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/COUCHDB-563?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Adam Kocoloski closed COUCHDB-563.
----------------------------------
Resolution: Fixed
Assignee: Paul Joseph Davis
fixed by davisp in r880951
> Typo in couch_view_updater.erl
> ------------------------------
>
> Key: COUCHDB-563
> URL: https://issues.apache.org/jira/browse/COUCHDB-563
> Project: CouchDB
> Issue Type: Bug
> Components: Database Core
> Affects Versions: 0.11
> Reporter: Glenn Rempe
> Assignee: Paul Joseph Davis
> Priority: Minor
>
> There is a typo on three lines in couch_view_updater.erl where the Var name 'IntitalBuild' should be 'InitialBuild'
> diff --git a/src/couchdb/couch_view_updater.erl
> b/src/couchdb/couch_view_updater.erl
> index 6f04d93..475f59a 100644
> --- a/src/couchdb/couch_view_updater.erl
> +++ b/src/couchdb/couch_view_updater.erl
> @@ -137,7 +137,7 @@ do_maps(Group, MapQueue, WriteQueue, ViewEmptyKVs) ->
> do_maps(Group1, MapQueue, WriteQueue, ViewEmptyKVs)
> end.
> -do_writes(Parent, Owner, Group, WriteQueue, IntitalBuild) ->
> +do_writes(Parent, Owner, Group, WriteQueue, InitialBuild) ->
> case couch_work_queue:dequeue(WriteQueue) of
> closed ->
> Parent ! {new_group, Group};
> @@ -155,12 +155,12 @@ do_writes(Parent, Owner, Group, WriteQueue,
> IntitalBuild) ->
> AccViewKVs2, DocIdViewIdKeys ++ AccDocIdViewIdKeys}
> end, nil, Queue),
> Group2 = write_changes(Group, ViewKeyValues, DocIdViewIdKeys, NewSeq,
> - IntitalBuild),
> + InitialBuild),
> case Owner of
> nil -> ok;
> _ -> ok = gen_server:cast(Owner, {partial_update, Parent, Group2})
> end,
> - do_writes(Parent, Owner, Group2, WriteQueue, IntitalBuild)
> + do_writes(Parent, Owner, Group2, WriteQueue, InitialBuild)
> end.
> view_insert_query_results([], [], ViewKVs, DocIdViewIdKeysAcc) ->
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.