You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2019/07/21 06:37:51 UTC

[GitHub] [pulsar] sijie commented on a change in pull request #4768: Expose acknowledgment flushing capabilities at the consumer level

sijie commented on a change in pull request #4768: Expose acknowledgment flushing capabilities at the consumer level
URL: https://github.com/apache/pulsar/pull/4768#discussion_r305603273
 
 

 ##########
 File path: pulsar-client/src/main/java/org/apache/pulsar/client/impl/MultiTopicsConsumerImpl.java
 ##########
 @@ -421,6 +421,13 @@ public void negativeAcknowledge(MessageId messageId) {
         ConsumerImpl<T> consumer = consumers.get(topicMessageId.getTopicPartitionName());
         consumer.negativeAcknowledge(topicMessageId.getInnerMessageId());
     }
+    
+    @Override
+    public void flushAcknowledgements() {
+    	for (ConsumerImpl<T> consumer : consumers.values()) {
+    		consumer.flushAcknowledgements();
 
 Review comment:
   wrong indent.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services