You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by Yujie Li <ry...@gmail.com> on 2017/06/01 20:15:14 UTC
Review Request 59725: RANGER-1627: Tagsync should also be able to
support pid file name customization like admin and usersync
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59725/
-----------------------------------------------------------
Review request for ranger.
Bugs: RANGER-1627
https://issues.apache.org/jira/browse/RANGER-1627
Repository: ranger
Description
-------
Tagsync should also be able to support pid file name customization. Similar to RANGER-1575 and RANGER-1614, Ranger Tagsync should support the same new feature just like Admin and Usersync.
Diffs
-----
tagsync/scripts/ranger-tagsync-services.sh 9a723163
Diff: https://reviews.apache.org/r/59725/diff/1/
Testing
-------
Thanks,
Yujie Li
Re: Review Request 59725: RANGER-1627: Tagsync should also be able to
support pid file name customization like admin and usersync
Posted by Colm O hEigeartaigh <co...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59725/#review177005
-----------------------------------------------------------
Ship it!
Ship It!
- Colm O hEigeartaigh
On June 2, 2017, 6:14 p.m., Yujie Li wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59725/
> -----------------------------------------------------------
>
> (Updated June 2, 2017, 6:14 p.m.)
>
>
> Review request for ranger.
>
>
> Bugs: RANGER-1627
> https://issues.apache.org/jira/browse/RANGER-1627
>
>
> Repository: ranger
>
>
> Description
> -------
>
> Tagsync should also be able to support pid file name customization. Similar to RANGER-1575 and RANGER-1614, Ranger Tagsync should support the same new feature just like Admin and Usersync.
>
>
> Diffs
> -----
>
> tagsync/scripts/ranger-tagsync-services.sh 9a723163
>
>
> Diff: https://reviews.apache.org/r/59725/diff/2/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Yujie Li
>
>
Re: Review Request 59725: RANGER-1627: Tagsync should also be able to
support pid file name customization like admin and usersync
Posted by Yujie Li <ry...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59725/
-----------------------------------------------------------
(Updated June 2, 2017, 6:14 p.m.)
Review request for ranger.
Bugs: RANGER-1627
https://issues.apache.org/jira/browse/RANGER-1627
Repository: ranger
Description
-------
Tagsync should also be able to support pid file name customization. Similar to RANGER-1575 and RANGER-1614, Ranger Tagsync should support the same new feature just like Admin and Usersync.
Diffs (updated)
-----
tagsync/scripts/ranger-tagsync-services.sh 9a723163
Diff: https://reviews.apache.org/r/59725/diff/2/
Changes: https://reviews.apache.org/r/59725/diff/1-2/
Testing
-------
Thanks,
Yujie Li
Re: Review Request 59725: RANGER-1627: Tagsync should also be able to
support pid file name customization like admin and usersync
Posted by Yujie Li <ry...@gmail.com>.
> On June 2, 2017, 2:46 p.m., Colm O hEigeartaigh wrote:
> > I think you're missing a "$" here:
> >
> > pidf=${TAGSYNC_PID_DIR_PATH}/{TAGSYNC_PID_NAME}
Thanks for pointing out! I have updated the patch!
- Yujie
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59725/#review176777
-----------------------------------------------------------
On June 2, 2017, 6:14 p.m., Yujie Li wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59725/
> -----------------------------------------------------------
>
> (Updated June 2, 2017, 6:14 p.m.)
>
>
> Review request for ranger.
>
>
> Bugs: RANGER-1627
> https://issues.apache.org/jira/browse/RANGER-1627
>
>
> Repository: ranger
>
>
> Description
> -------
>
> Tagsync should also be able to support pid file name customization. Similar to RANGER-1575 and RANGER-1614, Ranger Tagsync should support the same new feature just like Admin and Usersync.
>
>
> Diffs
> -----
>
> tagsync/scripts/ranger-tagsync-services.sh 9a723163
>
>
> Diff: https://reviews.apache.org/r/59725/diff/2/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Yujie Li
>
>
Re: Review Request 59725: RANGER-1627: Tagsync should also be able to
support pid file name customization like admin and usersync
Posted by Colm O hEigeartaigh <co...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59725/#review176777
-----------------------------------------------------------
I think you're missing a "$" here:
pidf=${TAGSYNC_PID_DIR_PATH}/{TAGSYNC_PID_NAME}
- Colm O hEigeartaigh
On June 1, 2017, 8:15 p.m., Yujie Li wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59725/
> -----------------------------------------------------------
>
> (Updated June 1, 2017, 8:15 p.m.)
>
>
> Review request for ranger.
>
>
> Bugs: RANGER-1627
> https://issues.apache.org/jira/browse/RANGER-1627
>
>
> Repository: ranger
>
>
> Description
> -------
>
> Tagsync should also be able to support pid file name customization. Similar to RANGER-1575 and RANGER-1614, Ranger Tagsync should support the same new feature just like Admin and Usersync.
>
>
> Diffs
> -----
>
> tagsync/scripts/ranger-tagsync-services.sh 9a723163
>
>
> Diff: https://reviews.apache.org/r/59725/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Yujie Li
>
>