[GitHub] [cassandra] dcapwell commented on a change in pull request #706: CASSANDRA-16003 Improve tooling stdErr checks

[GitBox <gi...@apache.org>]

dcapwell commented on a change in pull request #706:
URL: https://github.com/apache/cassandra/pull/706#discussion_r463815976



##########
File path: test/unit/org/apache/cassandra/tools/ToolRunner.java
##########
@@ -330,12 +330,21 @@ public ToolRunner waitAndAssertOnExitCode()
     
     public ToolRunner waitAndAssertOnCleanExit()
     {
-        return waitAndAssertOnExitCode().assertEmptyStdErr();
+        return waitAndAssertOnExitCode().assertCleanStdErr();
     }
     
-    public ToolRunner assertEmptyStdErr()
+    /**
+     * Checks if the stdErr is empty after removing any JVM env info output
+     * 
+     * Some JVM configs may output env info on stdErr. We need to remove those to see what was the tool's actual stdErr
+     * 
+     * @return
+     */
+    public ToolRunner assertCleanStdErr()

Review comment:
       Thanks for this!
   
   To help make this more extendable, it would be good to use a exclude list and filter based off that; this is what happens in python dtests (example: https://github.com/riptano/ccm/blob/master/ccmlib/node.py#L395-L421) today.
   
   With an exclude list, we can add more cases by default over time, but can also let tests control and search for the logs they care about.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org