You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ratis.apache.org by "sadanand48 (via GitHub)" <gi...@apache.org> on 2024/08/01 05:52:55 UTC
[PR] RATIS-2133. Include netty-proxy-handler dependency in the project. [ratis-thirdparty]
sadanand48 opened a new pull request, #53:
URL: https://github.com/apache/ratis-thirdparty/pull/53
netty-proxy-handler artifact is required to handle cases where http proxy is configured in an application .
Currently it is excluded from the misc jar. This caused issues in Ozone -> https://issues.apache.org/jira/browse/HDDS-11257.
https://issues.apache.org/jira/browse/RATIS-2133
Before the fix:
```bash
misc % mvn help:effective-pom | grep "netty-handler-proxy"
<artifactId>netty-handler-proxy</artifactId>
<exclude>io.netty:netty-handler-proxy</exclude>
```
After the fix
```bash
misc % mvn help:effective-pom | grep "netty-handler-proxy"
<artifactId>netty-handler-proxy</artifactId>
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ratis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] RATIS-2133. Include netty-proxy-handler dependency in the project. [ratis-thirdparty]
Posted by "szetszwo (via GitHub)" <gi...@apache.org>.
szetszwo closed pull request #53: RATIS-2133. Include netty-proxy-handler dependency in the project.
URL: https://github.com/apache/ratis-thirdparty/pull/53
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ratis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] RATIS-2133. Include netty-proxy-handler dependency in the project. [ratis-thirdparty]
Posted by "sadanand48 (via GitHub)" <gi...@apache.org>.
sadanand48 commented on PR #53:
URL: https://github.com/apache/ratis-thirdparty/pull/53#issuecomment-2262239203
Got it. Thanks for explaining.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ratis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] RATIS-2133. Include netty-proxy-handler dependency in the project. [ratis-thirdparty]
Posted by "adoroszlai (via GitHub)" <gi...@apache.org>.
adoroszlai commented on PR #53:
URL: https://github.com/apache/ratis-thirdparty/pull/53#issuecomment-2262233350
I mean we should change Ratis to ignore any HTTP proxy. It would apply to Ratis client-server traffic, and Ratis server-server traffic. It wouldn't affect traffic from HTTP client to HttpFS server (which doesn't involve Ratis).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ratis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] RATIS-2133. Include netty-proxy-handler dependency in the project. [ratis-thirdparty]
Posted by "sadanand48 (via GitHub)" <gi...@apache.org>.
sadanand48 commented on PR #53:
URL: https://github.com/apache/ratis-thirdparty/pull/53#issuecomment-2262102093
@adoroszlai, Could you please review?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ratis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] RATIS-2133. Include netty-proxy-handler dependency in the project. [ratis-thirdparty]
Posted by "adoroszlai (via GitHub)" <gi...@apache.org>.
adoroszlai commented on PR #53:
URL: https://github.com/apache/ratis-thirdparty/pull/53#issuecomment-2262185028
Thanks @sadanand48 for the patch. Shouldn't Ratis avoid using proxy for gRPC/Netty? HTTP proxy is usually for accessing the "internet". All Ratis traffic going through the proxy will be a serious bottleneck.
CC @szetszwo
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ratis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] RATIS-2133. Include netty-proxy-handler dependency in the project. [ratis-thirdparty]
Posted by "sadanand48 (via GitHub)" <gi...@apache.org>.
sadanand48 commented on PR #53:
URL: https://github.com/apache/ratis-thirdparty/pull/53#issuecomment-2262209705
> Shouldn't Ratis avoid using proxy for gRPC/Netty? HTTP proxy is usually for accessing the "internet".
I'm not sure about the use case for http proxy for the detected error case. I can think of HttpFS where client wants to set up a proxy to route all requests through it. Is it a valid case? In this case how can we route only selective traffic through proxy
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ratis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] RATIS-2133. Include netty-proxy-handler dependency in the project. [ratis-thirdparty]
Posted by "szetszwo (via GitHub)" <gi...@apache.org>.
szetszwo commented on PR #53:
URL: https://github.com/apache/ratis-thirdparty/pull/53#issuecomment-2263363744
[#1128](https://github.com/apache/ratis/pull/1128) is merged. Closing this ...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ratis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org