You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "sarutak (via GitHub)" <gi...@apache.org> on 2023/07/11 18:45:55 UTC

[GitHub] [spark] sarutak commented on a diff in pull request #41891: [SPARK-44334][SQL][UI] Status of execution w/ error and w/o jobs shall be FAILED not COMPLETED in SqlResource

sarutak commented on code in PR #41891:
URL: https://github.com/apache/spark/pull/41891#discussion_r1260139758


##########
sql/core/src/test/scala/org/apache/spark/status/api/v1/sql/SqlResourceSuite.scala:
##########
@@ -204,4 +203,25 @@ class SqlResourceSuite extends SparkFunSuite with PrivateMethodTester {
     assert(wholeStageCodegenId == Some(1))
   }
 
+  test("Status of execution w/ error and w/o jobs shall be FAILED not COMPLETED") {

Review Comment:
   Could you prepend `SPARK-44334: ` to the test name?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org