You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/07/27 06:39:21 UTC
[GitHub] [doris] wangbo opened a new pull request, #11246: [WIP](optional) using hash set to distinct single value
wangbo opened a new pull request, #11246:
URL: https://github.com/apache/doris/pull/11246
# Proposed changes
Issue Number: close #xxx
## Problem Summary:
## Checklist(Required)
1. Type of your changes:
- [ ] Improvement
- [ ] Fix
- [x] Feature-WIP
- [ ] Feature
- [ ] Doc
- [ ] Refator
- [ ] Others:
2. Does it affect the original behavior:
- [ ] Yes
- [x] No
- [ ] I don't know
3. Has unit tests been added:
- [ ] Yes
- [ ] No
- [ x] No Need
4. Has document been added or modified:
- [ ] Yes
- [ ] No
- [ x] No Need
5. Does it need to update dependencies:
- [ ] Yes
- [ ] No
6. Are there any changes that cannot be rolled back:
- [ ] Yes
- [ ] No
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] yiguolei merged pull request #11246: [WIP](optional) using hash set to distinct single value
Posted by GitBox <gi...@apache.org>.
yiguolei merged PR #11246:
URL: https://github.com/apache/doris/pull/11246
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] morrySnow commented on a diff in pull request #11246: [WIP](optional) using hash set to distinct single value
Posted by GitBox <gi...@apache.org>.
morrySnow commented on code in PR #11246:
URL: https://github.com/apache/doris/pull/11246#discussion_r930692117
##########
fe/fe-core/src/main/java/org/apache/doris/analysis/AggregateInfo.java:
##########
@@ -283,6 +285,12 @@ public static boolean estimateIfContainsMultiDistinct(List<FunctionCallExpr> dis
hasMultiDistinct = true;
}
}
+
+ // for vectorized execution, we force it to using hash set to execution
+ if (!hasMultiDistinct && distinctAggExprs.size() == 1 && distinctAggExprs.get(0).getFnParams().isDistinct()
+ && VectorizedUtil.isVectorized() && ConnectContext.get().getSessionVariable().enableSingleDistinctColumnOpt()) {
+ hasMultiDistinct = true;
Review Comment:
nit: if we use 2 stage aggregate for one distinct aggregate, maybe we should change function name and variable name to get a better description of what's actually being done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #11246: [WIP](optional) using hash set to distinct single value
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #11246:
URL: https://github.com/apache/doris/pull/11246#issuecomment-1203600262
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org