You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zookeeper.apache.org by "Patrick Hunt (JIRA)" <ji...@apache.org> on 2009/04/15 18:04:14 UTC
[jira] Created: (ZOOKEEPER-375) zoo_add_auth only retains most
recent auth on re-sync
zoo_add_auth only retains most recent auth on re-sync
-----------------------------------------------------
Key: ZOOKEEPER-375
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-375
Project: Zookeeper
Issue Type: Bug
Components: c client
Affects Versions: 3.1.1, 3.1.0
Reporter: Patrick Hunt
Priority: Critical
Fix For: 3.2.0
zoo_add_auth doesn't maintain a list of auths - it only stores the most recent auth send to the server. As a result on re-sync to the cluster it will lose (not reregister) any auths prior to the most recent.
This code should maintain a list of auths similar to the java code. Be sure to free the memory in close.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-375) zoo_add_auth only retains most
recent auth on re-sync
Posted by "Patrick Hunt (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-375?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12713662#action_12713662 ]
Patrick Hunt commented on ZOOKEEPER-375:
----------------------------------------
have 2 servers, connect client to a server, add auth, create node add another auth, shutdown the server that the client is using, client
will switch to the other server, verify correct auth.
> zoo_add_auth only retains most recent auth on re-sync
> -----------------------------------------------------
>
> Key: ZOOKEEPER-375
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-375
> Project: Zookeeper
> Issue Type: Bug
> Components: c client
> Affects Versions: 3.1.0, 3.1.1
> Reporter: Patrick Hunt
> Assignee: Mahadev konar
> Priority: Critical
> Fix For: 3.2.0
>
> Attachments: ZOOKEEPER-375.patch
>
>
> zoo_add_auth doesn't maintain a list of auths - it only stores the most recent auth send to the server. As a result on re-sync to the cluster it will lose (not reregister) any auths prior to the most recent.
> This code should maintain a list of auths similar to the java code. Be sure to free the memory in close.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-375) zoo_add_auth only retains most
recent auth on re-sync
Posted by "Mahadev konar (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-375?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mahadev konar updated ZOOKEEPER-375:
------------------------------------
Status: Patch Available (was: Open)
> zoo_add_auth only retains most recent auth on re-sync
> -----------------------------------------------------
>
> Key: ZOOKEEPER-375
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-375
> Project: Zookeeper
> Issue Type: Bug
> Components: c client
> Affects Versions: 3.1.1, 3.1.0
> Reporter: Patrick Hunt
> Assignee: Mahadev konar
> Priority: Blocker
> Fix For: 3.2.0
>
> Attachments: ZOOKEEPER-375.patch, ZOOKEEPER-375.patch
>
>
> zoo_add_auth doesn't maintain a list of auths - it only stores the most recent auth send to the server. As a result on re-sync to the cluster it will lose (not reregister) any auths prior to the most recent.
> This code should maintain a list of auths similar to the java code. Be sure to free the memory in close.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-375) zoo_add_auth only retains most
recent auth on re-sync
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-375?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12714657#action_12714657 ]
Hadoop QA commented on ZOOKEEPER-375:
-------------------------------------
+1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12409425/ZOOKEEPER-375.patch
against trunk revision 780122.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 3 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-vesta.apache.org/95/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-vesta.apache.org/95/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-vesta.apache.org/95/console
This message is automatically generated.
> zoo_add_auth only retains most recent auth on re-sync
> -----------------------------------------------------
>
> Key: ZOOKEEPER-375
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-375
> Project: Zookeeper
> Issue Type: Bug
> Components: c client
> Affects Versions: 3.1.0, 3.1.1
> Reporter: Patrick Hunt
> Assignee: Mahadev konar
> Priority: Blocker
> Fix For: 3.2.0
>
> Attachments: ZOOKEEPER-375.patch, ZOOKEEPER-375.patch
>
>
> zoo_add_auth doesn't maintain a list of auths - it only stores the most recent auth send to the server. As a result on re-sync to the cluster it will lose (not reregister) any auths prior to the most recent.
> This code should maintain a list of auths similar to the java code. Be sure to free the memory in close.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-375) zoo_add_auth only retains most
recent auth on re-sync
Posted by "Mahadev konar (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-375?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mahadev konar updated ZOOKEEPER-375:
------------------------------------
Status: Patch Available (was: Open)
> zoo_add_auth only retains most recent auth on re-sync
> -----------------------------------------------------
>
> Key: ZOOKEEPER-375
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-375
> Project: Zookeeper
> Issue Type: Bug
> Components: c client
> Affects Versions: 3.1.1, 3.1.0
> Reporter: Patrick Hunt
> Assignee: Mahadev konar
> Priority: Blocker
> Fix For: 3.2.0
>
> Attachments: ZOOKEEPER-375.patch, ZOOKEEPER-375.patch, ZOOKEEPER-375.patch
>
>
> zoo_add_auth doesn't maintain a list of auths - it only stores the most recent auth send to the server. As a result on re-sync to the cluster it will lose (not reregister) any auths prior to the most recent.
> This code should maintain a list of auths similar to the java code. Be sure to free the memory in close.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-375) zoo_add_auth only retains most
recent auth on re-sync
Posted by "Mahadev konar (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-375?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mahadev konar updated ZOOKEEPER-375:
------------------------------------
Resolution: Fixed
Status: Resolved (was: Patch Available)
I just committed this.
> zoo_add_auth only retains most recent auth on re-sync
> -----------------------------------------------------
>
> Key: ZOOKEEPER-375
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-375
> Project: Zookeeper
> Issue Type: Bug
> Components: c client
> Affects Versions: 3.1.0, 3.1.1
> Reporter: Patrick Hunt
> Assignee: Mahadev konar
> Priority: Blocker
> Fix For: 3.2.0
>
> Attachments: ZOOKEEPER-375.patch, ZOOKEEPER-375.patch, ZOOKEEPER-375.patch
>
>
> zoo_add_auth doesn't maintain a list of auths - it only stores the most recent auth send to the server. As a result on re-sync to the cluster it will lose (not reregister) any auths prior to the most recent.
> This code should maintain a list of auths similar to the java code. Be sure to free the memory in close.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-375) zoo_add_auth only retains most
recent auth on re-sync
Posted by "Mahadev konar (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-375?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12714616#action_12714616 ]
Mahadev konar commented on ZOOKEEPER-375:
-----------------------------------------
the test is done with a single server wherein a client authenticates with the 2 auths, the first one being the required one, and after a restart of the sevrer, the client is able to authenticate itself.
> zoo_add_auth only retains most recent auth on re-sync
> -----------------------------------------------------
>
> Key: ZOOKEEPER-375
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-375
> Project: Zookeeper
> Issue Type: Bug
> Components: c client
> Affects Versions: 3.1.0, 3.1.1
> Reporter: Patrick Hunt
> Assignee: Mahadev konar
> Priority: Blocker
> Fix For: 3.2.0
>
> Attachments: ZOOKEEPER-375.patch, ZOOKEEPER-375.patch
>
>
> zoo_add_auth doesn't maintain a list of auths - it only stores the most recent auth send to the server. As a result on re-sync to the cluster it will lose (not reregister) any auths prior to the most recent.
> This code should maintain a list of auths similar to the java code. Be sure to free the memory in close.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-375) zoo_add_auth only retains most
recent auth on re-sync
Posted by "Patrick Hunt (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-375?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Patrick Hunt updated ZOOKEEPER-375:
-----------------------------------
Priority: Blocker (was: Critical)
> zoo_add_auth only retains most recent auth on re-sync
> -----------------------------------------------------
>
> Key: ZOOKEEPER-375
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-375
> Project: Zookeeper
> Issue Type: Bug
> Components: c client
> Affects Versions: 3.1.0, 3.1.1
> Reporter: Patrick Hunt
> Assignee: Mahadev konar
> Priority: Blocker
> Fix For: 3.2.0
>
> Attachments: ZOOKEEPER-375.patch
>
>
> zoo_add_auth doesn't maintain a list of auths - it only stores the most recent auth send to the server. As a result on re-sync to the cluster it will lose (not reregister) any auths prior to the most recent.
> This code should maintain a list of auths similar to the java code. Be sure to free the memory in close.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-375) zoo_add_auth only retains most
recent auth on re-sync
Posted by "Mahadev konar (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-375?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mahadev konar updated ZOOKEEPER-375:
------------------------------------
Status: Open (was: Patch Available)
retrying hudson again..
> zoo_add_auth only retains most recent auth on re-sync
> -----------------------------------------------------
>
> Key: ZOOKEEPER-375
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-375
> Project: Zookeeper
> Issue Type: Bug
> Components: c client
> Affects Versions: 3.1.1, 3.1.0
> Reporter: Patrick Hunt
> Assignee: Mahadev konar
> Priority: Blocker
> Fix For: 3.2.0
>
> Attachments: ZOOKEEPER-375.patch, ZOOKEEPER-375.patch, ZOOKEEPER-375.patch
>
>
> zoo_add_auth doesn't maintain a list of auths - it only stores the most recent auth send to the server. As a result on re-sync to the cluster it will lose (not reregister) any auths prior to the most recent.
> This code should maintain a list of auths similar to the java code. Be sure to free the memory in close.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (ZOOKEEPER-375) zoo_add_auth only retains most
recent auth on re-sync
Posted by "Patrick Hunt (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-375?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Patrick Hunt reassigned ZOOKEEPER-375:
--------------------------------------
Assignee: Mahadev konar
> zoo_add_auth only retains most recent auth on re-sync
> -----------------------------------------------------
>
> Key: ZOOKEEPER-375
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-375
> Project: Zookeeper
> Issue Type: Bug
> Components: c client
> Affects Versions: 3.1.0, 3.1.1
> Reporter: Patrick Hunt
> Assignee: Mahadev konar
> Priority: Critical
> Fix For: 3.2.0
>
>
> zoo_add_auth doesn't maintain a list of auths - it only stores the most recent auth send to the server. As a result on re-sync to the cluster it will lose (not reregister) any auths prior to the most recent.
> This code should maintain a list of auths similar to the java code. Be sure to free the memory in close.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-375) zoo_add_auth only retains most
recent auth on re-sync
Posted by "Mahadev konar (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-375?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mahadev konar updated ZOOKEEPER-375:
------------------------------------
Status: Patch Available (was: Open)
> zoo_add_auth only retains most recent auth on re-sync
> -----------------------------------------------------
>
> Key: ZOOKEEPER-375
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-375
> Project: Zookeeper
> Issue Type: Bug
> Components: c client
> Affects Versions: 3.1.1, 3.1.0
> Reporter: Patrick Hunt
> Assignee: Mahadev konar
> Priority: Blocker
> Fix For: 3.2.0
>
> Attachments: ZOOKEEPER-375.patch, ZOOKEEPER-375.patch, ZOOKEEPER-375.patch
>
>
> zoo_add_auth doesn't maintain a list of auths - it only stores the most recent auth send to the server. As a result on re-sync to the cluster it will lose (not reregister) any auths prior to the most recent.
> This code should maintain a list of auths similar to the java code. Be sure to free the memory in close.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-375) zoo_add_auth only retains most
recent auth on re-sync
Posted by "Mahadev konar (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-375?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mahadev konar updated ZOOKEEPER-375:
------------------------------------
Attachment: ZOOKEEPER-375.patch
this patch fixes the issue and adds atest.
> zoo_add_auth only retains most recent auth on re-sync
> -----------------------------------------------------
>
> Key: ZOOKEEPER-375
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-375
> Project: Zookeeper
> Issue Type: Bug
> Components: c client
> Affects Versions: 3.1.0, 3.1.1
> Reporter: Patrick Hunt
> Assignee: Mahadev konar
> Priority: Blocker
> Fix For: 3.2.0
>
> Attachments: ZOOKEEPER-375.patch, ZOOKEEPER-375.patch
>
>
> zoo_add_auth doesn't maintain a list of auths - it only stores the most recent auth send to the server. As a result on re-sync to the cluster it will lose (not reregister) any auths prior to the most recent.
> This code should maintain a list of auths similar to the java code. Be sure to free the memory in close.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-375) zoo_add_auth only retains most
recent auth on re-sync
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-375?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12717562#action_12717562 ]
Hadoop QA commented on ZOOKEEPER-375:
-------------------------------------
+1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12409940/ZOOKEEPER-375.patch
against trunk revision 782792.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 3 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-vesta.apache.org/110/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-vesta.apache.org/110/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-vesta.apache.org/110/console
This message is automatically generated.
> zoo_add_auth only retains most recent auth on re-sync
> -----------------------------------------------------
>
> Key: ZOOKEEPER-375
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-375
> Project: Zookeeper
> Issue Type: Bug
> Components: c client
> Affects Versions: 3.1.0, 3.1.1
> Reporter: Patrick Hunt
> Assignee: Mahadev konar
> Priority: Blocker
> Fix For: 3.2.0
>
> Attachments: ZOOKEEPER-375.patch, ZOOKEEPER-375.patch, ZOOKEEPER-375.patch
>
>
> zoo_add_auth doesn't maintain a list of auths - it only stores the most recent auth send to the server. As a result on re-sync to the cluster it will lose (not reregister) any auths prior to the most recent.
> This code should maintain a list of auths similar to the java code. Be sure to free the memory in close.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-375) zoo_add_auth only retains most
recent auth on re-sync
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-375?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12718513#action_12718513 ]
Hudson commented on ZOOKEEPER-375:
----------------------------------
Integrated in ZooKeeper-trunk #343 (See [http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/343/])
> zoo_add_auth only retains most recent auth on re-sync
> -----------------------------------------------------
>
> Key: ZOOKEEPER-375
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-375
> Project: Zookeeper
> Issue Type: Bug
> Components: c client
> Affects Versions: 3.1.0, 3.1.1
> Reporter: Patrick Hunt
> Assignee: Mahadev konar
> Priority: Blocker
> Fix For: 3.2.0
>
> Attachments: ZOOKEEPER-375.patch, ZOOKEEPER-375.patch, ZOOKEEPER-375.patch
>
>
> zoo_add_auth doesn't maintain a list of auths - it only stores the most recent auth send to the server. As a result on re-sync to the cluster it will lose (not reregister) any auths prior to the most recent.
> This code should maintain a list of auths similar to the java code. Be sure to free the memory in close.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-375) zoo_add_auth only retains most
recent auth on re-sync
Posted by "Mahadev konar (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-375?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mahadev konar updated ZOOKEEPER-375:
------------------------------------
Status: Open (was: Patch Available)
trying out hudson to see if it likes the patch.
> zoo_add_auth only retains most recent auth on re-sync
> -----------------------------------------------------
>
> Key: ZOOKEEPER-375
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-375
> Project: Zookeeper
> Issue Type: Bug
> Components: c client
> Affects Versions: 3.1.1, 3.1.0
> Reporter: Patrick Hunt
> Assignee: Mahadev konar
> Priority: Blocker
> Fix For: 3.2.0
>
> Attachments: ZOOKEEPER-375.patch, ZOOKEEPER-375.patch, ZOOKEEPER-375.patch
>
>
> zoo_add_auth doesn't maintain a list of auths - it only stores the most recent auth send to the server. As a result on re-sync to the cluster it will lose (not reregister) any auths prior to the most recent.
> This code should maintain a list of auths similar to the java code. Be sure to free the memory in close.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-375) zoo_add_auth only retains most
recent auth on re-sync
Posted by "Benjamin Reed (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-375?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Benjamin Reed updated ZOOKEEPER-375:
------------------------------------
Hadoop Flags: [Reviewed]
+1 looks good. just remove the comment about printing in the loop (since you aren't printing anything) before committing.
> zoo_add_auth only retains most recent auth on re-sync
> -----------------------------------------------------
>
> Key: ZOOKEEPER-375
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-375
> Project: Zookeeper
> Issue Type: Bug
> Components: c client
> Affects Versions: 3.1.0, 3.1.1
> Reporter: Patrick Hunt
> Assignee: Mahadev konar
> Priority: Blocker
> Fix For: 3.2.0
>
> Attachments: ZOOKEEPER-375.patch, ZOOKEEPER-375.patch, ZOOKEEPER-375.patch
>
>
> zoo_add_auth doesn't maintain a list of auths - it only stores the most recent auth send to the server. As a result on re-sync to the cluster it will lose (not reregister) any auths prior to the most recent.
> This code should maintain a list of auths similar to the java code. Be sure to free the memory in close.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-375) zoo_add_auth only retains most
recent auth on re-sync
Posted by "Mahadev konar (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-375?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mahadev konar updated ZOOKEEPER-375:
------------------------------------
Attachment: ZOOKEEPER-375.patch
the last patch missed out on calling the completion functions for authentication. I fixed that in this patch and also added a testcase for that.
> zoo_add_auth only retains most recent auth on re-sync
> -----------------------------------------------------
>
> Key: ZOOKEEPER-375
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-375
> Project: Zookeeper
> Issue Type: Bug
> Components: c client
> Affects Versions: 3.1.0, 3.1.1
> Reporter: Patrick Hunt
> Assignee: Mahadev konar
> Priority: Blocker
> Fix For: 3.2.0
>
> Attachments: ZOOKEEPER-375.patch, ZOOKEEPER-375.patch, ZOOKEEPER-375.patch
>
>
> zoo_add_auth doesn't maintain a list of auths - it only stores the most recent auth send to the server. As a result on re-sync to the cluster it will lose (not reregister) any auths prior to the most recent.
> This code should maintain a list of auths similar to the java code. Be sure to free the memory in close.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-375) zoo_add_auth only retains most
recent auth on re-sync
Posted by "Mahadev konar (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-375?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mahadev konar updated ZOOKEEPER-375:
------------------------------------
Attachment: ZOOKEEPER-375.patch
here's a patch that fixes the issue. not sure how to add a test for this.
> zoo_add_auth only retains most recent auth on re-sync
> -----------------------------------------------------
>
> Key: ZOOKEEPER-375
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-375
> Project: Zookeeper
> Issue Type: Bug
> Components: c client
> Affects Versions: 3.1.0, 3.1.1
> Reporter: Patrick Hunt
> Assignee: Mahadev konar
> Priority: Critical
> Fix For: 3.2.0
>
> Attachments: ZOOKEEPER-375.patch
>
>
> zoo_add_auth doesn't maintain a list of auths - it only stores the most recent auth send to the server. As a result on re-sync to the cluster it will lose (not reregister) any auths prior to the most recent.
> This code should maintain a list of auths similar to the java code. Be sure to free the memory in close.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.