You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@myfaces.apache.org by lo...@apache.org on 2016/09/16 15:02:38 UTC

svn commit: r1761044 - in /myfaces/tobago/trunk: tobago-core/src/main/java/org/apache/myfaces/tobago/ajax/ tobago-core/src/main/java/org/apache/myfaces/tobago/component/ tobago-example/tobago-example-demo/src/main/webapp/content/30-concept/50-partial/ ...

Author: lofwyr
Date: Fri Sep 16 15:02:38 2016
New Revision: 1761044

URL: http://svn.apache.org/viewvc?rev=1761044&view=rev
Log:
TOBAGO-1590: Remove attribute "renderedPartially"
* cleanup

Modified:
    myfaces/tobago/trunk/tobago-core/src/main/java/org/apache/myfaces/tobago/ajax/AjaxUtils.java
    myfaces/tobago/trunk/tobago-core/src/main/java/org/apache/myfaces/tobago/component/Attributes.java
    myfaces/tobago/trunk/tobago-example/tobago-example-demo/src/main/webapp/content/30-concept/50-partial/partial.xhtml
    myfaces/tobago/trunk/tobago-theme/tobago-theme-standard/src/main/java/org/apache/myfaces/tobago/renderkit/html/Command.java
    myfaces/tobago/trunk/tobago-theme/tobago-theme-standard/src/test/java/org/apache/myfaces/tobago/renderkit/html/JsonUtilsUnitTest.java

Modified: myfaces/tobago/trunk/tobago-core/src/main/java/org/apache/myfaces/tobago/ajax/AjaxUtils.java
URL: http://svn.apache.org/viewvc/myfaces/tobago/trunk/tobago-core/src/main/java/org/apache/myfaces/tobago/ajax/AjaxUtils.java?rev=1761044&r1=1761043&r2=1761044&view=diff
==============================================================================
--- myfaces/tobago/trunk/tobago-core/src/main/java/org/apache/myfaces/tobago/ajax/AjaxUtils.java (original)
+++ myfaces/tobago/trunk/tobago-core/src/main/java/org/apache/myfaces/tobago/ajax/AjaxUtils.java Fri Sep 16 15:02:38 2016
@@ -62,11 +62,6 @@ public final class AjaxUtils {
     return org.apache.myfaces.tobago.util.AjaxUtils.getRenderIds(facesContext);
   }
 
-  public static boolean addUIMessagesToRenderedPartially(final FacesContext facesContext) {
-    final String message = "org.apache.myfaces.tobago.ajax.AjaxUtils.addUIMessagesToRenderedPartially";
-    throw new UnsupportedOperationException(message);
-  }
-
   public static boolean redirect(final FacesContext facesContext, final String url) throws IOException {
     return AjaxInternalUtils.redirect(facesContext, url);
   }

Modified: myfaces/tobago/trunk/tobago-core/src/main/java/org/apache/myfaces/tobago/component/Attributes.java
URL: http://svn.apache.org/viewvc/myfaces/tobago/trunk/tobago-core/src/main/java/org/apache/myfaces/tobago/component/Attributes.java?rev=1761044&r1=1761043&r2=1761044&view=diff
==============================================================================
--- myfaces/tobago/trunk/tobago-core/src/main/java/org/apache/myfaces/tobago/component/Attributes.java (original)
+++ myfaces/tobago/trunk/tobago-core/src/main/java/org/apache/myfaces/tobago/component/Attributes.java Fri Sep 16 15:02:38 2016
@@ -192,7 +192,6 @@ public enum Attributes {
   rendered,
   rendererType,
   renderAs,
-  renderedPartially,
   renderRange,
   renderRangeExtern,
   required,

Modified: myfaces/tobago/trunk/tobago-example/tobago-example-demo/src/main/webapp/content/30-concept/50-partial/partial.xhtml
URL: http://svn.apache.org/viewvc/myfaces/tobago/trunk/tobago-example/tobago-example-demo/src/main/webapp/content/30-concept/50-partial/partial.xhtml?rev=1761044&r1=1761043&r2=1761044&view=diff
==============================================================================
--- myfaces/tobago/trunk/tobago-example/tobago-example-demo/src/main/webapp/content/30-concept/50-partial/partial.xhtml (original)
+++ myfaces/tobago/trunk/tobago-example/tobago-example-demo/src/main/webapp/content/30-concept/50-partial/partial.xhtml Fri Sep 16 15:02:38 2016
@@ -86,7 +86,6 @@
           <tc:gridLayout columns="*;*" rows="auto;auto;auto;auto;auto;auto;auto;auto"/>
         </f:facet>
 
-        <!--renderedPartially="left :page:header:headerInfo"-->
         <tc:button label="Reload left" tip="Reload left side box"
                    action="#{partialReloadController.reload}">
           <f:ajax render="left :page:header:headerInfo"/>

Modified: myfaces/tobago/trunk/tobago-theme/tobago-theme-standard/src/main/java/org/apache/myfaces/tobago/renderkit/html/Command.java
URL: http://svn.apache.org/viewvc/myfaces/tobago/trunk/tobago-theme/tobago-theme-standard/src/main/java/org/apache/myfaces/tobago/renderkit/html/Command.java?rev=1761044&r1=1761043&r2=1761044&view=diff
==============================================================================
--- myfaces/tobago/trunk/tobago-theme/tobago-theme-standard/src/main/java/org/apache/myfaces/tobago/renderkit/html/Command.java (original)
+++ myfaces/tobago/trunk/tobago-theme/tobago-theme-standard/src/main/java/org/apache/myfaces/tobago/renderkit/html/Command.java Fri Sep 16 15:02:38 2016
@@ -99,16 +99,9 @@ public class Command {
     if (target != null) {
       this.target = target;
     }
-    // TODO: TOBAGO-1572
-//    if (facetComponent instanceof AbstractUICommand
-//        && ((AbstractUICommand) facetComponent).getRenderedPartially().length > 0) {
-//      setPartially(ComponentUtils.evaluateClientIds(
-//          facesContext, facetComponent, ((UICommand) facetComponent).getRenderedPartially()));
-//    } else {
-      if (focusId != null) {
-        this.focus = focusId;
-      }
-//    }
+    if (focusId != null) {
+      this.focus = focusId;
+    }
 
     final int delay = ComponentUtils.getIntAttribute(facetComponent, Attributes.delay);
     if (delay > 0) {

Modified: myfaces/tobago/trunk/tobago-theme/tobago-theme-standard/src/test/java/org/apache/myfaces/tobago/renderkit/html/JsonUtilsUnitTest.java
URL: http://svn.apache.org/viewvc/myfaces/tobago/trunk/tobago-theme/tobago-theme-standard/src/test/java/org/apache/myfaces/tobago/renderkit/html/JsonUtilsUnitTest.java?rev=1761044&r1=1761043&r2=1761044&view=diff
==============================================================================
--- myfaces/tobago/trunk/tobago-theme/tobago-theme-standard/src/test/java/org/apache/myfaces/tobago/renderkit/html/JsonUtilsUnitTest.java (original)
+++ myfaces/tobago/trunk/tobago-theme/tobago-theme-standard/src/test/java/org/apache/myfaces/tobago/renderkit/html/JsonUtilsUnitTest.java Fri Sep 16 15:02:38 2016
@@ -77,13 +77,12 @@ public class JsonUtilsUnitTest extends A
     Assert.assertEquals(expected, JsonUtils.encode(commandMap));
   }
 
-//  @Test
+  @Test
   public void more() {
     final CommandMap map = new CommandMap();
     final AbstractUICommand command = (AbstractUICommand)
         CreateComponentUtils.createComponent(facesContext, UIButton.COMPONENT_TYPE, RendererTypes.Button, "command");
     ComponentUtils.setAttribute(command, Attributes.popupClose, "immediate");
-//    command.setRenderedPartially(new String[]{"popup"});
 
     map.setClick(new Command(
         "ns:actionId",