You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "ASchmidtGit (via GitHub)" <gi...@apache.org> on 2023/03/09 11:48:41 UTC
[GitHub] [superset] ASchmidtGit opened a new issue, #23315: Bulk select for filters
ASchmidtGit opened a new issue, #23315:
URL: https://github.com/apache/superset/issues/23315
Heyho, is it possible to bulk select / select all values in a filter?
E.g. in my filter for article numbers i type "art-25116", so the filter shows all article numbers starting with "art-50876".
From this point i want to either select all or multiple values but as soon as i click on one the filter resets.
Current behavior:
Behavior i want (gif made from sellerboard):
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] Govindarajan-D commented on issue #23315: Bulk select for filters
Posted by "Govindarajan-D (via GitHub)" <gi...@apache.org>.
Govindarajan-D commented on issue #23315:
URL: https://github.com/apache/superset/issues/23315#issuecomment-1474955404
Hi. I made the change on my local and it works good. When we search and select, the search term doesn't get cleared. But one thing though, after I make selections, if I click on the input box, the search term vanishes and if I select outside, the search term gets added as a new filter.
You can watch the entire gif to see what I am speaking about. Would this be correct behaviour?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] Govindarajan-D commented on issue #23315: Bulk select for filters
Posted by "Govindarajan-D (via GitHub)" <gi...@apache.org>.
Govindarajan-D commented on issue #23315:
URL: https://github.com/apache/superset/issues/23315#issuecomment-1528816070
Thanks @michael-s-molina for working on this! I was stuck for few days on this!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] ASchmidtGit commented on issue #23315: Bulk select for filters
Posted by "ASchmidtGit (via GitHub)" <gi...@apache.org>.
ASchmidtGit commented on issue #23315:
URL: https://github.com/apache/superset/issues/23315#issuecomment-1475893297
@Govindarajan-D Yes, that looks exactly like the behavior im looking for
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] michael-s-molina commented on issue #23315: Bulk select for filters
Posted by "michael-s-molina (via GitHub)" <gi...@apache.org>.
michael-s-molina commented on issue #23315:
URL: https://github.com/apache/superset/issues/23315#issuecomment-1521640192
> @michael-s-molina With respect to this issue, I tried using autoClearSearchValue = false in SelectFilterPlugin.tsx. Previously it worked and I was able to test it and it was fine. But after some new commits, I am not able to make it work again using this. Can you help me on this? Thanks!
Sure. Do you have a PR with your changes?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] Govindarajan-D commented on issue #23315: Bulk select for filters
Posted by "Govindarajan-D (via GitHub)" <gi...@apache.org>.
Govindarajan-D commented on issue #23315:
URL: https://github.com/apache/superset/issues/23315#issuecomment-1471288364
Hi. I am able to do multiselect in the same dropdown instance. I took the most recent build from the website.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] Govindarajan-D commented on issue #23315: Bulk select for filters
Posted by "Govindarajan-D (via GitHub)" <gi...@apache.org>.
Govindarajan-D commented on issue #23315:
URL: https://github.com/apache/superset/issues/23315#issuecomment-1476588548
Let me do more testing to see if everything is ok and create pull request for it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] ASchmidtGit commented on issue #23315: Bulk select for filters
Posted by "ASchmidtGit (via GitHub)" <gi...@apache.org>.
ASchmidtGit commented on issue #23315:
URL: https://github.com/apache/superset/issues/23315#issuecomment-1477436392
Awesome, thank you so much :D
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] ASchmidtGit commented on issue #23315: Bulk select for filters
Posted by "ASchmidtGit (via GitHub)" <gi...@apache.org>.
ASchmidtGit commented on issue #23315:
URL: https://github.com/apache/superset/issues/23315#issuecomment-1471671143
Because you dont search for a value in the filter first.
If i just open the filter dropdown and click on the first items shown i can select multiple items too without the list being resetted.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] Govindarajan-D commented on issue #23315: Bulk select for filters
Posted by "Govindarajan-D (via GitHub)" <gi...@apache.org>.
Govindarajan-D commented on issue #23315:
URL: https://github.com/apache/superset/issues/23315#issuecomment-1471897447
Ok got it. Let me check what I can do for that!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] mrmooon commented on issue #23315: Bulk select for filters
Posted by "mrmooon (via GitHub)" <gi...@apache.org>.
mrmooon commented on issue #23315:
URL: https://github.com/apache/superset/issues/23315#issuecomment-1462626100
Hey! Have you checked the _Can select multiple values_ in the filter configuration? That should allow both defining multiple filters and selecting all values at once.
<img width="334" alt="Screenshot 2023-03-09 at 20 05 23" src="https://user-images.githubusercontent.com/24896223/224129653-d58f2e8c-6990-493e-985e-fbe19c08bbab.png">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] michael-s-molina closed issue #23315: Bulk select for filters
Posted by "michael-s-molina (via GitHub)" <gi...@apache.org>.
michael-s-molina closed issue #23315: Bulk select for filters
URL: https://github.com/apache/superset/issues/23315
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] michael-s-molina commented on issue #23315: Bulk select for filters
Posted by "michael-s-molina (via GitHub)" <gi...@apache.org>.
michael-s-molina commented on issue #23315:
URL: https://github.com/apache/superset/issues/23315#issuecomment-1527880325
> @michael-s-molina With respect to this issue, I tried using autoClearSearchValue = false in SelectFilterPlugin.tsx. Previously it worked and I was able to test it and it was fine. But after some new commits, I am not able to make it work again using this. Can you help me on this? Thanks!
@Govindarajan-D `autoClearSearchValue` should be applied to the `Select` component instead of `SelectFilterPlugin`. Here's a [PR](https://github.com/apache/superset/pull/23869) to implement the requested feature.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] Govindarajan-D commented on issue #23315: Bulk select for filters
Posted by "Govindarajan-D (via GitHub)" <gi...@apache.org>.
Govindarajan-D commented on issue #23315:
URL: https://github.com/apache/superset/issues/23315#issuecomment-1521100782
@michael-s-molina With respect to this issue, I tried using autoClearSearchValue = false in SelectFilterPlugin.tsx. Previously it worked and I was able to test it and it was fine. But after some new commits, I am not able to make it work again using this. Can you help me on this? Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] Govindarajan-D commented on issue #23315: Bulk select for filters
Posted by "Govindarajan-D (via GitHub)" <gi...@apache.org>.
Govindarajan-D commented on issue #23315:
URL: https://github.com/apache/superset/issues/23315#issuecomment-1521821012
No. Actually, I was making changes in my local, but since it didn't work I didn't push it yet. Shall I push the changes?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org