You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@weex.apache.org by kfeagle <gi...@git.apache.org> on 2017/07/05 14:39:52 UTC
[GitHub] incubator-weex pull request #495: + [ios] fix bug if duration is 0 or negati...
GitHub user kfeagle opened a pull request:
https://github.com/apache/incubator-weex/pull/495
+ [ios] fix bug if duration is 0 or negative, animation time is given 0.25
+ [ios] fix bug if duration is 0 or negative, animation time is given 0.25
example
http://dotwe.org/vue/4ac17cab8845cd4a5fd469e930ea9b9e
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/kfeagle/incubator-weex ios-animation-0.15-dev
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-weex/pull/495.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #495
----
commit 08313feeee6b5b4ed1837d9e6982680ae7909606
Author: 齐山 <su...@163.com>
Date: 2017-07-05T14:38:01Z
+ [ios] fix bug if duration is 0 or negative, animation time is given 0.25
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-weex issue #495: + [ios] fix bug if duration is 0 or negative, ani...
Posted by weex-bot <gi...@git.apache.org>.
Github user weex-bot commented on the issue:
https://github.com/apache/incubator-weex/pull/495
<!--
1 failure: This PR modify SD...
2 warning: No Changelog chan..., This PR should up...
1 messages
-->
<table>
<thead>
<tr>
<th width="50"></th>
<th width="100%" data-danger-table="true">Fails</th>
</tr>
</thead>
<tbody><tr>
<td>:no_entry_sign:</td>
<td>This PR modify SDK code. Please add/modify corresponding testcases. If it is ok, please comment about it. Or put '@notdanger' in you commit message.</td>
</tr>
</tbody>
</table>
<table>
<thead>
<tr>
<th width="50"></th>
<th width="100%" data-danger-table="true">Warnings</th>
</tr>
</thead>
<tbody><tr>
<td>:warning:</td>
<td>No Changelog changes!</td>
</tr>
<tr>
<td>:warning:</td>
<td>This PR should update related documents as well. </td>
</tr>
</tbody>
</table>
<table>
<thead>
<tr>
<th width="50"></th>
<th width="100%" data-danger-table="true">Messages</th>
</tr>
</thead>
<tbody><tr>
<td>:book:</td>
<td>According to the blame info, we recommended @bluebird78999 , @cxfeng1 to be the reviewers.</td>
</tr>
</tbody>
</table>
<p align="right">
Generated by :no_entry_sign: <a href="http://github.com/danger/danger-js/">dangerJS</a>
</p>
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-weex pull request #495: + [ios] fix bug if duration is 0 or negati...
Posted by acton393 <gi...@git.apache.org>.
Github user acton393 commented on a diff in the pull request:
https://github.com/apache/incubator-weex/pull/495#discussion_r125835826
--- Diff: ios/sdk/WeexSDK/Sources/Module/WXAnimationModule.m ---
@@ -355,7 +360,14 @@ - (void)_createCAAnimation:(WXAnimationInfo *)info
layer.anchorPoint = CGPointZero;
layer.frame = originFrame;
}
- [layer addAnimation:animation forKey:info.propertyName];
+
+ if(WXFloatEqual(animation.duration, 0) || WXFloatLessThan(animation.duration, 0)){
--- End diff --
may be we can provide more function like lessOrEqualThan and and greatOrEqualThan value, here will be more less code
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-weex pull request #495: + [ios] fix bug if duration is 0 or negati...
Posted by kfeagle <gi...@git.apache.org>.
Github user kfeagle commented on a diff in the pull request:
https://github.com/apache/incubator-weex/pull/495#discussion_r126331389
--- Diff: ios/sdk/WeexSDK/Sources/Module/WXAnimationModule.m ---
@@ -355,7 +360,14 @@ - (void)_createCAAnimation:(WXAnimationInfo *)info
layer.anchorPoint = CGPointZero;
layer.frame = originFrame;
}
- [layer addAnimation:animation forKey:info.propertyName];
+
+ if(WXFloatEqual(animation.duration, 0) || WXFloatLessThan(animation.duration, 0)){
--- End diff --
I use !WXFloatGreaterThan. it only one judgement and no need add method :-)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-weex pull request #495: + [ios] fix bug if duration is 0 or negati...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-weex/pull/495
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---