You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@jena.apache.org by ajs6f <gi...@git.apache.org> on 2015/05/11 17:33:45 UTC
[GitHub] jena pull request: JENA-938: Nonfunctional cleanup in various modu...
GitHub user ajs6f opened a pull request:
https://github.com/apache/jena/pull/60
JENA-938: Nonfunctional cleanup in various modules
Remove some forms of dead code from jena-arq, jena-base, jena-core, jena-csv, jena-iri, an jena-permissions. Includes removals for:
Unthrown checked exceptions
Unnecessary superinterface declarations
Needless typecasts
Unused imports
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ajs6f/jena ExceptionsCleanup1
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/jena/pull/60.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #60
----
commit 6a0c0b396ab606e4f04d8532ac07647a345cce1c
Author: ajs6f <aj...@virginia.edu>
Date: 2015-05-11T15:21:55Z
JENA-938: Nonfunctional cleanup in various modules
Remove some forms of dead code from jena-arq, jena-base, jena-core, jena-csv, jena-iri, an jena-permissions. Includes removals for:
Unthrown checked exceptions
Unnecessary superinterface declarations
Needless typecasts
Unused imports
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] jena pull request: JENA-938: Nonfunctional cleanup in various modu...
Posted by afs <gi...@git.apache.org>.
Github user afs commented on the pull request:
https://github.com/apache/jena/pull/60#issuecomment-101010157
The files in package "thrift/wire" starting `RDF_` are autogenerated by the Thrift code generator. They'll get uncleaned if that's remade. (Thrift code generation is not part of the build to reduce the dependency; the script and master grammar are in jena-arq/Grammar/).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] jena pull request: JENA-938: Nonfunctional cleanup in various modu...
Posted by afs <gi...@git.apache.org>.
Github user afs commented on the pull request:
https://github.com/apache/jena/pull/60#issuecomment-101015106
Yes. (Sorry about assuming that was clear - over-familiarity with the code layout)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] jena pull request: JENA-938: Nonfunctional cleanup in various modu...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/jena/pull/60
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] jena pull request: JENA-938: Nonfunctional cleanup in various modu...
Posted by ajs6f <gi...@git.apache.org>.
Github user ajs6f commented on the pull request:
https://github.com/apache/jena/pull/60#issuecomment-101012864
Yeah, I know what Thrift is, but I have no direct experience with it. I've worked with a few code generating frameworks (mostly for WSDL-related stuff) that gave relatively good clean code and allowed you to put filters in for some amount of customization.
It sounds like that's just not worth the effort here. Shall I back out the changes in that package for this PR?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] jena pull request: JENA-938: Nonfunctional cleanup in various modu...
Posted by ajs6f <gi...@git.apache.org>.
Github user ajs6f commented on the pull request:
https://github.com/apache/jena/pull/60#issuecomment-101011238
Hm. Do you think it's worth taking a look at those Thrift tools to see if I can get them to gen cleaner code? (It has to be said that I've never used Thrift.)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] jena pull request: JENA-938: Nonfunctional cleanup in various modu...
Posted by afs <gi...@git.apache.org>.
Github user afs commented on the pull request:
https://github.com/apache/jena/pull/60#issuecomment-101013671
Please, if it's easy to do that; ditto the javacc overwrites. (sparql_10 are sparql_11 actually code directly from SPARQL spec so anything touching them gets special attention!)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] jena pull request: JENA-938: Nonfunctional cleanup in various modu...
Posted by ajs6f <gi...@git.apache.org>.
Github user ajs6f commented on the pull request:
https://github.com/apache/jena/pull/60#issuecomment-101014513
Okay, I will make that happen, but I'm not sure what you mean by "javacc overwrites". You mean methods `sparql_10` and `sparql_11`?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] jena pull request: JENA-938: Nonfunctional cleanup in various modu...
Posted by afs <gi...@git.apache.org>.
Github user afs commented on the pull request:
https://github.com/apache/jena/pull/60#issuecomment-101212657
Another code generated batch : org/apache/jena/iri/impl/Lexer* are JFlex generated
(these files do all say "autogenerated" in them)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] jena pull request: JENA-938: Nonfunctional cleanup in various modu...
Posted by ajs6f <gi...@git.apache.org>.
Github user ajs6f commented on the pull request:
https://github.com/apache/jena/pull/60#issuecomment-101018624
Okay, I've added two commits that should revert those bad changes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] jena pull request: JENA-938: Nonfunctional cleanup in various modu...
Posted by afs <gi...@git.apache.org>.
Github user afs commented on the pull request:
https://github.com/apache/jena/pull/60#issuecomment-102169543
I've picked out as much material from the PR as I can and applied according to the discussions (so not removing interface declarations when the base type includes it, left exceptions on \@overrides in main code, removed unnecessary exceptions more completely in test code).
I have not handled jena-permissions, a module I know less about. One of the reasons split by module is helpful is that different people tend to look after different modules so one person does not have oversight of all code.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] jena pull request: JENA-938: Nonfunctional cleanup in various modu...
Posted by afs <gi...@git.apache.org>.
Github user afs commented on the pull request:
https://github.com/apache/jena/pull/60#issuecomment-101012215
Thrift is another Apache project. In the Thrift case, all Jena adds the `@SuppressWarnings("all")` at the top. As the warnings also depend on the local compiler settings, its hard for a general code generator to generate clean code. From my experience, that's typical for code generators.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---