You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ant.apache.org by "tomodachi94 (via GitHub)" <gi...@apache.org> on 2024/12/08 07:28:58 UTC
[PR] Upgrade Hamcrest to 3.0 [ant]
tomodachi94 opened a new pull request, #215:
URL: https://github.com/apache/ant/pull/215
If upstream changelogs are to be believed, there are no breaking changes except for:
* The packaging method being changed[1] from several JARs to one JAR.
* An annotation, `org.hamcrest.Factory`, being removed (we don't use it, and upstream says that people should not have been using it externally)
* The minimum version being upgraded to Java 8[2], which is already the case in Ant.
[1]: https://github.com/hamcrest/JavaHamcrest/releases/tag/v2.1
[2]: https://github.com/hamcrest/JavaHamcrest/releases/tag/v3.0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org
Re: [PR] Upgrade Hamcrest to 3.0 [ant]
Posted by "bodewig (via GitHub)" <gi...@apache.org>.
bodewig commented on PR #215:
URL: https://github.com/apache/ant/pull/215#issuecomment-2925135087
Things seem to work with Hamcrest 3, thank you.
Actually the hamcrest jars are checked in into the repository (something that look strange for people today, I know :-), so you need to remove the 1.x jars and add the 3.0 one. And https://github.com/apache/ant/blob/master/lib/optional/LICENSE.hamcrest.txt should be adjusted as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org
Re: [PR] Upgrade Hamcrest to 3.0 [ant]
Posted by "bodewig (via GitHub)" <gi...@apache.org>.
bodewig commented on PR #215:
URL: https://github.com/apache/ant/pull/215#issuecomment-2940848041
> I'm going to take a look at the issue tracker to see if there's anything there that I can help with.
Great. We are not always the quickest people to respond, please don't allow this to discourage you.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org
Re: [PR] Upgrade Hamcrest to 3.0 [ant]
Posted by "bodewig (via GitHub)" <gi...@apache.org>.
bodewig merged PR #215:
URL: https://github.com/apache/ant/pull/215
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org
Re: [PR] Upgrade Hamcrest to 3.0 [ant]
Posted by "tomodachi94 (via GitHub)" <gi...@apache.org>.
tomodachi94 commented on PR #215:
URL: https://github.com/apache/ant/pull/215#issuecomment-2926384856
Pushed both changes as new commits onto this PR's branch. Let me know if you prefer everything to be squashed into one commit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org
Re: [PR] Upgrade Hamcrest to 3.0 [ant]
Posted by "bodewig (via GitHub)" <gi...@apache.org>.
bodewig commented on PR #215:
URL: https://github.com/apache/ant/pull/215#issuecomment-2926680869
thank you
Do you want to be credited inside our CONTRIBUTORS file - and if yes, by which name?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org
Re: [PR] Upgrade Hamcrest to 3.0 [ant]
Posted by "tomodachi94 (via GitHub)" <gi...@apache.org>.
tomodachi94 commented on PR #215:
URL: https://github.com/apache/ant/pull/215#issuecomment-2927799816
Sure, that would be cool ❤️ `Tomodachi94` is fine.
I'm going to take a look at the issue tracker to see if there's anything there that I can help with.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org