You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/01/15 06:09:04 UTC
[GitHub] [spark] mohan3d opened a new pull request #31191: [SPARK-34123][Web UI] optimize spark history summary page loading
mohan3d opened a new pull request #31191:
URL: https://github.com/apache/spark/pull/31191
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
-->
### What changes were proposed in this pull request?
Display history server entries using datatables instead of Mustache + Datatables which proved to be faster and non-blocking for the webpage while searching (using search bar in the page)
### Why are the changes needed?
Small changes in the attempts (entries) and removed part of HTML (Mustache template).
### Does this PR introduce _any_ user-facing change?
Not very sure, but it's not supposed to change the way the page looks rather it changes how entries are displayed.
### How was this patch tested?
Running test, since it's not adding new functionality.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] mohan3d commented on a change in pull request #31191: [SPARK-34123][Web UI] optimize spark history summary page loading
Posted by GitBox <gi...@apache.org>.
mohan3d commented on a change in pull request #31191:
URL: https://github.com/apache/spark/pull/31191#discussion_r558941444
##########
File path: core/src/main/resources/org/apache/spark/ui/static/historypage.js
##########
@@ -165,17 +169,41 @@ $(document).ready(function() {
var completedColumnName = 'completed';
var durationColumnName = 'duration';
var conf = {
+ "data": array,
"columns": [
- {name: 'version'},
- {name: 'appId', type: "appid-numeric"},
- {name: 'appName'},
- {name: attemptIdColumnName},
- {name: startedColumnName},
- {name: completedColumnName},
- {name: durationColumnName, type: "title-numeric"},
- {name: 'user'},
- {name: 'lastUpdated'},
- {name: 'eventLog'},
+ {name: 'version', data: 'version' },
+ {
+ name: 'appId',
+ type: "appid-numeric",
+ data: 'id',
+ render: (id, type, row) => `<span title="${id}"><a href="${row.attemptUrl}">${id}</a></span>`
+ },
+ {name: 'appName', data: 'name' },
+ {
+ name: attemptIdColumnName,
+ data: 'attemptId',
+ render: (attemptId, type, row) => (attemptId ? `<a href="${row.attemptUrl}">${attemptId}</a>` : '')
+ },
+ {name: startedColumnName, data: 'startTime' },
+ {name: completedColumnName, data: 'endTime' },
+ {name: durationColumnName, type: "title-numeric", data: 'duration' },
+ {name: 'user', data: 'sparkUser' },
+ {name: 'lastUpdated', data: 'lastUpdated' },
+ {
+ name: 'eventLog',
+ data: 'log',
+ render: (log, type, row) => `<a href="${log}" class="btn btn-info btn-mini">Download</a>`
+ },
+ ],
+ "aoColumnDefs": [
Review comment:
Before
<img width="1771" alt="dev" src="https://user-images.githubusercontent.com/14618484/104816576-1739e000-5857-11eb-8f39-a2bb9d5a4085.png">
After
<img width="1763" alt="prod" src="https://user-images.githubusercontent.com/14618484/104816581-1acd6700-5857-11eb-8062-d35551d609f4.png">
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] srowen commented on a change in pull request #31191: [SPARK-34123][Web UI] optimize spark history summary page loading
Posted by GitBox <gi...@apache.org>.
srowen commented on a change in pull request #31191:
URL: https://github.com/apache/spark/pull/31191#discussion_r558935353
##########
File path: core/src/main/resources/org/apache/spark/ui/static/historypage.js
##########
@@ -165,17 +169,41 @@ $(document).ready(function() {
var completedColumnName = 'completed';
var durationColumnName = 'duration';
var conf = {
+ "data": array,
"columns": [
- {name: 'version'},
- {name: 'appId', type: "appid-numeric"},
- {name: 'appName'},
- {name: attemptIdColumnName},
- {name: startedColumnName},
- {name: completedColumnName},
- {name: durationColumnName, type: "title-numeric"},
- {name: 'user'},
- {name: 'lastUpdated'},
- {name: 'eventLog'},
+ {name: 'version', data: 'version' },
+ {
+ name: 'appId',
+ type: "appid-numeric",
+ data: 'id',
+ render: (id, type, row) => `<span title="${id}"><a href="${row.attemptUrl}">${id}</a></span>`
+ },
+ {name: 'appName', data: 'name' },
+ {
+ name: attemptIdColumnName,
+ data: 'attemptId',
+ render: (attemptId, type, row) => (attemptId ? `<a href="${row.attemptUrl}">${attemptId}</a>` : '')
+ },
+ {name: startedColumnName, data: 'startTime' },
+ {name: completedColumnName, data: 'endTime' },
+ {name: durationColumnName, type: "title-numeric", data: 'duration' },
+ {name: 'user', data: 'sparkUser' },
+ {name: 'lastUpdated', data: 'lastUpdated' },
+ {
+ name: 'eventLog',
+ data: 'log',
+ render: (log, type, row) => `<a href="${log}" class="btn btn-info btn-mini">Download</a>`
+ },
+ ],
+ "aoColumnDefs": [
Review comment:
OK I see. Does the table look the exact same before and after - there's no visual change? if so I don't think we need screenshots.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] mohan3d commented on a change in pull request #31191: [SPARK-34123][Web UI] optimize spark history summary page loading
Posted by GitBox <gi...@apache.org>.
mohan3d commented on a change in pull request #31191:
URL: https://github.com/apache/spark/pull/31191#discussion_r558934521
##########
File path: core/src/main/resources/org/apache/spark/ui/static/historypage.js
##########
@@ -165,17 +169,41 @@ $(document).ready(function() {
var completedColumnName = 'completed';
var durationColumnName = 'duration';
var conf = {
+ "data": array,
"columns": [
- {name: 'version'},
- {name: 'appId', type: "appid-numeric"},
- {name: 'appName'},
- {name: attemptIdColumnName},
- {name: startedColumnName},
- {name: completedColumnName},
- {name: durationColumnName, type: "title-numeric"},
- {name: 'user'},
- {name: 'lastUpdated'},
- {name: 'eventLog'},
+ {name: 'version', data: 'version' },
+ {
+ name: 'appId',
+ type: "appid-numeric",
+ data: 'id',
+ render: (id, type, row) => `<span title="${id}"><a href="${row.attemptUrl}">${id}</a></span>`
+ },
+ {name: 'appName', data: 'name' },
+ {
+ name: attemptIdColumnName,
+ data: 'attemptId',
+ render: (attemptId, type, row) => (attemptId ? `<a href="${row.attemptUrl}">${attemptId}</a>` : '')
+ },
+ {name: startedColumnName, data: 'startTime' },
+ {name: completedColumnName, data: 'endTime' },
+ {name: durationColumnName, type: "title-numeric", data: 'duration' },
+ {name: 'user', data: 'sparkUser' },
+ {name: 'lastUpdated', data: 'lastUpdated' },
+ {
+ name: 'eventLog',
+ data: 'log',
+ render: (log, type, row) => `<a href="${log}" class="btn btn-info btn-mini">Download</a>`
+ },
+ ],
+ "aoColumnDefs": [
Review comment:
@srowen
This part is the logic, not in the template anymore.
Here what I am trying to do is to change the style of first 3 columns only if hasMultipleAttempts will be set to white background.
Other that this will not have style, hence same logic applied.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] mohan3d removed a comment on pull request #31191: [SPARK-34123][Web UI] optimize spark history summary page loading
Posted by GitBox <gi...@apache.org>.
mohan3d removed a comment on pull request #31191:
URL: https://github.com/apache/spark/pull/31191#issuecomment-761462944
@srowen Can you please help re-testing? failed for non-related issue to the update.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] srowen commented on a change in pull request #31191: [SPARK-34123][Web UI] optimize spark history summary page loading
Posted by GitBox <gi...@apache.org>.
srowen commented on a change in pull request #31191:
URL: https://github.com/apache/spark/pull/31191#discussion_r558933757
##########
File path: core/src/main/resources/org/apache/spark/ui/static/historypage-template.html
##########
@@ -75,26 +75,6 @@
</th>
</thead>
<tbody>
- {{#applications}}
- <tr>
- {{#attempts}}
- <td {{#hasMultipleAttempts}}style="background-color:#fff"{{/hasMultipleAttempts}}>{{version}}</td>
Review comment:
Hm I'm still not seeing this logic?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] mohan3d commented on a change in pull request #31191: [SPARK-34123][Web UI] optimize spark history summary page loading
Posted by GitBox <gi...@apache.org>.
mohan3d commented on a change in pull request #31191:
URL: https://github.com/apache/spark/pull/31191#discussion_r558937351
##########
File path: core/src/main/resources/org/apache/spark/ui/static/historypage.js
##########
@@ -165,17 +169,41 @@ $(document).ready(function() {
var completedColumnName = 'completed';
var durationColumnName = 'duration';
var conf = {
+ "data": array,
"columns": [
- {name: 'version'},
- {name: 'appId', type: "appid-numeric"},
- {name: 'appName'},
- {name: attemptIdColumnName},
- {name: startedColumnName},
- {name: completedColumnName},
- {name: durationColumnName, type: "title-numeric"},
- {name: 'user'},
- {name: 'lastUpdated'},
- {name: 'eventLog'},
+ {name: 'version', data: 'version' },
+ {
+ name: 'appId',
+ type: "appid-numeric",
+ data: 'id',
+ render: (id, type, row) => `<span title="${id}"><a href="${row.attemptUrl}">${id}</a></span>`
+ },
+ {name: 'appName', data: 'name' },
+ {
+ name: attemptIdColumnName,
+ data: 'attemptId',
+ render: (attemptId, type, row) => (attemptId ? `<a href="${row.attemptUrl}">${attemptId}</a>` : '')
+ },
+ {name: startedColumnName, data: 'startTime' },
+ {name: completedColumnName, data: 'endTime' },
+ {name: durationColumnName, type: "title-numeric", data: 'duration' },
+ {name: 'user', data: 'sparkUser' },
+ {name: 'lastUpdated', data: 'lastUpdated' },
+ {
+ name: 'eventLog',
+ data: 'log',
+ render: (log, type, row) => `<a href="${log}" class="btn btn-info btn-mini">Download</a>`
+ },
+ ],
+ "aoColumnDefs": [
Review comment:
Yeah it looks similar, but I will post some photos from prod/dev history servers from my side.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31191: [SPARK-34123][Web UI] optimize spark history summary page loading
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31191:
URL: https://github.com/apache/spark/pull/31191#issuecomment-760688769
Can one of the admins verify this patch?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] mohan3d commented on pull request #31191: [SPARK-34123][Web UI] optimize spark history summary page loading
Posted by GitBox <gi...@apache.org>.
mohan3d commented on pull request #31191:
URL: https://github.com/apache/spark/pull/31191#issuecomment-761463647
Jenkins, retest this please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] mohan3d commented on a change in pull request #31191: [SPARK-34123][Web UI] optimize spark history summary page loading
Posted by GitBox <gi...@apache.org>.
mohan3d commented on a change in pull request #31191:
URL: https://github.com/apache/spark/pull/31191#discussion_r558934521
##########
File path: core/src/main/resources/org/apache/spark/ui/static/historypage.js
##########
@@ -165,17 +169,41 @@ $(document).ready(function() {
var completedColumnName = 'completed';
var durationColumnName = 'duration';
var conf = {
+ "data": array,
"columns": [
- {name: 'version'},
- {name: 'appId', type: "appid-numeric"},
- {name: 'appName'},
- {name: attemptIdColumnName},
- {name: startedColumnName},
- {name: completedColumnName},
- {name: durationColumnName, type: "title-numeric"},
- {name: 'user'},
- {name: 'lastUpdated'},
- {name: 'eventLog'},
+ {name: 'version', data: 'version' },
+ {
+ name: 'appId',
+ type: "appid-numeric",
+ data: 'id',
+ render: (id, type, row) => `<span title="${id}"><a href="${row.attemptUrl}">${id}</a></span>`
+ },
+ {name: 'appName', data: 'name' },
+ {
+ name: attemptIdColumnName,
+ data: 'attemptId',
+ render: (attemptId, type, row) => (attemptId ? `<a href="${row.attemptUrl}">${attemptId}</a>` : '')
+ },
+ {name: startedColumnName, data: 'startTime' },
+ {name: completedColumnName, data: 'endTime' },
+ {name: durationColumnName, type: "title-numeric", data: 'duration' },
+ {name: 'user', data: 'sparkUser' },
+ {name: 'lastUpdated', data: 'lastUpdated' },
+ {
+ name: 'eventLog',
+ data: 'log',
+ render: (log, type, row) => `<a href="${log}" class="btn btn-info btn-mini">Download</a>`
+ },
+ ],
+ "aoColumnDefs": [
Review comment:
@srowen
This part is the logic, not in the template anymore.
Here what I am trying to do is to change the style of first 3 columns only if hasMultipleAttemptsit will be set to white background.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] mohan3d removed a comment on pull request #31191: [SPARK-34123][Web UI] optimize spark history summary page loading
Posted by GitBox <gi...@apache.org>.
mohan3d removed a comment on pull request #31191:
URL: https://github.com/apache/spark/pull/31191#issuecomment-761463647
Jenkins, retest this please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] mohan3d commented on a change in pull request #31191: [SPARK-34123][Web UI] optimize spark history summary page loading
Posted by GitBox <gi...@apache.org>.
mohan3d commented on a change in pull request #31191:
URL: https://github.com/apache/spark/pull/31191#discussion_r558934521
##########
File path: core/src/main/resources/org/apache/spark/ui/static/historypage.js
##########
@@ -165,17 +169,41 @@ $(document).ready(function() {
var completedColumnName = 'completed';
var durationColumnName = 'duration';
var conf = {
+ "data": array,
"columns": [
- {name: 'version'},
- {name: 'appId', type: "appid-numeric"},
- {name: 'appName'},
- {name: attemptIdColumnName},
- {name: startedColumnName},
- {name: completedColumnName},
- {name: durationColumnName, type: "title-numeric"},
- {name: 'user'},
- {name: 'lastUpdated'},
- {name: 'eventLog'},
+ {name: 'version', data: 'version' },
+ {
+ name: 'appId',
+ type: "appid-numeric",
+ data: 'id',
+ render: (id, type, row) => `<span title="${id}"><a href="${row.attemptUrl}">${id}</a></span>`
+ },
+ {name: 'appName', data: 'name' },
+ {
+ name: attemptIdColumnName,
+ data: 'attemptId',
+ render: (attemptId, type, row) => (attemptId ? `<a href="${row.attemptUrl}">${attemptId}</a>` : '')
+ },
+ {name: startedColumnName, data: 'startTime' },
+ {name: completedColumnName, data: 'endTime' },
+ {name: durationColumnName, type: "title-numeric", data: 'duration' },
+ {name: 'user', data: 'sparkUser' },
+ {name: 'lastUpdated', data: 'lastUpdated' },
+ {
+ name: 'eventLog',
+ data: 'log',
+ render: (log, type, row) => `<a href="${log}" class="btn btn-info btn-mini">Download</a>`
+ },
+ ],
+ "aoColumnDefs": [
Review comment:
@srowen
This part is the logic, not in the template anymore.
Here what I am trying to do is to change the style of first 3 columns only if hasMultipleAttempts will be set to white background.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] srowen commented on a change in pull request #31191: [SPARK-34123][Web UI] optimize spark history summary page loading
Posted by GitBox <gi...@apache.org>.
srowen commented on a change in pull request #31191:
URL: https://github.com/apache/spark/pull/31191#discussion_r558355334
##########
File path: core/src/main/resources/org/apache/spark/ui/static/historypage-template.html
##########
@@ -75,26 +75,6 @@
</th>
</thead>
<tbody>
- {{#applications}}
- <tr>
- {{#attempts}}
- <td {{#hasMultipleAttempts}}style="background-color:#fff"{{/hasMultipleAttempts}}>{{version}}</td>
Review comment:
Does this retain the logic about `hasMultipleAttempts`? I didn't see it below.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] srowen commented on pull request #31191: [SPARK-34123][Web UI] optimize spark history summary page loading
Posted by GitBox <gi...@apache.org>.
srowen commented on pull request #31191:
URL: https://github.com/apache/spark/pull/31191#issuecomment-761876179
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] mohan3d commented on pull request #31191: [SPARK-34123][Web UI] optimize spark history summary page loading
Posted by GitBox <gi...@apache.org>.
mohan3d commented on pull request #31191:
URL: https://github.com/apache/spark/pull/31191#issuecomment-761462944
@srowen Can you please help re-testing? failed for non-related issue to the update.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] srowen commented on pull request #31191: [SPARK-34123][Web UI] optimize spark history summary page loading
Posted by GitBox <gi...@apache.org>.
srowen commented on pull request #31191:
URL: https://github.com/apache/spark/pull/31191#issuecomment-761876055
Merged to master
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] srowen closed pull request #31191: [SPARK-34123][Web UI] optimize spark history summary page loading
Posted by GitBox <gi...@apache.org>.
srowen closed pull request #31191:
URL: https://github.com/apache/spark/pull/31191
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] mohan3d commented on pull request #31191: [SPARK-34123][Web UI] optimize spark history summary page loading
Posted by GitBox <gi...@apache.org>.
mohan3d commented on pull request #31191:
URL: https://github.com/apache/spark/pull/31191#issuecomment-760680120
@2ooom @srowen Can you guys please help in this, what are the drawbacks of removing Mustache template from this part only and what is the reason it was used in the first place? or it was just convenient to use it since the page is already rendered using it?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] mohan3d commented on a change in pull request #31191: [SPARK-34123][Web UI] optimize spark history summary page loading
Posted by GitBox <gi...@apache.org>.
mohan3d commented on a change in pull request #31191:
URL: https://github.com/apache/spark/pull/31191#discussion_r558802536
##########
File path: core/src/main/resources/org/apache/spark/ui/static/historypage-template.html
##########
@@ -75,26 +75,6 @@
</th>
</thead>
<tbody>
- {{#applications}}
- <tr>
- {{#attempts}}
- <td {{#hasMultipleAttempts}}style="background-color:#fff"{{/hasMultipleAttempts}}>{{version}}</td>
Review comment:
No, It was not retaining this part of logic.
Updated the code to apply same idea on first 3 columns (version, id and name) from datatables side.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org