[GitHub] [hbase] saintstack commented on a change in pull request #2945: [HBASE-25539] Adding replication log queue

[GitBox <gi...@apache.org>]

saintstack commented on a change in pull request #2945:
URL: https://github.com/apache/hbase/pull/2945#discussion_r573860953



##########
File path: hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSource.java
##########
@@ -87,9 +86,10 @@
   private static final Logger LOG = LoggerFactory.getLogger(ReplicationSource.class);
   // Queues of logs to process, entry in format of walGroupId->queue,
   // each presents a queue for one wal group
-  private Map<String, PriorityBlockingQueue<Path>> queues = new HashMap<>();
+  //private Map<String, PriorityBlockingQueue<Path>> queues = new HashMap<>();

Review comment:
       Remove rather than comment out (This is a draft so maybe you are just trying stuff -- if so, ignore this comment)

##########
File path: hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationLogQueue.java
##########
@@ -0,0 +1,93 @@
+package org.apache.hadoop.hbase.replication.regionserver;

Review comment:
       License

##########
File path: hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationLogQueue.java
##########
@@ -0,0 +1,93 @@
+package org.apache.hadoop.hbase.replication.regionserver;
+
+import java.util.HashMap;
+import java.util.Map;
+import java.util.concurrent.PriorityBlockingQueue;
+import org.apache.hadoop.conf.Configuration;
+import org.apache.hadoop.fs.Path;
+import org.apache.hadoop.hbase.util.Pair;
+import org.apache.hadoop.hbase.wal.AbstractFSWALProvider;
+import org.apache.yetus.audience.InterfaceAudience;
+import org.apache.yetus.audience.InterfaceStability;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+@InterfaceAudience.Private
+@InterfaceStability.Evolving
+public class ReplicationLogQueue {

Review comment:
       Class comment on what this thing does




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org