You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "Attila Király (JIRA)" <ji...@apache.org> on 2011/01/11 10:59:46 UTC
[jira] Created: (WICKET-3322) Patches to correct some Findbugs
warnings in core, request and util
Patches to correct some Findbugs warnings in core, request and util
-------------------------------------------------------------------
Key: WICKET-3322
URL: https://issues.apache.org/jira/browse/WICKET-3322
Project: Wicket
Issue Type: Bug
Components: wicket
Affects Versions: 1.5-M3
Reporter: Attila Király
Priority: Minor
The patches contain fixes mainly for the followings:
- only java files in main source directories of core, request and util were touched (so test not)
- only those were fixed that looked straightforward and locally fixable
- fixing cases that always result in NPE (2 found) or ClassCastException (1 found)
- unused local variable, dead store removals
- redundant instanceof check, nullcheck removals
- added transient to non serializable fields of serializable classes
- made inner classes static where the reference to the enclosing classes was not used
- some extra null checks added with WeakReference usages to avoid NPE
- "File#delete() return value not checked": using wickets Files#remove() instead
- small performance related tasks: using StringBuilder in loop, using map entrySet() instead of keySet() + get()
I added some comments to the patches where I tought it is not easy to figure out without the findbugs report why the code was changed. But of course I can explain if other questions arise.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (WICKET-3322) Patches to correct some Findbugs
warnings in core, request and util
Posted by "Juergen Donnerstag (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-3322?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Juergen Donnerstag resolved WICKET-3322.
----------------------------------------
Resolution: Fixed
Assignee: Juergen Donnerstag
thanks
> Patches to correct some Findbugs warnings in core, request and util
> -------------------------------------------------------------------
>
> Key: WICKET-3322
> URL: https://issues.apache.org/jira/browse/WICKET-3322
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.5-M3
> Reporter: Attila Király
> Assignee: Juergen Donnerstag
> Priority: Minor
> Attachments: WICKET-3322-1-findbugs-wicket-util.patch, WICKET-3322-2-findbugs-wicket-request.patch, WICKET-3322-3-findbugs-wicket-core.patch
>
>
> The patches contain fixes mainly for the followings:
> - only java files in main source directories of core, request and util were touched (so test not)
> - only those were fixed that looked straightforward and locally fixable
> - fixing cases that always result in NPE (2 found) or ClassCastException (1 found)
> - unused local variable, dead store removals
> - redundant instanceof check, nullcheck removals
> - added transient to non serializable fields of serializable classes
> - made inner classes static where the reference to the enclosing classes was not used
> - some extra null checks added with WeakReference usages to avoid NPE
> - "File#delete() return value not checked": using wickets Files#remove() instead
> - small performance related tasks: using StringBuilder in loop, using map entrySet() instead of keySet() + get()
> I added some comments to the patches where I tought it is not easy to figure out without the findbugs report why the code was changed. But of course I can explain if other questions arise.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WICKET-3322) Patches to correct some Findbugs
warnings in core, request and util
Posted by "Attila Király (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-3322?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Attila Király updated WICKET-3322:
----------------------------------
Attachment: WICKET-3322-3-findbugs-wicket-core.patch
WICKET-3322-2-findbugs-wicket-request.patch
WICKET-3322-1-findbugs-wicket-util.patch
Attaching patches by module.
> Patches to correct some Findbugs warnings in core, request and util
> -------------------------------------------------------------------
>
> Key: WICKET-3322
> URL: https://issues.apache.org/jira/browse/WICKET-3322
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.5-M3
> Reporter: Attila Király
> Priority: Minor
> Attachments: WICKET-3322-1-findbugs-wicket-util.patch, WICKET-3322-2-findbugs-wicket-request.patch, WICKET-3322-3-findbugs-wicket-core.patch
>
>
> The patches contain fixes mainly for the followings:
> - only java files in main source directories of core, request and util were touched (so test not)
> - only those were fixed that looked straightforward and locally fixable
> - fixing cases that always result in NPE (2 found) or ClassCastException (1 found)
> - unused local variable, dead store removals
> - redundant instanceof check, nullcheck removals
> - added transient to non serializable fields of serializable classes
> - made inner classes static where the reference to the enclosing classes was not used
> - some extra null checks added with WeakReference usages to avoid NPE
> - "File#delete() return value not checked": using wickets Files#remove() instead
> - small performance related tasks: using StringBuilder in loop, using map entrySet() instead of keySet() + get()
> I added some comments to the patches where I tought it is not easy to figure out without the findbugs report why the code was changed. But of course I can explain if other questions arise.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.