You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Todd Lipcon (Code Review)" <ge...@cloudera.org> on 2018/02/07 01:08:16 UTC
[kudu-CR] docs: improvements to NTP troubleshooting
Hello Alex Rodoni, Jean-Daniel Cryans,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/9234
to review the following change.
Change subject: docs: improvements to NTP troubleshooting
......................................................................
docs: improvements to NTP troubleshooting
Change-Id: I07b6871b91ed4ee08992d2fcd093f1054c7d61b8
---
M docs/troubleshooting.adoc
1 file changed, 143 insertions(+), 8 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/34/9234/1
--
To view, visit http://gerrit.cloudera.org:8080/9234
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I07b6871b91ed4ee08992d2fcd093f1054c7d61b8
Gerrit-Change-Number: 9234
Gerrit-PatchSet: 1
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
[kudu-CR] docs: improvements to NTP troubleshooting
Posted by "Will Berkeley (Code Review)" <ge...@cloudera.org>.
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/9234 )
Change subject: docs: improvements to NTP troubleshooting
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/9234
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I07b6871b91ed4ee08992d2fcd093f1054c7d61b8
Gerrit-Change-Number: 9234
Gerrit-PatchSet: 2
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Comment-Date: Tue, 13 Feb 2018 00:19:34 +0000
Gerrit-HasComments: No
[kudu-CR] docs: improvements to NTP troubleshooting
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9234 )
Change subject: docs: improvements to NTP troubleshooting
......................................................................
docs: improvements to NTP troubleshooting
Change-Id: I07b6871b91ed4ee08992d2fcd093f1054c7d61b8
Reviewed-on: http://gerrit.cloudera.org:8080/9234
Reviewed-by: Will Berkeley <wd...@gmail.com>
Tested-by: Kudu Jenkins
---
M docs/troubleshooting.adoc
1 file changed, 143 insertions(+), 8 deletions(-)
Approvals:
Will Berkeley: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/9234
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I07b6871b91ed4ee08992d2fcd093f1054c7d61b8
Gerrit-Change-Number: 9234
Gerrit-PatchSet: 3
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
[kudu-CR] docs: improvements to NTP troubleshooting
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/9234 )
Change subject: docs: improvements to NTP troubleshooting
......................................................................
Patch Set 1:
This will probably conflict with Mahdi's in-flight change. I'll take care of merging after review
--
To view, visit http://gerrit.cloudera.org:8080/9234
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I07b6871b91ed4ee08992d2fcd093f1054c7d61b8
Gerrit-Change-Number: 9234
Gerrit-PatchSet: 1
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Wed, 07 Feb 2018 01:08:38 +0000
Gerrit-HasComments: No
[kudu-CR] docs: improvements to NTP troubleshooting
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/9234 )
Change subject: docs: improvements to NTP troubleshooting
......................................................................
Patch Set 2:
(3 comments)
darn laptop keyboard and its double-letters
http://gerrit.cloudera.org:8080/#/c/9234/1/docs/troubleshooting.adoc
File docs/troubleshooting.adoc:
http://gerrit.cloudera.org:8080/#/c/9234/1/docs/troubleshooting.adoc@137
PS1, Line 137: healthy
> Extra h.
Done
http://gerrit.cloudera.org:8080/#/c/9234/1/docs/troubleshooting.adoc@156
PS1, Line 156: information
> Extra m.
Done
http://gerrit.cloudera.org:8080/#/c/9234/1/docs/troubleshooting.adoc@245
PS1, Line 245: `ERROR`
> nit: `ERROR` log
Done
--
To view, visit http://gerrit.cloudera.org:8080/9234
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I07b6871b91ed4ee08992d2fcd093f1054c7d61b8
Gerrit-Change-Number: 9234
Gerrit-PatchSet: 2
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Comment-Date: Tue, 13 Feb 2018 00:15:14 +0000
Gerrit-HasComments: Yes
[kudu-CR] docs: improvements to NTP troubleshooting
Posted by "Alex Rodoni (Code Review)" <ge...@cloudera.org>.
Alex Rodoni has posted comments on this change. ( http://gerrit.cloudera.org:8080/9234 )
Change subject: docs: improvements to NTP troubleshooting
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/9234
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I07b6871b91ed4ee08992d2fcd093f1054c7d61b8
Gerrit-Change-Number: 9234
Gerrit-PatchSet: 1
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Wed, 07 Feb 2018 01:14:59 +0000
Gerrit-HasComments: No
[kudu-CR] docs: improvements to NTP troubleshooting
Posted by "Will Berkeley (Code Review)" <ge...@cloudera.org>.
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/9234 )
Change subject: docs: improvements to NTP troubleshooting
......................................................................
Patch Set 1:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/9234/1/docs/troubleshooting.adoc
File docs/troubleshooting.adoc:
http://gerrit.cloudera.org:8080/#/c/9234/1/docs/troubleshooting.adoc@137
PS1, Line 137: healthhy
Extra h.
http://gerrit.cloudera.org:8080/#/c/9234/1/docs/troubleshooting.adoc@156
PS1, Line 156: informmation
Extra m.
http://gerrit.cloudera.org:8080/#/c/9234/1/docs/troubleshooting.adoc@245
PS1, Line 245: `ERROR`
nit: `ERROR` log
--
To view, visit http://gerrit.cloudera.org:8080/9234
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I07b6871b91ed4ee08992d2fcd093f1054c7d61b8
Gerrit-Change-Number: 9234
Gerrit-PatchSet: 1
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Comment-Date: Wed, 07 Feb 2018 16:41:33 +0000
Gerrit-HasComments: Yes
[kudu-CR] docs: improvements to NTP troubleshooting
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Hello Will Berkeley, Alex Rodoni, Jean-Daniel Cryans, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/9234
to look at the new patch set (#2).
Change subject: docs: improvements to NTP troubleshooting
......................................................................
docs: improvements to NTP troubleshooting
Change-Id: I07b6871b91ed4ee08992d2fcd093f1054c7d61b8
---
M docs/troubleshooting.adoc
1 file changed, 143 insertions(+), 8 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/34/9234/2
--
To view, visit http://gerrit.cloudera.org:8080/9234
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I07b6871b91ed4ee08992d2fcd093f1054c7d61b8
Gerrit-Change-Number: 9234
Gerrit-PatchSet: 2
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>