You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "JNSimba (via GitHub)" <gi...@apache.org> on 2023/04/21 08:41:10 UTC
[GitHub] [doris] JNSimba opened a new pull request, #18899: [doc](update-key)add update key doc
JNSimba opened a new pull request, #18899:
URL: https://github.com/apache/doris/pull/18899
## Problem summary
At present, only the value column can be modified through the update command,
and the modification of the key column can be done by flinkcdc synchronization
## Checklist(Required)
* [ ] Does it affect the original behavior
* [ ] Has unit tests been added
* [ ] Has document been added or modified
* [ ] Does it need to update dependencies
* [ ] Is this PR support rollback (If NO, please explain WHY)
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] luzhijing commented on pull request #18899: [doc](update-key)add update key doc
Posted by "luzhijing (via GitHub)" <gi...@apache.org>.
luzhijing commented on PR #18899:
URL: https://github.com/apache/doris/pull/18899#issuecomment-1517967800
LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] dataroaring merged pull request #18899: [doc](update-key)add update key doc
Posted by "dataroaring (via GitHub)" <gi...@apache.org>.
dataroaring merged PR #18899:
URL: https://github.com/apache/doris/pull/18899
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] dataroaring commented on a diff in pull request #18899: [doc](update-key)add update key doc
Posted by "dataroaring (via GitHub)" <gi...@apache.org>.
dataroaring commented on code in PR #18899:
URL: https://github.com/apache/doris/pull/18899#discussion_r1173663776
##########
docs/en/docs/data-operate/update-delete/update.md:
##########
@@ -123,6 +123,9 @@ Since the table order is a UNIQUE model, the rows with the same Key, after which
|---|---|---|
| 1 | 100 | Pending shipments |
+## Update primary key column data
+Currently, the Update operation only supports updating the Value column, and the update of the Key column can refer to [Using FlinkCDC to update key column data synchronously](../../ecosystem/flink-doris-connector.md#Use-FlinkCDC-to-update-Key-column-data-synchronously)
+
Review Comment:
Update primary key column is enough.
##########
docs/en/docs/ecosystem/flink-doris-connector.md:
##########
@@ -441,6 +441,16 @@ WITH (
insert into doris_sink select id,name from cdc_mysql_source;
```
+## Use FlinkCDC to update Key column data synchronously
+Generally, in a business database, the number is used as the primary key of the table, such as the Student table, the number (id) is used as the primary key, but with the development of the business, the number corresponding to the data may change.
Review Comment:
same as above.
##########
docs/zh-CN/docs/data-operate/update-delete/update.md:
##########
@@ -120,6 +120,9 @@ Query OK, 1 row affected (0.11 sec)
|---|---|---|
| 1 | 100 | 待发货 |
+## 更新主键列数据
+目前Update操作只支持更新Value列，Key列的更新可参考[使用FlinkCDC同步更新Key列数据](../../ecosystem/flink-doris-connector.md#使用FlinkCDC同步更新Key列数据)
+
Review Comment:
same as above
##########
docs/zh-CN/docs/ecosystem/flink-doris-connector.md:
##########
@@ -433,6 +436,16 @@ WITH (
insert into doris_sink select id,name from cdc_mysql_source;
```
+## 使用FlinkCDC同步更新Key列数据
Review Comment:
same as above
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #18899: [doc](update-key)add update key doc
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #18899:
URL: https://github.com/apache/doris/pull/18899#issuecomment-1517679402
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] dataroaring commented on pull request #18899: [doc](update-key)add update key doc
Posted by "dataroaring (via GitHub)" <gi...@apache.org>.
dataroaring commented on PR #18899:
URL: https://github.com/apache/doris/pull/18899#issuecomment-1519704462
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] dataroaring commented on pull request #18899: [doc](update-key)add update key doc
Posted by "dataroaring (via GitHub)" <gi...@apache.org>.
dataroaring commented on PR #18899:
URL: https://github.com/apache/doris/pull/18899#issuecomment-1519704268
run build all
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] JNSimba commented on pull request #18899: [doc](update-key)add update key doc
Posted by "JNSimba (via GitHub)" <gi...@apache.org>.
JNSimba commented on PR #18899:
URL: https://github.com/apache/doris/pull/18899#issuecomment-1517811106
Thanks for the review, it has been modified.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #18899: [doc](update-key)add update key doc
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #18899:
URL: https://github.com/apache/doris/pull/18899#issuecomment-1517679463
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] dataroaring commented on pull request #18899: [doc](update-key)add update key doc
Posted by "dataroaring (via GitHub)" <gi...@apache.org>.
dataroaring commented on PR #18899:
URL: https://github.com/apache/doris/pull/18899#issuecomment-1517839334
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org