You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shenyu.apache.org by "Aias00 (via GitHub)" <gi...@apache.org> on 2026/08/04 03:00:05 UTC

[I] [BUG] removeMcpServer deletes sibling servers' routes via prefix match [shenyu]

Aias00 opened a new issue, #6887:
URL: https://github.com/apache/shenyu/issues/6887

   ## Description
   `createParameterSchema` and `recursionConstructPropertiesNodes` set only `type`/`description`/`properties`/`items`. The `required` array is never written, and `McpServerToolParameter.required`/`defaultValue` fields are ignored. Per JSON Schema / MCP, required parameters must be listed in a top-level `required` array.
   
   ## Location
   - `shenyu-plugin/shenyu-plugin-mcp-server/src/main/java/org/apache/shenyu/plugin/mcp/server/utils/JsonSchemaUtil.java:49-67`
   
   ## Impact
   MCP clients treat every parameter as optional and won't enforce/validate the tool's real contract; tools silently accept calls missing required arguments.
   
   ## Suggested fix
   Collect parameters where `parameter.isRequired()` is true into a `required` ArrayNode on the schema root.
   
   ## Related existing
   None.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] [BUG] removeMcpServer deletes sibling servers' routes via prefix match [shenyu]

Posted by "Aias00 (via GitHub)" <gi...@apache.org>.
Aias00 closed issue #6887: [BUG] removeMcpServer deletes sibling servers' routes via prefix match
URL: https://github.com/apache/shenyu/issues/6887


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] [BUG] removeMcpServer deletes sibling servers' routes via prefix match [shenyu]

Posted by "liudawang001 (via GitHub)" <gi...@apache.org>.
liudawang001 commented on issue #6887:
URL: https://github.com/apache/shenyu/issues/6887#issuecomment-5447311616

   Hi, I'd like to work on this issue. I'll first add a regression test covering sibling MCP server names with overlapping prefixes, then make the minimal fix so that removing one server only deletes its own routes. If this approach looks good, I'd be happy to submit a PR.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] [BUG] removeMcpServer deletes sibling servers' routes via prefix match [shenyu]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on issue #6887:
URL: https://github.com/apache/shenyu/issues/6887#issuecomment-5174094869

   👋 Hello @Aias00
   
   A new issue has been opened by @Aias00:
   - **Title**: [BUG] removeMcpServer deletes sibling servers' routes via prefix match
   - **Link**: https://github.com/apache/shenyu/issues/6887
   
   Please review when you have time. Thank you! 🙏


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] [BUG] removeMcpServer deletes sibling servers' routes via prefix match [shenyu]

Posted by "zhang-arvin (via GitHub)" <gi...@apache.org>.
zhang-arvin commented on issue #6887:
URL: https://github.com/apache/shenyu/issues/6887#issuecomment-5462712742

   I will work on this issue.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org