You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2021/03/04 06:22:16 UTC

[GitHub] [kafka] dongjinleekr opened a new pull request #10257: KAFKA-12407: Document omitted Controller Health Metrics

dongjinleekr opened a new pull request #10257:
URL: https://github.com/apache/kafka/pull/10257


   This PR fills the omitted documentation of:
   
   - `kafka.controller:type=ControllerChannelManager,name=RequestRateAndQueueTimeMs,brokerId=([-.\w]+)`
   - `kafka.controller:type=ControllerEventManager,name=EventQueueSize`
   - `kafka.controller:type=ControllerEventManager,name=EventQueueTimeMs`
   
   ### Committer Checklist (excluded from commit message)
   - [ ] Verify design and implementation 
   - [ ] Verify test coverage and CI build status
   - [ ] Verify documentation (including upgrade notes)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] dongjinleekr commented on pull request #10257: KAFKA-12407: Document omitted Controller Health Metrics

Posted by GitBox <gi...@apache.org>.
dongjinleekr commented on pull request #10257:
URL: https://github.com/apache/kafka/pull/10257#issuecomment-790331698


   @satishd @showuon Could you have a look? cc/ @lindong28


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] lindong28 commented on pull request #10257: KAFKA-12407: Document omitted Controller Health Metrics

Posted by GitBox <gi...@apache.org>.
lindong28 commented on pull request #10257:
URL: https://github.com/apache/kafka/pull/10257#issuecomment-790640953


   Thanks you @dongjinleekr for the improvement! LGTM.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] showuon commented on a change in pull request #10257: KAFKA-12407: Document omitted Controller Health Metrics

Posted by GitBox <gi...@apache.org>.
showuon commented on a change in pull request #10257:
URL: https://github.com/apache/kafka/pull/10257#discussion_r587260885



##########
File path: docs/ops.html
##########
@@ -1271,6 +1271,24 @@ <h4 class="anchor-heading"><a id="remote_jmx" class="anchor-link"></a><a href="#
         <td>kafka.server:type=BrokerTopicMetrics,name=ReplicationBytesInPerSec</td>
         <td></td>
       </tr>
+      <tr>
+        <td>Controller Request rate from Broker</td>
+        <td>kafka.controller:type=ControllerChannelManager,name=RequestRateAndQueueTimeMs,brokerId=([-.\w]+)</td>

Review comment:
       Our brokerId should be an Integer value, except I miss anything.
   ref: http://kafka.apache.org/documentation/#brokerconfigs_broker.id




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] dongjinleekr commented on a change in pull request #10257: KAFKA-12407: Document omitted Controller Health Metrics

Posted by GitBox <gi...@apache.org>.
dongjinleekr commented on a change in pull request #10257:
URL: https://github.com/apache/kafka/pull/10257#discussion_r587300188



##########
File path: docs/ops.html
##########
@@ -1271,6 +1271,24 @@ <h4 class="anchor-heading"><a id="remote_jmx" class="anchor-link"></a><a href="#
         <td>kafka.server:type=BrokerTopicMetrics,name=ReplicationBytesInPerSec</td>
         <td></td>
       </tr>
+      <tr>
+        <td>Controller Request rate from Broker</td>
+        <td>kafka.controller:type=ControllerChannelManager,name=RequestRateAndQueueTimeMs,brokerId=([-.\w]+)</td>

Review comment:
       @showuon You are right. Fixed.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] lindong28 merged pull request #10257: KAFKA-12407: Document Controller Health Metrics

Posted by GitBox <gi...@apache.org>.
lindong28 merged pull request #10257:
URL: https://github.com/apache/kafka/pull/10257


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org