You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Murali Krishna P (JIRA)" <ji...@apache.org> on 2019/01/01 04:51:00 UTC

[jira] [Commented] (LUCENE-8601) Adding attributes to IndexFieldType

    [ https://issues.apache.org/jira/browse/LUCENE-8601?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16731518#comment-16731518 ] 

Murali Krishna P commented on LUCENE-8601:
------------------------------------------

Thanks, Added java docs for ignoreCurrentFormat, changed to 'if' from ternary, removed null initialization for class members and referenced attributes in DefaultIndexingChain in the new [^LUCENE-8601.06.patch].

> Adding attributes to IndexFieldType
> -----------------------------------
>
>                 Key: LUCENE-8601
>                 URL: https://issues.apache.org/jira/browse/LUCENE-8601
>             Project: Lucene - Core
>          Issue Type: Improvement
>          Components: core/index
>    Affects Versions: 7.5
>            Reporter: Murali Krishna P
>            Priority: Major
>         Attachments: LUCENE-8601.01.patch, LUCENE-8601.02.patch, LUCENE-8601.03.patch, LUCENE-8601.04.patch, LUCENE-8601.05.patch, LUCENE-8601.06.patch, LUCENE-8601.patch
>
>
> Today, we can write a custom Field using custom IndexFieldType, but when the DefaultIndexingChain converts [IndexFieldType to FieldInfo|https://github.com/apache/lucene-solr/blob/master/lucene/core/src/java/org/apache/lucene/index/DefaultIndexingChain.java#L662], only few key informations such as indexing options and doc value type are retained. The [Codec gets the FieldInfo|https://github.com/apache/lucene-solr/blob/master/lucene/core/src/java/org/apache/lucene/codecs/DocValuesConsumer.java#L90], but not the type details.
>   
>  FieldInfo has support for ['attributes'| https://github.com/apache/lucene-solr/blob/master/lucene/core/src/java/org/apache/lucene/index/FieldInfo.java#L47] and it would be great if we can add 'attributes' to IndexFieldType also and copy it to FieldInfo's 'attribute'.
>   
>  This would allow someone to write a custom codec (extending docvalueformat for example) for only the 'special field' that he wants and delegate the rest of the fields to the default codec.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org