You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@grails.apache.org by "borinquenkid (via GitHub)" <gi...@apache.org> on 2026/10/10 19:58:24 UTC

[PR] refactor: convert grails-datastore-core to Groovy [grails-core]

borinquenkid opened a new pull request, #16580:
URL: https://github.com/apache/grails-core/pull/16580

   ## What
   
   Converts the remaining Java sources of `grails-datastore-core` to Groovy: 207 `.java` files removed, 250 `.groovy` files added (310 files changed, 25594 insertions(+), 15494 deletions(-)).
   
   ## Why
   
   The maintainers asked on #16351 for the Java-to-Groovy migration to land one Gradle project at a time as a stack of PRs, bottom-up in dependency order. #16572 did `grails-data-hibernate7`; this PR is 5 of 30 in the next stack (base: `refactor/java-to-groovy-grails-databinding-core`). The end state of every file is taken from the `9.0.x-java-to-groovy` branch, which already carries the regression fixes found by CI.
   
   Commits:
   - fa765f1f07 refactor: convert grails-datastore-core to Groovy
   
   ## Changed outside the converted sources
   
   - `A grails-datastore-core/src/test/resources/META-INF/services/org.grails.datastore.mapping.services.SslService`
   
   ## Java-facing API sweep
   
   Every deleted `.java` was compared with its Groovy twin via `javap -v -protected` (class declaration, public/protected fields, constructors, methods incl. modifiers/throws/generics, interface default methods, nested class modifiers, and the annotations callers see). Result:
   
   - `grails-datastore-core`: 207 deleted .java, 1 differences requiring action
   
   See also the notes below. Remaining informational entries (widened visibility, e.g. Groovy property accessors): 25.
   
   ## Verification
   
   - `classes` and `testClasses` (plus `ast`/`cli`/`testFixtures` source sets where present) of the converted project(s) and of their direct dependents compile: ['grails-converters', 'grails-core', 'grails-data-mongodb-bson', 'grails-data-mongodb-core', 'grails-data-simple', 'grails-datamapping-core', 'grails-datamapping-core-test', 'grails-datamapping-rx', 'grails-datamapping-support', 'grails-datamapping-tck', 'grails-datamapping-validation', 'grails-datasource', 'grails-datastore-web', 'grails-domain-class', 'grails-events-rxjava', 'grails-events-transforms', 'grails-spring-security', 'grails-testing-support-datamapping', 'grails-testing-support-views-gson', 'grails-views-core']
   - No test suites were run locally (the umbrella branch was verified; CI runs them). `codeStyle`, `rat` and a whole-repo `build -PskipTests` are run once on the tip of the stack.
   
   ## Notes
   
   - Informational sweep entries that are not regressions: Groovy enums gain `MIN_VALUE`/`MAX_VALUE`/`next()`/`previous()`, property accessors appear for formerly package-private members, nested static classes with implicit constructors become public (they were `protected`), and generic type parameters that Groovy erases in constructors/methods (descriptors identical).
   - Groovy gotchas that applied (see #16351): `static final` without `public` creates a property; `==` calls `equals()`; Closure/SAM coercions; `@CompileStatic` with nested classes. All CI regression fixes found on the umbrella branch are included in the end state.
   - Not matchable in Groovy: `ServiceDefinition.orElseThrow` was `<X extends Throwable> T orElseThrow(Supplier<? extends X>) throws X`; Groovy cannot express a type-variable `throws` clause and emits `throws Throwable`. Only Groovy code in this repository calls it (SoftServiceLoader, AbstractDatastoreInitializer); external Java callers would have to handle `Throwable`.
   
   🤖 Generated with [Claude Code](https://claude.com/claude-code)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@grails.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] refactor: convert grails-datastore-core to Groovy [grails-core]

Posted by "testlens-app[bot] (via GitHub)" <gi...@apache.org>.

testlens-app[bot] commented on PR #16580:
URL: https://github.com/apache/grails-core/pull/16580#issuecomment-6145156572

   ## 🚨 All tests passed but jobs failed 🚨
   
   ### Failed Jobs without Test Failures
   
   ❌ [CI / Spring Security CAS Functional Tests \(cas\)](https://github.com/apache/grails-core/actions/runs/38393235893/job/115281936603?pr=16580)
   
   🏷️ Commit: ebd82c3efb22fc82c1f3fdd8cc56491cb8d7059d
   ▶️ Tests:  2975 executed
   🟡 Checks: 13/77 completed
   
   ### Rerun Controls
   
   Click the checkbox to trigger a rerun:
   
   🔲 **Rerun jobs**
   
   ---
   _Learn more about TestLens at [testlens.app/docs](https://testlens.app/docs/features/pr-comment/)._
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@grails.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] refactor: convert grails-datastore-core to Groovy [grails-core]

Posted by "testlens-app[bot] (via GitHub)" <gi...@apache.org>.

testlens-app[bot] commented on PR #16580:
URL: https://github.com/apache/grails-core/pull/16580#issuecomment-6244582459

   ## ✅ All tests passed ✅
   
   🏷️ Commit: cc1bc0a4021ff3fc80ffff6daaaf34bffbad0e3e
   ▶️ Tests:  78698 executed
   ⚪️ Checks: 84/84 completed
   
   ---
   _Learn more about TestLens at [testlens.app/docs](https://testlens.app/docs/features/pr-comment/)._
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@grails.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] refactor: convert grails-datastore-core to Groovy [grails-core]

Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.

codecov[bot] commented on PR #16580:
URL: https://github.com/apache/grails-core/pull/16580#issuecomment-6102087440

   ## [Codecov](https://app.codecov.io/gh/apache/grails-core/pull/16580?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :x: Patch coverage is `89.60186%` with `269 lines` in your changes missing coverage. Please review.
   :warning: Please [upload](https://docs.codecov.com/docs/codecov-uploader) report for BASE (`refactor/java-to-groovy-grails-databinding-core@c2cace6`). [Learn more](https://docs.codecov.io/docs/error-reference?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#section-missing-base-commit) about missing BASE report.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/grails-core/pull/16580?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
   |---|---|---|
   | [...ails/datastore/mapping/core/AbstractSession.groovy](https://app.codecov.io/gh/apache/grails-core/pull/16580?src=pr&el=tree&filepath=grails-datastore-core%2Fsrc%2Fmain%2Fgroovy%2Forg%2Fgrails%2Fdatastore%2Fmapping%2Fcore%2FAbstractSession.groovy&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Z3JhaWxzLWRhdGFzdG9yZS1jb3JlL3NyYy9tYWluL2dyb292eS9vcmcvZ3JhaWxzL2RhdGFzdG9yZS9tYXBwaW5nL2NvcmUvQWJzdHJhY3RTZXNzaW9uLmdyb292eQ==) | 88.5906% | [18 Missing and 33 partials :warning: ](https://app.codecov.io/gh/apache/grails-core/pull/16580?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...rails/datastore/mapping/core/DatastoreUtils.groovy](https://app.codecov.io/gh/apache/grails-core/pull/16580?src=pr&el=tree&filepath=grails-datastore-core%2Fsrc%2Fmain%2Fgroovy%2Forg%2Fgrails%2Fdatastore%2Fmapping%2Fcore%2FDatastoreUtils.groovy&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Z3JhaWxzLWRhdGFzdG9yZS1jb3JlL3NyYy9tYWluL2dyb292eS9vcmcvZ3JhaWxzL2RhdGFzdG9yZS9tYXBwaW5nL2NvcmUvRGF0YXN0b3JlVXRpbHMuZ3Jvb3Z5) | 72.5610% | [34 Missing and 11 partials :warning: ](https://app.codecov.io/gh/apache/grails-core/pull/16580?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...del/config/GormMappingConfigurationStrategy.groovy](https://app.codecov.io/gh/apache/grails-core/pull/16580?src=pr&el=tree&filepath=grails-datastore-core%2Fsrc%2Fmain%2Fgroovy%2Forg%2Fgrails%2Fdatastore%2Fmapping%2Fmodel%2Fconfig%2FGormMappingConfigurationStrategy.groovy&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Z3JhaWxzLWRhdGFzdG9yZS1jb3JlL3NyYy9tYWluL2dyb292eS9vcmcvZ3JhaWxzL2RhdGFzdG9yZS9tYXBwaW5nL21vZGVsL2NvbmZpZy9Hb3JtTWFwcGluZ0NvbmZpZ3VyYXRpb25TdHJhdGVneS5ncm9vdnk=) | 86.2816% | [19 Missing and 19 partials :warning: ](https://app.codecov.io/gh/apache/grails-core/pull/16580?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...astore/mapping/model/AbstractMappingContext.groovy](https://app.codecov.io/gh/apache/grails-core/pull/16580?src=pr&el=tree&filepath=grails-datastore-core%2Fsrc%2Fmain%2Fgroovy%2Forg%2Fgrails%2Fdatastore%2Fmapping%2Fmodel%2FAbstractMappingContext.groovy&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Z3JhaWxzLWRhdGFzdG9yZS1jb3JlL3NyYy9tYWluL2dyb292eS9vcmcvZ3JhaWxzL2RhdGFzdG9yZS9tYXBwaW5nL21vZGVsL0Fic3RyYWN0TWFwcGluZ0NvbnRleHQuZ3Jvb3Z5) | 87.4396% | [9 Missing and 17 partials :warning: ](https://app.codecov.io/gh/apache/grails-core/pull/16580?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...tore/mapping/model/AbstractPersistentEntity.groovy](https://app.codecov.io/gh/apache/grails-core/pull/16580?src=pr&el=tree&filepath=grails-datastore-core%2Fsrc%2Fmain%2Fgroovy%2Forg%2Fgrails%2Fdatastore%2Fmapping%2Fmodel%2FAbstractPersistentEntity.groovy&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Z3JhaWxzLWRhdGFzdG9yZS1jb3JlL3NyYy9tYWluL2dyb292eS9vcmcvZ3JhaWxzL2RhdGFzdG9yZS9tYXBwaW5nL21vZGVsL0Fic3RyYWN0UGVyc2lzdGVudEVudGl0eS5ncm9vdnk=) | 85.8896% | [13 Missing and 10 partials :warning: ](https://app.codecov.io/gh/apache/grails-core/pull/16580?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...ls/datastore/mapping/core/AbstractDatastore.groovy](https://app.codecov.io/gh/apache/grails-core/pull/16580?src=pr&el=tree&filepath=grails-datastore-core%2Fsrc%2Fmain%2Fgroovy%2Forg%2Fgrails%2Fdatastore%2Fmapping%2Fcore%2FAbstractDatastore.groovy&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Z3JhaWxzLWRhdGFzdG9yZS1jb3JlL3NyYy9tYWluL2dyb292eS9vcmcvZ3JhaWxzL2RhdGFzdG9yZS9tYXBwaW5nL2NvcmUvQWJzdHJhY3REYXRhc3RvcmUuZ3Jvb3Z5) | 80.9524% | [7 Missing and 9 partials :warning: ](https://app.codecov.io/gh/apache/grails-core/pull/16580?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...ls/datastore/mapping/engine/EntityPersister.groovy](https://app.codecov.io/gh/apache/grails-core/pull/16580?src=pr&el=tree&filepath=grails-datastore-core%2Fsrc%2Fmain%2Fgroovy%2Forg%2Fgrails%2Fdatastore%2Fmapping%2Fengine%2FEntityPersister.groovy&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Z3JhaWxzLWRhdGFzdG9yZS1jb3JlL3NyYy9tYWluL2dyb292eS9vcmcvZ3JhaWxzL2RhdGFzdG9yZS9tYXBwaW5nL2VuZ2luZS9FbnRpdHlQZXJzaXN0ZXIuZ3Jvb3Z5) | 91.9118% | [6 Missing and 5 partials :warning: ](https://app.codecov.io/gh/apache/grails-core/pull/16580?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...s/datastore/mapping/engine/BeanEntityAccess.groovy](https://app.codecov.io/gh/apache/grails-core/pull/16580?src=pr&el=tree&filepath=grails-datastore-core%2Fsrc%2Fmain%2Fgroovy%2Forg%2Fgrails%2Fdatastore%2Fmapping%2Fengine%2FBeanEntityAccess.groovy&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Z3JhaWxzLWRhdGFzdG9yZS1jb3JlL3NyYy9tYWluL2dyb292eS9vcmcvZ3JhaWxzL2RhdGFzdG9yZS9tYXBwaW5nL2VuZ2luZS9CZWFuRW50aXR5QWNjZXNzLmdyb292eQ==) | 81.8182% | [3 Missing and 7 partials :warning: ](https://app.codecov.io/gh/apache/grails-core/pull/16580?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [.../datastore/mapping/model/AuditMetadataUtils.groovy](https://app.codecov.io/gh/apache/grails-core/pull/16580?src=pr&el=tree&filepath=grails-datastore-core%2Fsrc%2Fmain%2Fgroovy%2Forg%2Fgrails%2Fdatastore%2Fmapping%2Fmodel%2FAuditMetadataUtils.groovy&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Z3JhaWxzLWRhdGFzdG9yZS1jb3JlL3NyYy9tYWluL2dyb292eS9vcmcvZ3JhaWxzL2RhdGFzdG9yZS9tYXBwaW5nL21vZGVsL0F1ZGl0TWV0YWRhdGFVdGlscy5ncm9vdnk=) | 60.0000% | [9 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/grails-core/pull/16580?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...ing/collection/AbstractPersistentCollection.groovy](https://app.codecov.io/gh/apache/grails-core/pull/16580?src=pr&el=tree&filepath=grails-datastore-core%2Fsrc%2Fmain%2Fgroovy%2Forg%2Fgrails%2Fdatastore%2Fmapping%2Fcollection%2FAbstractPersistentCollection.groovy&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Z3JhaWxzLWRhdGFzdG9yZS1jb3JlL3NyYy9tYWluL2dyb292eS9vcmcvZ3JhaWxzL2RhdGFzdG9yZS9tYXBwaW5nL2NvbGxlY3Rpb24vQWJzdHJhY3RQZXJzaXN0ZW50Q29sbGVjdGlvbi5ncm9vdnk=) | 93.6170% | [1 Missing and 8 partials :warning: ](https://app.codecov.io/gh/apache/grails-core/pull/16580?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | ... and [18 more](https://app.codecov.io/gh/apache/grails-core/pull/16580?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   [![Impacted file tree graph](https://app.codecov.io/gh/apache/grails-core/pull/16580/graphs/tree.svg?width=650&height=150&src=pr&token=qJrryhpk7u&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)](https://app.codecov.io/gh/apache/grails-core/pull/16580?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   
   ```diff
   @@                                 Coverage Diff                                  @@
   ##             refactor/java-to-groovy-grails-databinding-core     #16580   +/-   ##
   ====================================================================================
     Coverage                                                   ?   62.0933%           
     Complexity                                                 ?      28198           
   ====================================================================================
     Files                                                      ?       2222           
     Lines                                                      ?     110334           
     Branches                                                   ?      20124           
   ====================================================================================
     Hits                                                       ?      68510           
     Misses                                                     ?      32845           
     Partials                                                   ?       8979           
   ```
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/grails-core/pull/16580?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [...tore/mapping/cache/exception/CacheException.groovy](https://app.codecov.io/gh/apache/grails-core/pull/16580?src=pr&el=tree&filepath=grails-datastore-core%2Fsrc%2Fmain%2Fgroovy%2Forg%2Fgrails%2Fdatastore%2Fmapping%2Fcache%2Fexception%2FCacheException.groovy&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Z3JhaWxzLWRhdGFzdG9yZS1jb3JlL3NyYy9tYWluL2dyb292eS9vcmcvZ3JhaWxzL2RhdGFzdG9yZS9tYXBwaW5nL2NhY2hlL2V4Y2VwdGlvbi9DYWNoZUV4Y2VwdGlvbi5ncm9vdnk=) | `100.0000% <100.0000%> (ø)` | |
   | [...re/mapping/cache/impl/HashMapTPCacheAdapter.groovy](https://app.codecov.io/gh/apache/grails-core/pull/16580?src=pr&el=tree&filepath=grails-datastore-core%2Fsrc%2Fmain%2Fgroovy%2Forg%2Fgrails%2Fdatastore%2Fmapping%2Fcache%2Fimpl%2FHashMapTPCacheAdapter.groovy&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Z3JhaWxzLWRhdGFzdG9yZS1jb3JlL3NyYy9tYWluL2dyb292eS9vcmcvZ3JhaWxzL2RhdGFzdG9yZS9tYXBwaW5nL2NhY2hlL2ltcGwvSGFzaE1hcFRQQ2FjaGVBZGFwdGVyLmdyb292eQ==) | `100.0000% <100.0000%> (ø)` | |
   | [...ing/cache/impl/TPCacheAdapterRepositoryImpl.groovy](https://app.codecov.io/gh/apache/grails-core/pull/16580?src=pr&el=tree&filepath=grails-datastore-core%2Fsrc%2Fmain%2Fgroovy%2Forg%2Fgrails%2Fdatastore%2Fmapping%2Fcache%2Fimpl%2FTPCacheAdapterRepositoryImpl.groovy&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Z3JhaWxzLWRhdGFzdG9yZS1jb3JlL3NyYy9tYWluL2dyb292eS9vcmcvZ3JhaWxzL2RhdGFzdG9yZS9tYXBwaW5nL2NhY2hlL2ltcGwvVFBDYWNoZUFkYXB0ZXJSZXBvc2l0b3J5SW1wbC5ncm9vdnk=) | `100.0000% <100.0000%> (ø)` | |
   | [.../datastore/mapping/collection/PersistentSet.groovy](https://app.codecov.io/gh/apache/grails-core/pull/16580?src=pr&el=tree&filepath=grails-datastore-core%2Fsrc%2Fmain%2Fgroovy%2Forg%2Fgrails%2Fdatastore%2Fmapping%2Fcollection%2FPersistentSet.groovy&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Z3JhaWxzLWRhdGFzdG9yZS1jb3JlL3NyYy9tYWluL2dyb292eS9vcmcvZ3JhaWxzL2RhdGFzdG9yZS9tYXBwaW5nL2NvbGxlY3Rpb24vUGVyc2lzdGVudFNldC5ncm9vdnk=) | `100.0000% <100.0000%> (ø)` | |
   | [...tore/mapping/collection/PersistentSortedSet.groovy](https://app.codecov.io/gh/apache/grails-core/pull/16580?src=pr&el=tree&filepath=grails-datastore-core%2Fsrc%2Fmain%2Fgroovy%2Forg%2Fgrails%2Fdatastore%2Fmapping%2Fcollection%2FPersistentSortedSet.groovy&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Z3JhaWxzLWRhdGFzdG9yZS1jb3JlL3NyYy9tYWluL2dyb292eS9vcmcvZ3JhaWxzL2RhdGFzdG9yZS9tYXBwaW5nL2NvbGxlY3Rpb24vUGVyc2lzdGVudFNvcnRlZFNldC5ncm9vdnk=) | `100.0000% <100.0000%> (ø)` | |
   | [...re/mapping/core/ConnectionNotFoundException.groovy](https://app.codecov.io/gh/apache/grails-core/pull/16580?src=pr&el=tree&filepath=grails-datastore-core%2Fsrc%2Fmain%2Fgroovy%2Forg%2Fgrails%2Fdatastore%2Fmapping%2Fcore%2FConnectionNotFoundException.groovy&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Z3JhaWxzLWRhdGFzdG9yZS1jb3JlL3NyYy9tYWluL2dyb292eS9vcmcvZ3JhaWxzL2RhdGFzdG9yZS9tYXBwaW5nL2NvcmUvQ29ubmVjdGlvbk5vdEZvdW5kRXhjZXB0aW9uLmdyb292eQ==) | `100.0000% <100.0000%> (ø)` | |
   | [...s/datastore/mapping/core/DatastoreException.groovy](https://app.codecov.io/gh/apache/grails-core/pull/16580?src=pr&el=tree&filepath=grails-datastore-core%2Fsrc%2Fmain%2Fgroovy%2Forg%2Fgrails%2Fdatastore%2Fmapping%2Fcore%2FDatastoreException.groovy&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Z3JhaWxzLWRhdGFzdG9yZS1jb3JlL3NyYy9tYWluL2dyb292eS9vcmcvZ3JhaWxzL2RhdGFzdG9yZS9tYXBwaW5nL2NvcmUvRGF0YXN0b3JlRXhjZXB0aW9uLmdyb292eQ==) | `100.0000% <100.0000%> (ø)` | |
   | [...astore/mapping/core/EntityCreationException.groovy](https://app.codecov.io/gh/apache/grails-core/pull/16580?src=pr&el=tree&filepath=grails-datastore-core%2Fsrc%2Fmain%2Fgroovy%2Forg%2Fgrails%2Fdatastore%2Fmapping%2Fcore%2FEntityCreationException.groovy&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Z3JhaWxzLWRhdGFzdG9yZS1jb3JlL3NyYy9tYWluL2dyb292eS9vcmcvZ3JhaWxzL2RhdGFzdG9yZS9tYXBwaW5nL2NvcmUvRW50aXR5Q3JlYXRpb25FeGNlcHRpb24uZ3Jvb3Z5) | `100.0000% <100.0000%> (ø)` | |
   | [...re/mapping/core/IdentityGenerationException.groovy](https://app.codecov.io/gh/apache/grails-core/pull/16580?src=pr&el=tree&filepath=grails-datastore-core%2Fsrc%2Fmain%2Fgroovy%2Forg%2Fgrails%2Fdatastore%2Fmapping%2Fcore%2FIdentityGenerationException.groovy&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Z3JhaWxzLWRhdGFzdG9yZS1jb3JlL3NyYy9tYWluL2dyb292eS9vcmcvZ3JhaWxzL2RhdGFzdG9yZS9tYXBwaW5nL2NvcmUvSWRlbnRpdHlHZW5lcmF0aW9uRXhjZXB0aW9uLmdyb292eQ==) | `100.0000% <100.0000%> (ø)` | |
   | [.../mapping/core/MethodNotImplementedException.groovy](https://app.codecov.io/gh/apache/grails-core/pull/16580?src=pr&el=tree&filepath=grails-datastore-core%2Fsrc%2Fmain%2Fgroovy%2Forg%2Fgrails%2Fdatastore%2Fmapping%2Fcore%2FMethodNotImplementedException.groovy&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Z3JhaWxzLWRhdGFzdG9yZS1jb3JlL3NyYy9tYWluL2dyb292eS9vcmcvZ3JhaWxzL2RhdGFzdG9yZS9tYXBwaW5nL2NvcmUvTWV0aG9kTm90SW1wbGVtZW50ZWRFeGNlcHRpb24uZ3Jvb3Z5) | `100.0000% <100.0000%> (ø)` | |
   | ... and [137 more](https://app.codecov.io/gh/apache/grails-core/pull/16580?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
   </details>
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   - :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@grails.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] refactor: convert grails-datastore-core to Groovy [grails-core]

Posted by "borinquenkid (via GitHub)" <gi...@apache.org>.

borinquenkid commented on PR #16580:
URL: https://github.com/apache/grails-core/pull/16580#issuecomment-6278016253

   **Temporary CI flag on this stacked branch (BLOCKER before merge).**
   
   This Java-to-Groovy chain is a stack of PRs, and every push to any of them starts the full CI matrix, which is more runner time than the ASF allows us. Every PR in the stack except the one closest to its release branch (#16576) therefore carries one temporary commit, `CHANGEME FOR ACCEPTANCE`, that adds this to the root `gradle.properties`:
   
   ```
   skipTests=true
   skipCodeStyle=true
   ```
   
   With it, CI on this PR compiles but does not run tests or code style. The full build runs on #16576 (closest to 10.0.x), and each PR gets it when the PR below it has merged.
   
   **Condition for merging this PR:** that `gradle.properties` block (and the `CHANGEME FOR ACCEPTANCE` commit) must be dropped from this branch first, and CI must then be green with the tests running. A green check on this PR as it stands does not mean the tests ran. Rollout of the commit is branch by branch, so a branch may not carry it yet.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@grails.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] refactor: convert grails-datastore-core to Groovy [grails-core]

Posted by "testlens-app[bot] (via GitHub)" <gi...@apache.org>.

testlens-app[bot] commented on PR #16580:
URL: https://github.com/apache/grails-core/pull/16580#issuecomment-6209048953

   ## 🚨 All tests passed but jobs failed 🚨
   
   ### Failed Jobs without Test Failures
   
   ❌ [CI / Mongodb Functional Tests \(Java 21, MongoDB 8.0, indy\=false\)](https://github.com/apache/grails-core/actions/runs/38844123470/job/116790648656?pr=16580)
   
   🏷️ Commit: 181e7f5fcb39f6fce25c1ccba3577b12979bfdd5
   ▶️ Tests:  49949 executed
   🟡 Checks: 158/163 completed
   
   ### Rerun Controls
   
   Click the checkbox to trigger a rerun:
   
   🔲 **Rerun jobs**
   
   ---
   _Learn more about TestLens at [testlens.app/docs](https://testlens.app/docs/features/pr-comment/)._
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@grails.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] refactor: convert grails-datastore-core to Groovy [grails-core]

Posted by "testlens-app[bot] (via GitHub)" <gi...@apache.org>.

testlens-app[bot] commented on PR #16580:
URL: https://github.com/apache/grails-core/pull/16580#issuecomment-6114243020

   ## 🚨 All tests passed but jobs failed 🚨
   
   ### Failed Jobs without Test Failures
   
   ❌ [CI / Hibernate7 Functional Tests \(Java 25, indy\=false\)](https://github.com/apache/grails-core/actions/runs/38170636955/job/114562328622?pr=16580)
   
   🏷️ Commit: 850806c14d0f3c1228feea0b0df5487471177bc7
   ▶️ Tests:  57393 executed
   🟡 Checks: 78/79 completed
   
   ### Rerun Controls
   
   Click the checkbox to trigger a rerun:
   
   🔲 **Rerun jobs**
   
   ---
   _Learn more about TestLens at [testlens.app/docs](https://testlens.app/docs/features/pr-comment/)._
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@grails.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] refactor: convert grails-datastore-core to Groovy [grails-core]

Posted by "borinquenkid (via GitHub)" <gi...@apache.org>.

borinquenkid commented on PR #16580:
URL: https://github.com/apache/grails-core/pull/16580#issuecomment-6280544090

**Update: this branch now carries a different temporary CI commit (BLOCKER before merge).**

The earlier `skipTests`/`skipCodeStyle` flag in `gradle.properties` did not help enough: the functional jobs still compile the whole repository (about 57 minutes each) on every push, so it only saved around a fifth of the time. It has been removed.

In its place, every PR in this stack except #16576 (the one closest to 10.0.x) carries one temporary commit, `CHANGEME FOR ACCEPTANCE: disable PR workflow triggers`. It changes the `pull_request:` trigger of each workflow to `branches: ['CHANGEME-FOR-ACCEPTANCE']`, a branch that does not exist, so pushing, rebasing or force-pushing this branch starts no jobs.

**Condition for merging this PR:** that commit must be reverted on this branch first (`git revert` of the `CHANGEME FOR ACCEPTANCE` commit), and CI must then run and be green. **The absence of CI checks on this PR is deliberate and does not mean the code was tested.** The full build runs on #16576, and each PR gets it when the PR below it has merged.

--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@grails.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] refactor: convert grails-datastore-core to Groovy [grails-core]

Posted by "testlens-app[bot] (via GitHub) via notifications" <no...@grails.apache.org>.

testlens-app[bot] commented on PR #16580:
URL: https://github.com/apache/grails-core/pull/16580#issuecomment-6606609922

   ## 🔎 No tests executed 🔎
   
   🏷️ Commit: 289fa5c1a7fa669090071a23a20164117a950ab3
   ▶️ Tests:  0 executed
   ⚪️ Checks: 40/40 completed
   
   ---
   _Learn more about TestLens at [testlens.app/docs](https://testlens.app/docs/features/pr-comment/)._
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@grails.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] refactor: convert grails-datastore-core to Groovy [grails-core]

Posted by "testlens-app[bot] (via GitHub)" <gi...@apache.org>.

testlens-app[bot] commented on PR #16580:
URL: https://github.com/apache/grails-core/pull/16580#issuecomment-6256542183

   ## 🚨 All tests passed but jobs failed 🚨
   
   ### Failed Jobs without Test Failures
   
   ❌ [CI / Build Grails-Core Rerunning all Tasks \(Ubuntu JDK 21 shard 2\)](https://github.com/apache/grails-core/actions/runs/39176828437/job/117821111447?pr=16580)
   
   🏷️ Commit: 880396ffb791b026c6d8229eb447cf471153f5a1
   ▶️ Tests:  468 executed
   🟡 Checks: 12/79 completed
   
   ### Rerun Controls
   
   Click the checkbox to trigger a rerun:
   
   🔲 **Rerun jobs**
   
   ---
   _Learn more about TestLens at [testlens.app/docs](https://testlens.app/docs/features/pr-comment/)._
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@grails.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] refactor: convert grails-datastore-core to Groovy [grails-core]

Posted by "testlens-app[bot] (via GitHub)" <gi...@apache.org>.

testlens-app[bot] commented on PR #16580:
URL: https://github.com/apache/grails-core/pull/16580#issuecomment-6200169231

   ## ✅ All tests passed ✅
   
   🏷️ Commit: 22524cdfbf216443226c420293e04675d4bf85ff
   ▶️ Tests:  50395 executed
   ⚪️ Checks: 168/168 completed
   
   ---
   _Learn more about TestLens at [testlens.app/docs](https://testlens.app/docs/features/pr-comment/)._
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@grails.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] refactor: convert grails-datastore-core to Groovy [grails-core]

Posted by "borinquenkid (via GitHub) via notifications" <no...@grails.apache.org>.

borinquenkid closed pull request #16580: refactor: convert grails-datastore-core to Groovy
URL: https://github.com/apache/grails-core/pull/16580


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@grails.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] refactor: convert grails-datastore-core to Groovy [grails-core]

Posted by "testlens-app[bot] (via GitHub)" <gi...@apache.org>.

testlens-app[bot] commented on PR #16580:
URL: https://github.com/apache/grails-core/pull/16580#issuecomment-6102633505

   ## ✅ All tests passed ✅
   
   🏷️ Commit: fa765f1f07a0c8acf4ad609993a6c67b55a60e16
   ▶️ Tests:  73640 executed
   ⚪️ Checks: 81/81 completed
   
   ---
   _Learn more about TestLens at [testlens.app/docs](https://testlens.app/docs/features/pr-comment/)._
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@grails.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] refactor: convert grails-datastore-core to Groovy [grails-core]

Posted by "testlens-app[bot] (via GitHub)" <gi...@apache.org>.

testlens-app[bot] commented on PR #16580:
URL: https://github.com/apache/grails-core/pull/16580#issuecomment-6343972462

   ## 🔎 No tests executed 🔎
   
   🏷️ Commit: 05d02ab24c48b3388f3dedb863cfe667bdb8b5e8
   ▶️ Tests:  0 executed
   ⚪️ Checks: 42/42 completed
   
   ---
   _Learn more about TestLens at [testlens.app/docs](https://testlens.app/docs/features/pr-comment/)._
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@grails.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] refactor: convert grails-datastore-core to Groovy [grails-core]

Posted by "borinquenkid (via GitHub) via notifications" <no...@grails.apache.org>.

borinquenkid commented on PR #16580:
URL: https://github.com/apache/grails-core/pull/16580#issuecomment-6785722355

   Moving this stacked draft to my fork (borinquenkid/grails-core, same branch name) to cut review noise while it is downstream of active work. The branch stays here and will be reopened upstream when it is ready to be reviewed.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@grails.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org