You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@spamassassin.apache.org by Michael Parker <pa...@pobox.com> on 2006/10/25 15:39:39 UTC

Re: svn commit: r467629 - /spamassassin/trunk/lib/Mail/SpamAssassin/Plugin.pm

jm@apache.org wrote:
> Author: jm
> Date: Wed Oct 25 05:57:25 2006
> New Revision: 467629
> 
> URL: http://svn.apache.org/viewvc?view=rev&rev=467629
> Log:
> add public API to allow plugins to add methods to @TEMPORARY_METHODS.  Michael, may need to redo parts of this with backporting from yr branch, but it's required in trunk to fix a test failure here
> 

Hmmm.  So, I made finish_tests a plugin method so that each plugin can
handle this stuff on its own.  I'd rather NOT make this a supported
public plugin method, in favor of the other.

Thoughts?  Besides, getting off my ass and making the other just work.

Michael



Re: svn commit: r467629 - /spamassassin/trunk/lib/Mail/SpamAssassin/Plugin.pm

Posted by Michael Parker <pa...@pobox.com>.
Michael Parker wrote:
> jm@apache.org wrote:
>> Author: jm
>> Date: Wed Oct 25 05:57:25 2006
>> New Revision: 467629
>>
>> URL: http://svn.apache.org/viewvc?view=rev&rev=467629
>> Log:
>> add public API to allow plugins to add methods to @TEMPORARY_METHODS.  Michael, may need to redo parts of this with backporting from yr branch, but it's required in trunk to fix a test failure here
>>
> 
> Hmmm.  So, I made finish_tests a plugin method so that each plugin can
> handle this stuff on its own.  I'd rather NOT make this a supported
> public plugin method, in favor of the other.
> 
> Thoughts?  Besides, getting off my ass and making the other just work.
> 

To be clear, I'd rather keep finish_tests method and do away with the
register_generated_rule_method method.

Michael