You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@falcon.apache.org by "Ruslan Ostafiychuk (JIRA)" <ji...@apache.org> on 2014/12/01 14:35:12 UTC
[jira] [Updated] (FALCON-926) Fix problems found by findbugs in
merlin and merlin-core
[ https://issues.apache.org/jira/browse/FALCON-926?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ruslan Ostafiychuk updated FALCON-926:
--------------------------------------
Description:
Errors before fix:
{code}
INFO] Total bugs: 11
[INFO] org.apache.falcon.regression.core.helpers.LineageHelper.getResponseString(HttpResponse) may fail to close stream ["org.apache.falcon.regression.core.helpers.LineageHelper"] At LineageHelper.java:[lines 51-340]
[INFO] org.apache.falcon.regression.core.helpers.LineageHelper.getUrl(LineageHelper$URL, String, Map) makes inefficient use of keySet iterator instead of entrySet iterator ["org.apache.falcon.regression.core.helpers.LineageHelper"] At LineageHelper.java:[lines 51-340]
[INFO] new org.apache.falcon.regression.core.response.ServiceResponse(HttpResponse) may fail to close stream ["org.apache.falcon.regression.core.response.ServiceResponse"] At ServiceResponse.java:[lines 38-119]
[INFO] exceptional return value of java.io.File.delete() ignored in org.apache.falcon.regression.core.supportClasses.HadoopFileEditor.edit(String, String, String) ["org.apache.falcon.regression.core.supportClasses.HadoopFileEditor"] At HadoopFileEditor.java:[lines 38-110]
[INFO] org.apache.falcon.regression.core.util.ExecUtil.runRemoteScriptAsSudo(String, String, String, String, String, String) may fail to close stream ["org.apache.falcon.regression.core.util.ExecUtil"] At ExecUtil.java:[lines 47-170]
[INFO] org.apache.falcon.regression.core.util.HadoopUtil.copyDataToFolders(FileSystem, String, List, String[]) may fail to clean up java.io.Writer on checked exception ["org.apache.falcon.regression.core.util.HadoopUtil", "java.io.Writer"] At HadoopUtil.java:[lines 39-486]At Writer.java:[lines 50-294]
[INFO] org.apache.falcon.regression.core.util.InstanceUtil.hitUrl(String, String, String) may fail to close stream ["org.apache.falcon.regression.core.util.InstanceUtil"] At InstanceUtil.java:[lines 86-1281]
[INFO] org.apache.falcon.regression.core.util.InstanceUtil.getSequenceBundleID(OozieClient, String, EntityType, int) makes inefficient use of keySet iterator instead of entrySet iterator ["org.apache.falcon.regression.core.util.InstanceUtil"] At InstanceUtil.java:[lines 86-1281]
[INFO] return value of org.joda.time.DateTime.withZoneRetainFields(DateTimeZone) ignored, is this OK in org.apache.falcon.regression.core.util.TimeUtil.sleepTill(String) ["org.apache.falcon.regression.core.util.TimeUtil"] At TimeUtil.java:[lines 42-277]
[INFO] Null passed for nonnull parameter of execute(HttpRequest) in org.apache.falcon.request.BaseRequest.run() ["org.apache.falcon.request.BaseRequest"] At BaseRequest.java:[lines 61-199]
[INFO] Null passed for nonnull parameter of execute(HttpRequest) in org.apache.falcon.request.BaseRequest.run() ["org.apache.falcon.request.BaseRequest"] At BaseRequest.java:[lines 61-199]
{code}
> Fix problems found by findbugs in merlin and merlin-core
> --------------------------------------------------------
>
> Key: FALCON-926
> URL: https://issues.apache.org/jira/browse/FALCON-926
> Project: Falcon
> Issue Type: Sub-task
> Components: merlin
> Reporter: Ruslan Ostafiychuk
> Assignee: Ruslan Ostafiychuk
>
> Errors before fix:
> {code}
> INFO] Total bugs: 11
> [INFO] org.apache.falcon.regression.core.helpers.LineageHelper.getResponseString(HttpResponse) may fail to close stream ["org.apache.falcon.regression.core.helpers.LineageHelper"] At LineageHelper.java:[lines 51-340]
> [INFO] org.apache.falcon.regression.core.helpers.LineageHelper.getUrl(LineageHelper$URL, String, Map) makes inefficient use of keySet iterator instead of entrySet iterator ["org.apache.falcon.regression.core.helpers.LineageHelper"] At LineageHelper.java:[lines 51-340]
> [INFO] new org.apache.falcon.regression.core.response.ServiceResponse(HttpResponse) may fail to close stream ["org.apache.falcon.regression.core.response.ServiceResponse"] At ServiceResponse.java:[lines 38-119]
> [INFO] exceptional return value of java.io.File.delete() ignored in org.apache.falcon.regression.core.supportClasses.HadoopFileEditor.edit(String, String, String) ["org.apache.falcon.regression.core.supportClasses.HadoopFileEditor"] At HadoopFileEditor.java:[lines 38-110]
> [INFO] org.apache.falcon.regression.core.util.ExecUtil.runRemoteScriptAsSudo(String, String, String, String, String, String) may fail to close stream ["org.apache.falcon.regression.core.util.ExecUtil"] At ExecUtil.java:[lines 47-170]
> [INFO] org.apache.falcon.regression.core.util.HadoopUtil.copyDataToFolders(FileSystem, String, List, String[]) may fail to clean up java.io.Writer on checked exception ["org.apache.falcon.regression.core.util.HadoopUtil", "java.io.Writer"] At HadoopUtil.java:[lines 39-486]At Writer.java:[lines 50-294]
> [INFO] org.apache.falcon.regression.core.util.InstanceUtil.hitUrl(String, String, String) may fail to close stream ["org.apache.falcon.regression.core.util.InstanceUtil"] At InstanceUtil.java:[lines 86-1281]
> [INFO] org.apache.falcon.regression.core.util.InstanceUtil.getSequenceBundleID(OozieClient, String, EntityType, int) makes inefficient use of keySet iterator instead of entrySet iterator ["org.apache.falcon.regression.core.util.InstanceUtil"] At InstanceUtil.java:[lines 86-1281]
> [INFO] return value of org.joda.time.DateTime.withZoneRetainFields(DateTimeZone) ignored, is this OK in org.apache.falcon.regression.core.util.TimeUtil.sleepTill(String) ["org.apache.falcon.regression.core.util.TimeUtil"] At TimeUtil.java:[lines 42-277]
> [INFO] Null passed for nonnull parameter of execute(HttpRequest) in org.apache.falcon.request.BaseRequest.run() ["org.apache.falcon.request.BaseRequest"] At BaseRequest.java:[lines 61-199]
> [INFO] Null passed for nonnull parameter of execute(HttpRequest) in org.apache.falcon.request.BaseRequest.run() ["org.apache.falcon.request.BaseRequest"] At BaseRequest.java:[lines 61-199]
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)