You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@royale.apache.org by jo...@apache.org on 2020/01/16 20:53:41 UTC
[royale-compiler] branch develop updated (4efb7de -> e14c7ef)
This is an automated email from the ASF dual-hosted git repository.
joshtynjala pushed a change to branch develop
in repository https://gitbox.apache.org/repos/asf/royale-compiler.git.
from 4efb7de add getter function for binding to properties of private members
new a06ef7f MXMLDescriptorSpecifier: uses goog.reflect.objectProperty() to allow Closure renaming in release build
new e14c7ef JSGoogConfigs: warn-public-vars defaults to false because it shouldn't be necessary anymore
The 2 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails. The revisions
listed as "add" were already present in the repository and have only
been added to this reference.
Summary of changes:
.../codegen/js/goog/JSGoogEmitterTokens.java | 1 +
.../codegen/mxml/royale/MXMLDescriptorSpecifier.java | 20 +++++++++++++++++---
.../driver/js/goog/JSGoogCompcConfiguration.java | 2 +-
.../internal/driver/js/goog/JSGoogConfiguration.java | 2 +-
4 files changed, 20 insertions(+), 5 deletions(-)
[royale-compiler] 02/02: JSGoogConfigs: warn-public-vars defaults
to false because it shouldn't be necessary anymore
Posted by jo...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
joshtynjala pushed a commit to branch develop
in repository https://gitbox.apache.org/repos/asf/royale-compiler.git
commit e14c7ef1fc1dba5965bd96b1cc7a5b90604d7d4e
Author: Josh Tynjala <jo...@apache.org>
AuthorDate: Thu Jan 16 12:53:32 2020 -0800
JSGoogConfigs: warn-public-vars defaults to false because it shouldn't be necessary anymore
---
.../compiler/internal/driver/js/goog/JSGoogCompcConfiguration.java | 2 +-
.../royale/compiler/internal/driver/js/goog/JSGoogConfiguration.java | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/compiler-jx/src/main/java/org/apache/royale/compiler/internal/driver/js/goog/JSGoogCompcConfiguration.java b/compiler-jx/src/main/java/org/apache/royale/compiler/internal/driver/js/goog/JSGoogCompcConfiguration.java
index 2fa9464..a63a741 100644
--- a/compiler-jx/src/main/java/org/apache/royale/compiler/internal/driver/js/goog/JSGoogCompcConfiguration.java
+++ b/compiler-jx/src/main/java/org/apache/royale/compiler/internal/driver/js/goog/JSGoogCompcConfiguration.java
@@ -446,7 +446,7 @@ public class JSGoogCompcConfiguration extends JSConfiguration
// 'warn-public-vars'
//
- private boolean warnPublicVars = true;
+ private boolean warnPublicVars = false;
public boolean getWarnPublicVars()
{
diff --git a/compiler-jx/src/main/java/org/apache/royale/compiler/internal/driver/js/goog/JSGoogConfiguration.java b/compiler-jx/src/main/java/org/apache/royale/compiler/internal/driver/js/goog/JSGoogConfiguration.java
index d4e5328..9942bd0 100644
--- a/compiler-jx/src/main/java/org/apache/royale/compiler/internal/driver/js/goog/JSGoogConfiguration.java
+++ b/compiler-jx/src/main/java/org/apache/royale/compiler/internal/driver/js/goog/JSGoogConfiguration.java
@@ -451,7 +451,7 @@ public class JSGoogConfiguration extends JSConfiguration
// 'warn-public-vars'
//
- private boolean warnPublicVars = true;
+ private boolean warnPublicVars = false;
public boolean getWarnPublicVars()
{
[royale-compiler] 01/02: MXMLDescriptorSpecifier: uses
goog.reflect.objectProperty() to allow Closure renaming in release build
Posted by jo...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
joshtynjala pushed a commit to branch develop
in repository https://gitbox.apache.org/repos/asf/royale-compiler.git
commit a06ef7f1c94cf45fbb28acc9a4f218a815982bfd
Author: Josh Tynjala <jo...@apache.org>
AuthorDate: Thu Jan 16 12:43:49 2020 -0800
MXMLDescriptorSpecifier: uses goog.reflect.objectProperty() to allow Closure renaming in release build
---
.../codegen/js/goog/JSGoogEmitterTokens.java | 1 +
.../codegen/mxml/royale/MXMLDescriptorSpecifier.java | 20 +++++++++++++++++---
2 files changed, 18 insertions(+), 3 deletions(-)
diff --git a/compiler-jx/src/main/java/org/apache/royale/compiler/internal/codegen/js/goog/JSGoogEmitterTokens.java b/compiler-jx/src/main/java/org/apache/royale/compiler/internal/codegen/js/goog/JSGoogEmitterTokens.java
index 8afd294..d615b9f 100644
--- a/compiler-jx/src/main/java/org/apache/royale/compiler/internal/codegen/js/goog/JSGoogEmitterTokens.java
+++ b/compiler-jx/src/main/java/org/apache/royale/compiler/internal/codegen/js/goog/JSGoogEmitterTokens.java
@@ -24,6 +24,7 @@ public enum JSGoogEmitterTokens implements IEmitterTokens
{
AS3("__AS3__"),
GOOG_ARRAY_FOREACH("goog.array.forEach"),
+ GOOG_REFLECT_OBJECTPROPERTY("goog.reflect.objectProperty"),
GOOG_BASE("base"),
GOOG_CALL("call"),
GOOG_BIND("goog.bind"),
diff --git a/compiler-jx/src/main/java/org/apache/royale/compiler/internal/codegen/mxml/royale/MXMLDescriptorSpecifier.java b/compiler-jx/src/main/java/org/apache/royale/compiler/internal/codegen/mxml/royale/MXMLDescriptorSpecifier.java
index 900d118..eecca50 100644
--- a/compiler-jx/src/main/java/org/apache/royale/compiler/internal/codegen/mxml/royale/MXMLDescriptorSpecifier.java
+++ b/compiler-jx/src/main/java/org/apache/royale/compiler/internal/codegen/mxml/royale/MXMLDescriptorSpecifier.java
@@ -22,6 +22,7 @@ package org.apache.royale.compiler.internal.codegen.mxml.royale;
import java.util.ArrayList;
import org.apache.royale.compiler.internal.codegen.as.ASEmitterTokens;
+import org.apache.royale.compiler.internal.codegen.js.goog.JSGoogEmitterTokens;
/**
* @author Erik de Bruin
@@ -151,9 +152,22 @@ public class MXMLDescriptorSpecifier extends MXMLNodeSpecifier
private String outputPropertySpecifier(boolean writeNewline)
{
- write((isProperty) ? ASEmitterTokens.SINGLE_QUOTE.getToken() : "");
- write(name);
- write((isProperty) ? ASEmitterTokens.SINGLE_QUOTE.getToken() : "");
+ if (isProperty)
+ {
+ write(JSGoogEmitterTokens.GOOG_REFLECT_OBJECTPROPERTY);
+ write(ASEmitterTokens.PAREN_OPEN);
+ write(ASEmitterTokens.SINGLE_QUOTE);
+ write(name);
+ write(ASEmitterTokens.SINGLE_QUOTE);
+ write(ASEmitterTokens.COMMA);
+ write(ASEmitterTokens.SPACE);
+ write(ASEmitterTokens.THIS);
+ write(ASEmitterTokens.PAREN_CLOSE);
+ }
+ else
+ {
+ write(name);
+ }
writeDelimiter(writeNewline);
if (isProperty)