[GitHub] [flink] AHeise commented on a change in pull request #10345: [FLINK-12484][runtime] synchronize all mailbox actions

[GitBox <gi...@apache.org>]

AHeise commented on a change in pull request #10345: [FLINK-12484][runtime] synchronize all mailbox actions
URL: https://github.com/apache/flink/pull/10345#discussion_r352363929
 
 

 ##########
 File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/StreamTask.java
 ##########
 @@ -384,57 +386,59 @@ protected Counter setupNumRecordsInCounter(StreamOperator streamOperator) {
 		}
 	}
 
-	@Override
-	public final void invoke() throws Exception {
+	private void beforeInvoke() throws Exception {
 
 Review comment:
   Yes, I'd propose to prefill it in `init`, but I can see the point of not wanting to change all the subclasses.
   If we cannot find a good name for the method, maybe that's a sign that the new method is actually still doing too much?
   But if it's too much effort to think about it, just keep as is, so that we can finish before feature freeze.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services