[GitHub] [cloudstack] RodrigoDLopez commented on issue #3925: Add cache mode param properly

[GitBox <gi...@apache.org>]

RodrigoDLopez commented on issue #3925: Add cache mode param properly
URL: https://github.com/apache/cloudstack/pull/3925#issuecomment-596489974
 
 
   Hi @radu-todirica , nice feature.
   I tested it manually using cloudmonkey.
   Tests consist of:
   1. create disk offering
   2. list serviceOffering
       {
         "cacheMode": "writeback",
         "displaytext": "test cache write-back",
         "id": "f511131c-9f9d-4e3d-ab64-51795654cd2d",
       },
       {
         "cacheMode": "writethrough",
         "displaytext": "test cache write trough",
         "id": "0b981c95-74b4-4fe9-b996-6c9fcdbf077d",
       }
   3. create VMs
   4. list VM instances and checked if the correct seviceOffering id is present
   Instance with writeback cache mode:
       {
           "serviceofferingid": "f511131c-9f9d-4e3d-ab64-51795654cd2d",
           "serviceofferingname": "test cache write-back",
       }
   Instance with writetrough cache mode:
       {
           "serviceofferingid": "0b981c95-74b4-4fe9-b996-6c9fcdbf077d",
           "serviceofferingname": "test cache write-trough",
       }
   All good with cache mode for serviceOffering.
   5. verify diskOffering 
       {
         "cacheMode": "writethrough",
         "displaytext": "test cache write trough",
         "id": "5f6ff1c3-e0bb-4c6a-a7e9-5863ab22c8c3",
       },
       {
         "cacheMode": "writeback",
         "displaytext": "test cache write back",
         "id": "a04abd52-4b0c-4aff-84d2-c1856705db1b",
       }
   6. create some Vms and check the virsh dumpxml
   6.1 Dump of a VM using cache mode write-trough:
       {
           <disk type='file' device='disk'>
           <driver name='qemu' type='qcow2' cache='writethrough'/>
       }
   More info about diskOffering for this instance with cmk:
       {
           "diskofferingid": "a04abd52-4b0c-4aff-84d2-c1856705db1b",
           "diskofferingname": "test cache write back",
       }
   6.2 create a instance with writeback cache mode:
       {
           <disk type='file' device='disk'>
           <driver name='qemu' type='qcow2' cache='writeback'/>
       }
       {
           "diskofferingid": "5f6ff1c3-e0bb-4c6a-a7e9-5863ab22c8c3",
           "diskofferingname": "teste cache",
       }
   LGMT based on manual tests, nice feature, and nice code too.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services