You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2020/10/12 06:07:50 UTC
[GitHub] [arrow] liyafan82 opened a new pull request #8438: ARROW-10277: [C++] Support comparing scalars approximately
liyafan82 opened a new pull request #8438:
URL: https://github.com/apache/arrow/pull/8438
As discussed in https://github.com/apache/arrow/pull/7748#discussion_r469997286, we need to compare scalars approximately in some scenarios.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] pitrou commented on pull request #8438: ARROW-10277: [C++] Support comparing scalars approximately
Posted by GitBox <gi...@apache.org>.
pitrou commented on pull request #8438:
URL: https://github.com/apache/arrow/pull/8438#issuecomment-740083588
+1. Will merge now that this is green.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] pitrou closed pull request #8438: ARROW-10277: [C++] Support comparing scalars approximately
Posted by GitBox <gi...@apache.org>.
pitrou closed pull request #8438:
URL: https://github.com/apache/arrow/pull/8438
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] liyafan82 commented on pull request #8438: ARROW-10277: [C++] Support comparing scalars approximately
Posted by GitBox <gi...@apache.org>.
liyafan82 commented on pull request #8438:
URL: https://github.com/apache/arrow/pull/8438#issuecomment-740323110
@pitrou Thanks for your effort.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] pitrou commented on pull request #8438: ARROW-10277: [C++] Support comparing scalars approximately
Posted by GitBox <gi...@apache.org>.
pitrou commented on pull request #8438:
URL: https://github.com/apache/arrow/pull/8438#issuecomment-739845305
Sorry for the delay @liyafan82 . I will take a look at this now.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] pitrou commented on pull request #8438: ARROW-10277: [C++] Support comparing scalars approximately
Posted by GitBox <gi...@apache.org>.
pitrou commented on pull request #8438:
URL: https://github.com/apache/arrow/pull/8438#issuecomment-740001704
I more or less rewrote this PR entirely as I identified other issues that were entangled with this one, and added a bunch of tests.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #8438: ARROW-10277: [C++] Support comparing scalars approximately
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #8438:
URL: https://github.com/apache/arrow/pull/8438#issuecomment-706888492
https://issues.apache.org/jira/browse/ARROW-10277
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org